]> git.koha-community.org Git - koha.git/commit
Bug 8772 - Uninitialized variable triggers error log entry in smart_rules.pl
authorMark Tompsett <mtompset@hotmail.com>
Tue, 18 Sep 2012 16:05:24 +0000 (00:05 +0800)
committerChris Cormack <chrisc@catalyst.net.nz>
Tue, 9 Oct 2012 21:36:42 +0000 (10:36 +1300)
commit5e3733fc823af61c81fe1db916c838c2f15d6023
tree7797d36f674d0cade5ce0975c68801f8fe895026
parent879443e9d8d8d2c36d134d4172cf808ef6e0abb3
Bug 8772 - Uninitialized variable triggers error log entry in smart_rules.pl

Changed declartion from:
  my $op = $input->param('op');
to
  my $op = $input->param('op') || q{};
in order to give an empty string default preventing error
logs from filling needlessly.

Signed-off-by: Marc Veron <veron@veron.ch>
The patch removes warnings like:
Use of uninitialized value $op in string eq at...

However there is one more warning, but it is not related to $op (addressed by this patch):
smart-rules.pl: Use of uninitialized value in string ne at .../admin/smart-rules.pl line 388.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
admin/smart-rules.pl