From 6c3a28b64032d0dcad57df222c42e163385d2e98 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Mon, 20 May 2013 16:54:53 +0100 Subject: [PATCH] Bug 10291: Clarify misleading variable name Remove the unrequired extra processing and pass the array of itemnumbers as itemnumbers_array Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 4 ++-- tools/batchMod.pl | 3 +-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt index 5404f02aca..292b81f65c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt @@ -119,8 +119,8 @@ for( x=0; xToo many items ([% too_many_items %]) to display individually.

- [% FOREACH itemnumbers_hashre IN itemnumbers_hashref %] - + [% FOREACH itemnumber IN itemnumbers_array %] + [% END %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt index 01d0bc159a..de67517fd0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt @@ -141,8 +141,8 @@ $(document).ready(function(){ [% IF ( too_many_items ) %]

Too many items ([% too_many_items %]): not displaying each one individually.

- [% FOREACH itemnumbers_hashre IN itemnumbers_hashref %] - + [% FOREACH itemnumber IN itemnumbers_array %] + [% END %] [% END %] diff --git a/tools/batchMod.pl b/tools/batchMod.pl index c2994871ff..ec0ef01363 100755 --- a/tools/batchMod.pl +++ b/tools/batchMod.pl @@ -261,8 +261,7 @@ if ($op eq "show"){ } else { $template->param("too_many_items" => scalar(@itemnumbers)); # Even if we do not display the items, we need the itemnumbers - my @itemnumbers_hashref = map {{itemnumber => $_}} @itemnumbers; - $template->param("itemnumbers_hashref" => \@itemnumbers_hashref); + $template->param(itemnumbers_array => \@itemnumbers); } # now, build the item form for entering a new item my @loop_data =(); -- 2.39.5