11 use Test::More tests => 6;
13 use t::lib::TestBuilder;
17 use_ok('C4::Reserves');
20 my $schema = Koha::Database->schema;
21 $schema->storage->txn_begin;
22 my $dbh = C4::Context->dbh;
24 my $builder = t::lib::TestBuilder->new;
26 my $library1 = $builder->build({
29 my $library2 = $builder->build({
34 t::lib::Mocks::mock_userenv({ branchcode => $library1->{branchcode} });
36 my $bib_title = "Test Title";
38 my $borrower1 = $builder->build({
41 branchcode => $library1->{branchcode},
42 dateexpiry => '3000-01-01',
46 my $borrower2 = $builder->build({
49 branchcode => $library1->{branchcode},
50 dateexpiry => '3000-01-01',
54 # Test hold_fulfillment_policy
55 my ( $itemtype ) = @{ $dbh->selectrow_arrayref("SELECT itemtype FROM itemtypes LIMIT 1") };
56 my $borrowernumber1 = $borrower1->{borrowernumber};
57 my $borrowernumber2 = $borrower2->{borrowernumber};
58 my $library_A = $library1->{branchcode};
59 my $library_B = $library2->{branchcode};
61 $dbh->do("INSERT INTO biblio (frameworkcode, author, title, datecreated) VALUES ('', 'Koha test', '$bib_title', '2011-02-01')");
63 my $biblionumber = $dbh->selectrow_array("SELECT biblionumber FROM biblio WHERE title = '$bib_title'")
64 or BAIL_OUT("Cannot find newly created biblio record");
66 $dbh->do("INSERT INTO biblioitems (biblionumber, itemtype) VALUES ($biblionumber, '$itemtype')");
68 my $biblioitemnumber =
69 $dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber")
70 or BAIL_OUT("Cannot find newly created biblioitems record");
73 INSERT INTO items (barcode, biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype)
74 VALUES ('AllowHoldIf1', $biblionumber, $biblioitemnumber, '$library_A', '$library_A', 0, 0, 0, 0, NULL, '$itemtype')
78 $dbh->selectrow_array("SELECT itemnumber FROM items WHERE biblionumber = $biblionumber")
79 or BAIL_OUT("Cannot find newly created item");
81 my $item1 = Koha::Items->find( $itemnumber1 )->unblessed;
84 INSERT INTO items (barcode, biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype)
85 VALUES ('AllowHoldIf2', $biblionumber, $biblioitemnumber, '$library_A', '$library_A', 0, 0, 0, 0, NULL, '$itemtype')
89 $dbh->selectrow_array("SELECT itemnumber FROM items WHERE biblionumber = $biblionumber ORDER BY itemnumber DESC")
90 or BAIL_OUT("Cannot find newly created item");
92 my $item2 = Koha::Items->find( $itemnumber2 )->unblessed;
94 $dbh->do("DELETE FROM issuingrules");
95 my $rule = Koha::IssuingRule->new(
103 reservesallowed => 99,
109 my $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
110 is( $is, 0, "Item cannot be held, 2 items available" );
112 my $issue1 = AddIssue( $borrower2, $item1->{barcode} );
114 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
115 is( $is, 0, "Item cannot be held, 1 item available" );
117 AddIssue( $borrower2, $item2->{barcode} );
119 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
120 is( $is, 1, "Item can be held, no items available" );
122 AddReturn( $item1->{barcode} );
124 { # Remove the issue for the first patron, and modify the branch for item1
125 subtest 'IsAvailableForItemLevelRequest behaviours depending on ReservesControlBranch + holdallowed' => sub {
128 my $hold_allowed_from_home_library = 1;
129 my $hold_allowed_from_any_libraries = 2;
130 my $sth_delete_rules = $dbh->prepare(q|DELETE FROM default_circ_rules|);
131 my $sth_insert_rule = $dbh->prepare(q|INSERT INTO default_circ_rules(singleton, maxissueqty, maxonsiteissueqty, holdallowed, hold_fulfillment_policy, returnbranch) VALUES ('singleton', NULL, NULL, ?, 'any', 'homebranch');|);
133 subtest 'Item is available at a different library' => sub {
136 $item1 = Koha::Items->find( $item1->{itemnumber} );
137 $item1->set({homebranch => $library_B, holdingbranch => $library_B })->store;
138 $item1 = $item1->unblessed;
140 #One shelf holds is 'If all unavailable'/2
141 #Item 1 homebranch library B is available
142 #Item 2 homebranch library A is checked out
143 #Borrower1 is from library A
144 #CircControl has no effect - same rule for all branches as set at line 96
145 #FIXME: ReservesControlBranch is not checked in these subs we are testing
148 $sth_delete_rules->execute;
149 $sth_insert_rule->execute( $hold_allowed_from_home_library );
151 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
152 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
153 is( $is, 1, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at different library, not holdable = none available => the hold is allowed at item level" );
155 t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
156 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
157 is( $is, 1, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at different library, not holdable = none available => the hold is allowed at item level" );
161 $sth_delete_rules->execute;
162 $sth_insert_rule->execute( $hold_allowed_from_any_libraries );
164 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
165 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
166 is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the diff library, holdable = 1 available => the hold is not allowed at item level" );
168 t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
169 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
170 is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the diff library, holdable = 1 available => the hold is not allowed at item level" );
174 subtest 'Item is available at the same library' => sub {
177 $item1 = Koha::Items->find( $item1->{itemnumber} );
178 $item1->set({homebranch => $library_A, holdingbranch => $library_A })->store;
179 $item1 = $item1->unblessed;
181 #One shelf holds is 'If all unavailable'/2
182 #Item 1 homebranch library A is available
183 #Item 2 homebranch library A is checked out
184 #Borrower1 is from library A
185 #CircControl has no effect - same rule for all branches as set at line 96
186 #ReservesControlBranch is not checked in these subs we are testing?
189 $sth_delete_rules->execute;
190 $sth_insert_rule->execute( $hold_allowed_from_home_library );
192 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
193 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
194 is( $is, 0, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" );
196 t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
197 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
198 is( $is, 0, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" );
202 $sth_delete_rules->execute;
203 $sth_insert_rule->execute( $hold_allowed_from_any_libraries );
205 t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
206 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
207 is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" );
209 t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
210 $is = IsAvailableForItemLevelRequest( $item1, $borrower1);
211 is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" );
217 my $biblio = $builder->build({
221 my $item3 = $builder->build({
224 biblionumber => $biblio->{biblionumber},
233 my $hold = $builder->build({
236 itemnumber => $item3->{itemnumber},
241 $dbh->do("DELETE FROM issuingrules");
242 $rule = Koha::IssuingRule->new(
250 reservesallowed => 99,
256 $is = IsAvailableForItemLevelRequest( $item3, $borrower1);
257 is( $is, 1, "Item can be held, items in transit are not available" );
260 $schema->storage->txn_rollback;