Bug 31796: Add REST endpoint to modify an authority
[koha.git] / t / db_dependent / api / v1 / authorities.t
1 #!/usr/bin/env perl
2
3 # This file is part of Koha.
4 #
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
9 #
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
14 #
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
17
18 use Modern::Perl;
19
20 use utf8;
21 use Encode;
22
23 use Test::More tests => 4;
24 use Test::MockModule;
25 use Test::Mojo;
26 use Test::Warn;
27
28 use t::lib::Mocks;
29 use t::lib::TestBuilder;
30
31 use C4::Auth;
32
33 use Koha::Authorities;
34
35 my $schema  = Koha::Database->new->schema;
36 my $builder = t::lib::TestBuilder->new;
37
38 t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
39
40 my $t = Test::Mojo->new('Koha::REST::V1');
41
42 subtest 'get() tests' => sub {
43
44     plan tests => 20;
45
46     $schema->storage->txn_begin;
47
48     my $patron = $builder->build_object(
49         {
50             class => 'Koha::Patrons',
51             value => { flags => 0 }
52         }
53     );
54     my $password = 'thePassword123';
55     $patron->set_password( { password => $password, skip_validation => 1 } );
56     $patron->discard_changes;
57     my $userid = $patron->userid;
58
59     my $authority = $builder->build_object({ 'class' => 'Koha::Authorities', value => {
60       marcxml => q|<?xml version="1.0" encoding="UTF-8"?>
61 <record xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/MARC21/slim" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd">
62     <controlfield tag="001">1001</controlfield>
63     <datafield tag="110" ind1=" " ind2=" ">
64         <subfield code="9">102</subfield>
65         <subfield code="a">My Corporation</subfield>
66     </datafield>
67 </record>|
68     } });
69
70     $t->get_ok("//$userid:$password@/api/v1/authorities/" . $authority->authid)
71       ->status_is(403);
72
73     $patron->flags(4)->store;
74
75     $t->get_ok( "//$userid:$password@/api/v1/authorities/" . $authority->authid
76                 => { Accept => 'application/weird+format' } )
77       ->status_is(400);
78
79     $t->get_ok( "//$userid:$password@/api/v1/authorities/" . $authority->authid
80                  => { Accept => 'application/json' } )
81       ->status_is(200)
82       ->json_is( '/authid', $authority->authid )
83       ->json_is( '/authtypecode', $authority->authtypecode );
84
85     $t->get_ok( "//$userid:$password@/api/v1/authorities/" . $authority->authid
86                  => { Accept => 'application/marcxml+xml' } )
87       ->status_is(200);
88
89     $t->get_ok( "//$userid:$password@/api/v1/authorities/" . $authority->authid
90                  => { Accept => 'application/marc-in-json' } )
91       ->status_is(200);
92
93     $t->get_ok( "//$userid:$password@/api/v1/authorities/" . $authority->authid
94                  => { Accept => 'application/marc' } )
95       ->status_is(200);
96
97     $t->get_ok( "//$userid:$password@/api/v1/authorities/" . $authority->authid
98                  => { Accept => 'text/plain' } )
99       ->status_is(200)
100       ->content_is(q|LDR 00079     2200049   4500
101 001     1001
102 110    _9102
103        _aMy Corporation|);
104
105     $authority->delete;
106     $t->get_ok( "//$userid:$password@/api/v1/authorities/" . $authority->authid
107                  => { Accept => 'application/marc' } )
108       ->status_is(404)
109       ->json_is( '/error', 'Object not found.' );
110
111     $schema->storage->txn_rollback;
112 };
113
114 subtest 'delete() tests' => sub {
115
116     plan tests => 7;
117
118     $schema->storage->txn_begin;
119
120     my $patron = $builder->build_object(
121         {
122             class => 'Koha::Patrons',
123             value => { flags => 0 } # no permissions
124         }
125     );
126     my $password = 'thePassword123';
127     $patron->set_password( { password => $password, skip_validation => 1 } );
128     my $userid = $patron->userid;
129
130     my $authority = $builder->build_object({ 'class' => 'Koha::Authorities', value => {
131       marcxml => q|<?xml version="1.0" encoding="UTF-8"?>
132 <record xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/MARC21/slim" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd">
133     <controlfield tag="001">1001</controlfield>
134     <datafield tag="110" ind1=" " ind2=" ">
135         <subfield code="9">102</subfield>
136         <subfield code="a">My Corporation</subfield>
137     </datafield>
138 </record>|
139     } });
140
141     $t->delete_ok("//$userid:$password@/api/v1/authorities/".$authority->authid)
142       ->status_is(403, 'Not enough permissions makes it return the right code');
143
144     $patron->flags( 2 ** 14 )->store; # 14 => editauthorities userflag
145
146     $t->delete_ok("//$userid:$password@/api/v1/authorities/".$authority->authid)
147       ->status_is(204, 'SWAGGER3.2.4')
148       ->content_is('', 'SWAGGER3.3.4');
149
150     $t->delete_ok("//$userid:$password@/api/v1/authorities/".$authority->authid)
151       ->status_is(404);
152
153     $schema->storage->txn_rollback;
154 };
155
156 subtest 'post() tests' => sub {
157
158     plan tests => 19;
159
160     $schema->storage->txn_begin;
161
162     my $authorities_mock = Test::MockModule->new('C4::AuthoritiesMarc');
163     $authorities_mock->mock( 'FindDuplicateAuthority', sub { return 1234; } );
164
165     my $patron = $builder->build_object(
166         {
167             class => 'Koha::Patrons',
168             value => { flags => 0 } # no permissions
169         }
170     );
171     my $password = 'thePassword123';
172     $patron->set_password( { password => $password, skip_validation => 1 } );
173     my $userid = $patron->userid;
174
175     my $marcxml = q|<?xml version="1.0" encoding="UTF-8"?>
176 <record xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/MARC21/slim" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd">
177     <controlfield tag="001">1001</controlfield>
178     <datafield tag="110" ind1=" " ind2=" ">
179         <subfield code="9">102</subfield>
180         <subfield code="a">My Corporation</subfield>
181     </datafield>
182 </record>|;
183
184     my $mij = '{"fields":[{"001":"1001"},{"110":{"subfields":[{"9":"102"},{"a":"My Corporation"}],"ind1":" ","ind2":" "}}],"leader":"                        "}';
185     my $marc = '00079     2200049   4500001000500000110002400005\1e1001\1e  \1f9102\1faMy Corporation\1e\1d';
186     my $json = {
187       authtypecode => "CORPO_NAME",
188       marcxml      => $marcxml
189     };
190
191     $t->post_ok("//$userid:$password@/api/v1/authorities")
192       ->status_is(403, 'Not enough permissions makes it return the right code');
193
194     # Add permissions
195     $patron->flags( 2 ** 14 )->store; # 14 => editauthorities userflag
196
197     # x-koha-override passed to make sure it goes through
198     $t->post_ok("//$userid:$password@/api/v1/authorities" => {'Content-Type' => 'application/marcxml+xml', 'x-authority-type' => 'CORPO_NAME', 'x-koha-override' => 'any' } => $marcxml)
199       ->status_is(201)
200       ->json_is(q{})
201       ->header_like(
202           Location => qr|^\/api\/v1\/authorities/\d*|,
203           'SWAGGER3.4.1'
204       );
205
206     # x-koha-override not passed to force block because duplicate
207     $t->post_ok("//$userid:$password@/api/v1/authorities" => {'Content-Type' => 'application/marc-in-json', 'x-authority-type' => 'CORPO_NAME' } => $mij)
208       ->status_is(409)
209       ->header_exists_not( 'Location', 'Location header is only set when the new resource is created' )
210       ->json_like( '/error' => qr/Duplicate record (\d*)/ )
211       ->json_is( '/error_code' => q{duplicate} );
212
213     $t->post_ok("//$userid:$password@/api/v1/authorities" => {'Content-Type' => 'application/marc-in-json', 'x-authority-type' => 'CORPO_NAME', 'x-koha-override' => 'duplicate' } => $mij)
214       ->status_is(201)
215       ->json_is(q{})
216       ->header_like(
217           Location => qr|^\/api\/v1\/authorities/\d*|,
218           'SWAGGER3.4.1'
219       );
220
221     $t->post_ok("//$userid:$password@/api/v1/authorities" => {'Content-Type' => 'application/marc', 'x-authority-type' => 'CORPO_NAME', 'x-koha-override' => 'duplicate' } => $marc)
222       ->status_is(201)
223       ->json_is(q{})
224       ->header_like(
225           Location => qr|^\/api\/v1\/authorities/\d*|,
226           'SWAGGER3.4.1'
227       );
228
229     $schema->storage->txn_rollback;
230 };
231
232 subtest 'put() tests' => sub {
233
234     plan tests => 14;
235
236     $schema->storage->txn_begin;
237
238     Koha::Authorities->delete;
239
240     my $record;
241     my $subfield_a;
242
243     my $patron = $builder->build_object(
244         {
245             class => 'Koha::Patrons',
246             value => { flags => 0 } # no permissions
247         }
248     );
249     my $password = 'thePassword123';
250     $patron->set_password( { password => $password, skip_validation => 1 } );
251     my $userid = $patron->userid;
252
253     my $authority = $builder->build_object({ 'class' => 'Koha::Authorities', value => {
254       marcxml => q|<?xml version="1.0" encoding="UTF-8"?>
255 <record xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/MARC21/slim" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd">
256     <controlfield tag="001">1001</controlfield>
257     <datafield tag="110" ind1=" " ind2=" ">
258         <subfield code="9">102</subfield>
259         <subfield code="a">My Corporation</subfield>
260     </datafield>
261 </record>|
262     } });
263
264     my $authid       = $authority->authid;
265     my $authtypecode = $authority->authtypecode;
266
267     my $marcxml = q|<?xml version="1.0" encoding="UTF-8"?>
268 <record xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.loc.gov/MARC21/slim" xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd">
269     <controlfield tag="001">1001</controlfield>
270     <datafield tag="110" ind1=" " ind2=" ">
271         <subfield code="9">102</subfield>
272         <subfield code="a">MARCXML</subfield>
273     </datafield>
274 </record>|;
275
276     my $mij = '{"fields":[{"001":"1001"},{"110":{"subfields":[{"9":"102"},{"a":"MIJ"}],"ind1":" ","ind2":" "}}],"leader":"                        "}';
277     my $marc = '00079     2200049   4500001000500000110002400005\1e1001\1e  \1f9102\1faUSMARCFormated\1e\1d';
278
279     $t->put_ok("//$userid:$password@/api/v1/authorities/$authid")
280       ->status_is(403, 'Not enough permissions makes it return the right code');
281
282     # Add permissions
283     $patron->flags( 2 ** 14 )->store; # 14 => editauthorities userflag
284
285     $t->put_ok("//$userid:$password@/api/v1/authorities/$authid" => {'Content-Type' => 'application/marcxml+xml', 'x-authority-type' => $authtypecode} => $marcxml)
286       ->status_is(200)
287       ->json_has('/id');
288
289     $authority = Koha::Authorities->find($authid);
290     $record = $authority->record;
291     $subfield_a = $record->subfield('110', 'a');
292
293     is($subfield_a, 'MARCXML');
294
295     $t->put_ok("//$userid:$password@/api/v1/authorities/$authid" => {'Content-Type' => 'application/marc-in-json', 'x-authority-type' => $authtypecode} => $mij)
296       ->status_is(200)
297       ->json_has('/id');
298
299     $authority = Koha::Authorities->find($authid);
300     $record = $authority->record;
301     $subfield_a = $record->subfield('110', 'a');
302
303     is($subfield_a, 'MIJ');
304
305     $t->put_ok("//$userid:$password@/api/v1/authorities/$authid" => {'Content-Type' => 'application/marc', 'x-authority-type' => $authtypecode} => $marc)
306       ->status_is(200)
307       ->json_has('/id');
308
309     $authority = Koha::Authorities->find($authid);
310     $record = $authority->record;
311     $subfield_a = $record->subfield('110', 'a');
312
313     is($subfield_a, 'USMARCFormated');
314
315     $schema->storage->txn_rollback;
316 };