]> git.koha-community.org Git - koha.git/commit
Bug 28882: permission UI allows selection of superlibrarian permission
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 19 Aug 2021 13:07:50 +0000 (15:07 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 10 Sep 2021 12:04:48 +0000 (08:04 -0400)
commit0e40d8d3d185cf56d23d94a065118da7fd0c9d81
treedf3a155fc368915533b7c684f25d342f2a6f89df
parent315a0fd149a541ca7880385d9a2cf34ccc4591e2
Bug 28882: permission UI allows selection of superlibrarian permission

With bug 20100 and 22150 we allow to select all the permissions but the
superlibrarian permission, to ease the selection. And we also forbid a
non-superlibrarian user to add superlibrarian permission.

However there is something wrong in the JS code and it's possible to add
the superlibrarian permission. The user is getting an ugly 500 and so
the permission change is not done, but the UI checks must be fixed.

To recreate:
Login with a non-superlibrarian user
Edit permission
Clear all
=> You can select the "superlibrarian" permission

Test plan:
Login with a non-superlibrarian user
Try to set the superlibrarian permissions to a user
=> not possible
Try the select all/clear all
=> still cannot set the superlibrarian permission

Work to be done:
Login with a non-superlibrarian user
Edit permissions for a superlibrarian user
=> You can remove it, then cannot add it back
Should we allow removal of superlibrarian permission by
non-superlibrarian user?

Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt