]> git.koha-community.org Git - koha.git/commit
Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt
authorMarc Véron <veron@veron.ch>
Sat, 20 Sep 2014 19:38:02 +0000 (21:38 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 14 Oct 2014 14:05:06 +0000 (11:05 -0300)
commit285795d76923770937970a702c13727be6e31c1a
tree6330dc42f1b47239e323ea16a4917f3ca242d02c
parentd7f97e3b8aca479659cb492d4bd883055e36e5fd
Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt

If an item has no star ratings you get an error message in opac-error.log:
Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467.

To test:
In OPAC, search for a bilio that has no star ratings.
Check opac-error.log for message as above
Apply patch
Repeat search
Check opac-error.log again, there should be no more warnings

(Fixed mistake with brackets, see comment #2)

Signed-off-by: Magnus Enger <digitalutvikling@gmail.com>
Works as advertized. Looks like you have to be logged in to trigger
the error.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works as advertised, passses xt/author/valid-templates.t
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt