Bug 32656: Script delete_records_via_leader.pl no longer deletes items
authorKyle Hall <kyle@bywatersolutions.com>
Tue, 17 Jan 2023 17:18:00 +0000 (12:18 -0500)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Fri, 17 Feb 2023 12:08:29 +0000 (13:08 +0100)
commit32469eb7e0660e469b2ef38d5d1126dff701ae47
tree6e25007417a11e1cde7fdc52035ce6e3520ead71
parent98a970b9fb63059f8acb981b69254738c706b709
Bug 32656: Script delete_records_via_leader.pl no longer deletes items

Bug 29788 inadvertantly replaced a call to safe_delete() with safe_to_delete()
such that any time the script should delete an item it only checks to see if
the item is delectable, after which deletion of the record fails because the
items were not deleted.

Test Plan:
1) Mark a record with items to be deleted via the record leader
2) Run delete_records_via_leader.pl -i -b -v
3) Note the script says it is deleting the items but then the record
   deletion fails. Note the items remain in the items table of the
   database.
4) Apply this patch
5) Repeat step 2
6) This time the items and record should be deleted!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 790f00781ab6c98017529ebf226d52c36c36cd68)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
(cherry picked from commit 03a9b139587aea26a9abde4f45a7c4f99532353c)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 0f430ce9a8c3b98be260e48a3d66f5bbb40012ab)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
misc/cronjobs/delete_records_via_leader.pl