Bug 33447: Make *->pickup_locations methods throw an exception on missing parameter
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 20 Apr 2023 18:04:29 +0000 (15:04 -0300)
committerJacob O'Mara <jacobomara901@gmail.com>
Tue, 9 May 2023 20:49:40 +0000 (21:49 +0100)
commit371db0c3c03e3c2c333fccc75b006f2449cfc457
treeb5ede7918cbae88c0761a772fe265d0cdca03e5d
parent4e51e04ce150896a6429ccf9af07d6460efb89e1
Bug 33447: Make *->pickup_locations methods throw an exception on missing parameter

This patch fixes the FIXME for making the methods throw an exception.

Tests are added, and POD is adapted as well.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/patrons* \
           t/db_dependent/api/v1/holds.t \
           t/db_dependent/Reserves* \
           t/db_dependent/Hold* \
           t/db_dependent/Koha/Hold* \
           t/db_dependent/Items*

=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 981eeff7ef1a014b848a52ee9e6e20de106048e3)
Koha/Biblio.pm
Koha/Biblios.pm
Koha/Item.pm
t/db_dependent/Koha/Biblio.t
t/db_dependent/Koha/Biblios.t
t/db_dependent/Koha/Item.t