]> git.koha-community.org Git - koha.git/commit
Bug 35072: Fix invalid usage of "&" in JavaScript intranet-tmpl script redirects
authorMichał Kula <148193449+mkibp@users.noreply.github.com>
Mon, 23 Oct 2023 13:51:40 +0000 (15:51 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 26 Oct 2023 06:55:51 +0000 (20:55 -1000)
commit37eb3092c19361c88ab0442219cd523832b24d2f
tree0576cd431085f2d1fa73a4c3ec4726c62ea987ae
parent82d4eff906cf0b88b001cfe2f43f15d8e63f6ca6
Bug 35072: Fix invalid usage of "&amp;" in JavaScript intranet-tmpl script redirects

These escapes were invalid in these places, as HTML entity escapes
are meant to be used only inside of HTML elements/attributes, not
inside of JavaScript code.

These URLs would be sent out by the browser as-is, and that'd usually
work on the default install only coincidentally. Unfortunately, on some
setups (such as when using reverse proxies), this would break, and the
URL after "&amp;" would have been truncated.

This small patch adjusts the URLs in templates to not use wrong escapes,
and makes them consistent with how URLs are formatted for JavaScript
redirects in most of the templates already.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit da9f74e56aa3fcaab2a53f0211113d7600263806)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/js/cart.js
koha-tmpl/intranet-tmpl/prog/js/catalog.js
koha-tmpl/intranet-tmpl/prog/js/holds.js
koha-tmpl/intranet-tmpl/prog/js/members-menu.js
koha-tmpl/intranet-tmpl/prog/js/pages/results.js