Bug 33528: Use template wrapper for tabs: Patron details page
authorOwen Leonard <oleonard@myacpl.org>
Tue, 9 May 2023 17:48:53 +0000 (17:48 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 17 Jul 2023 11:04:17 +0000 (12:04 +0100)
commit3df4119807702bbc8efab057e653bb21fb95e0cf
treeecbb78b1270290af5bc7e9d4f3799cbd1fd14da1
parentbb1167975a57755b745537b19f137a75ccfa543a
Bug 33528: Use template wrapper for tabs: Patron details page

This patch updates the checkout and patron details templates so
that they use the new WRAPPER directive to build tabbed navigation.

The markup for the tab navigation and tab panels is moved into its own
include file since the templates were duplicating essentially the same
code.

To fully test you should have patrons with checkouts, fines, holds,
recalls, and article requests.

Apply the patch and go to the checkout page in the staff interface. With
each tab, test as much functionality as you can within that tab.

- Checkouts
- Holds
- Recalls (with UseRecalls enabled)
- Claims (with a LOST value defined in ClaimReturnedLostValue)
- Restrictions
- Article Requests (with ArticleRequests preference enabled)
- Clubs (with at least one club defined)
- Relatives' checkouts (patron must have a guarantee linked to their
  account).

Perform the same tests on the patron details page. Note that the
"Charges" tab is shown on the patron details page but not the checkout
page. This is not a change made by this patch.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 263196d194e06787b6c0d51ac603f0956d1fff6f)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
13 files changed:
koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc
koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc
koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc
koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc
koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
koha-tmpl/intranet-tmpl/prog/en/includes/relatives-issues-table.inc
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
koha-tmpl/intranet-tmpl/prog/js/pages/circulation.js