Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to block
authorNick Clemens <nick@bywatersolutions.com>
Fri, 8 Apr 2022 18:52:09 +0000 (18:52 +0000)
committerJacob O'Mara <jacob.omara@ptfs-europe.com>
Wed, 18 Jan 2023 16:58:53 +0000 (16:58 +0000)
commit3f8a87c2489fb61db2493ff0800b8c1b12be472f
tree4266b71f5affc3f01594b58ed280f4916cab6059
parent8d0443f44a1d22afb3ba5fb70a417727029a5713
Bug 22042: Block all return actions when BlockReturnOfWithdrawn items is set to block

Currently this syspref only bokcs the literal 'return' from a patron, i.e. the checkin

It still processes transfers, refunds lost items, updates NotForLoan status etc.

We should block all of these things

To test:
1 - Set BlockReturnOfWithdrawn to block
2 - Set an item as lost and withdrawn
3 - Check it in
4 - Item is found
5 - Apply patch
6 - Repeat 1-3
7 - Checkin is blocked, item still lost

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit e19aa35f3916313bc29215b3fc8fdb2106d82179)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
C4/Circulation.pm
t/db_dependent/Circulation.t