Bug 23389: Add 'All' option to report dropdowns
authorNick Clemens <nick@bywatersolutions.com>
Tue, 30 Jul 2019 15:20:27 +0000 (15:20 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 16 Dec 2019 21:24:13 +0000 (21:24 +0000)
commit418259f4d39420856ceb9f5b94b9cb90733f3382
tree5a7804830a997a1c8a1daaf9a9e5d29cec45ac07
parent180fb25b63731db4aa1a45e59bda1c3691034b86
Bug 23389: Add 'All' option to report dropdowns

This patch optionally adds an 'all' option to report dropdowns

Note you will need to use 'LIKE' instead of '=' to allow 'All' to work

To test:
 1 - Write a report:
     SELECT branchname FROM branches WHERE branchcode LIKE <<Branch|branches>>
 2 - Run it
 3 - Select a branch
 4 - You get one branch info
 5 - Note you cannot select all
 6 - Apply patch
 7 - Run report
 8 - No change
 9 - Update report like:
     SELECT branchname FROM branches WHERE branchcode LIKE <<Branch|branches:all>>
10 - Run report
11 - Select 'All'
12 - You get all branches
13 - Select one branch
14 - You get one branch
15 - Test with other authorised categories (itemtypes, YES_NO, etc.)
16 - Confirm it works as expected
17 - Prove -v t/db_dependent/Reports/Guided.t

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 7c97f5263d474adc11688b9b7773c5b8705d10d3)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Reports/Guided.pm
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
reports/guided_reports.pl
t/db_dependent/Reports/Guided.t