]> git.koha-community.org Git - koha.git/commit
Bug 21270: "Not finding what you're looking for" displaying uselessly
authorBlou <philippe.blouin@inlibro.com>
Fri, 24 Aug 2018 15:46:54 +0000 (11:46 -0400)
committerJoy Nelson <joy@bywatersolutions.com>
Tue, 31 Dec 2019 17:32:38 +0000 (17:32 +0000)
commit489cfb4b19b72dc1b156b0a4fa38add79ee3f05b
tree32b19ec3a2f843d0de4c6d7ce22b28c444300728
parentdc0952200fe22693624722f3b7db15f9022527c1
Bug 21270: "Not finding what you're looking for" displaying uselessly

When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled.

Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user.

Just taunting them...

TEST:
0) Set IllModule to true, AnonSuggestions to false.
1) Without login, just to an OPAC search.  At the bottom will be a nice string laughing at your failed search
2) Apply the patch.
3) Problem at 1) is fixed.
4) Login to validate that ILL link now appear.
5) Modify combination of IllModule and AnonSuggestions to validate links appearing.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt