]> git.koha-community.org Git - koha.git/commit
Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv...
authorLari Taskula <lari.taskula@hypernova.fi>
Tue, 12 Nov 2019 12:18:27 +0000 (12:18 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Sat, 18 Jan 2020 15:05:08 +0000 (15:05 +0000)
commit49eac22b1f977b439e5d3f8f313dee3164719b60
tree166f46e083f0a8dbdd8a7cfafe641013f6c92728
parentc74820c2273393825c73b90769424544579a1aae
Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv alone

Koha::Patron::Message->store has this

    my $userenv = C4::Context->userenv;
    $self->manager_id( $userenv ? $userenv->{number} : undef);

This breaks in REST API when userenv is not set.

Let API user pass manager_id without relying on C4::Context->userenv.

To test:
1. prove t/db_dependent/Koha/Patron/Messages.t
2. Observe success

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Koha/Patron/Message.pm