]> git.koha-community.org Git - koha.git/commit
Bug 29133: Correct select2 strings
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 29 Sep 2021 09:05:04 +0000 (11:05 +0200)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 8 Oct 2021 14:19:52 +0000 (10:19 -0400)
commit500725826f8e21db79b823c5e5f97618bb3e9fe2
tree44c66c2b184144944bde25b65a9a082f908f3f6c
parent173f3e950f192da5c03c58cbf4e7525e3227d567
Bug 29133: Correct select2 strings

We are using 'max'/'min' when the arguments are 'maximum'/'minimum'.
Also using %n, %d when only %s is working in .format()

Have a look at https://github.com/select2/select2/blob/45f2b83ceed5231afa7b3d5b12b58ad335edd82e/src/js/select2/i18n/en.js
It's Select2 v.4.0.13, the one we are using. We should match what's
there.

Test plan:
Bug 29002 is using minimumInputLength, you can see the difference when
selecting a patron:
 "Please enter %s or more characters"
vs
 "Please enter 3 or more characters"

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Bug 29133: (follow-up) Fix for argument mismatch

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
JK: fix typo in commit message
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/js/select2.js