]> git.koha-community.org Git - koha.git/commit
Bug 35108: Hide empty fields on ILL manage request page
authorPedro Amorim <pedro.amorim@ptfs-europe.com>
Thu, 19 Oct 2023 14:13:48 +0000 (14:13 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 19 Apr 2024 16:06:40 +0000 (18:06 +0200)
commit58b89df4355dcbd1d32162380b67d40720732d33
tree54a399aa9c930cc818bf18687d84540ba39cffba
parent65e1284ee2550a92bd08f6caec3a941bd35dba6a
Bug 35108: Hide empty fields on ILL manage request page

Optionally empty fields are: orderid, biblio_id, batch,
type, type_disclaimer_value, type_disclaimer_date, cost,
price_paid, notesstaff, notesopac.

Test plan, k-t-d:
1) Install FreeForm and BLDSS backends, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh)
2) Create a new FreeForm request, visit:
/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm
5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'.
6) Notice how there is a lot of unnecessary empty field entries
7) Apply patch, restart plack (koha-plack --restart kohadev)
8) Refresh the page, notice all the empty fields entries are no longer displayed

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt