]> git.koha-community.org Git - koha.git/commit
Bug 26090: Fix "item types" report
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 30 Jul 2020 12:16:09 +0000 (14:16 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 3 Sep 2020 14:32:13 +0000 (14:32 +0000)
commit69f16f7469c7cbbf571560d6f9389ef2dd170aa7
tree9d089226c2a229e430dae4c9822573d72a5e2a05
parent2b6b7cb265acc77f8925eec9a9f315f249a85348
Bug 26090: Fix "item types" report

This report was broken with SQL strict mode, but also without.

DBD::mysql::st execute failed: 'koha_kohadev.itemtypes.itemtype' isn't
in GROUP BY [for Statement "

and, if no library was selected:

DBD::mysql::st execute failed: Unknown column 'biblioitems.itemtype' in
'field list' [for Statement "

This patch does the minimum to make it usable, but it would need more
love.

Test plan:
To test you will need to try the 4 combinaisons:
 item-level_itypes = item or biblio
 With or without a library selected in the dropdown list

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 5bca73080f89bb2f4ca83ce6ceb9fa8e3c4a7d92)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
reports/itemtypes.plugin