Bug 29554: Do not hide display of itemtypes on neworderempty
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 22 Nov 2021 13:00:57 +0000 (13:00 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Fri, 16 Dec 2022 08:18:49 +0000 (09:18 +0100)
commit6d374b99c4daafe8df02f59a6d61a5a59ff81595
treef3b68c5f56e8bdebcfa87e2069086d292a405574
parentad7bcf789c330122348cea2cca727635982458bf
Bug 29554: Do not hide display of itemtypes on neworderempty

Hiding the list may lead to biblioitems.itemtype being NULL.
We do not want that, since 942$c is mandatory.

Test plan:
Create basket and set 'create items when' to receiving or
cataloging.
Create order from new empty record.
Check biblioitems.itemtype of created biblio.
Without this patch, it would have been NULL like this:
    select biblionumber,title from biblio;
    |            7 | Test 3                |
    select biblionumber,itemtype from biblioitems;
    |            7 | NULL     |

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2e650fdd0cb48c8120b66a4c5c6318f674d2801b)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit eb1083beb262ca390ad3789c90cbb3fba37e9431)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
acqui/neworderempty.pl