]> git.koha-community.org Git - koha.git/commit
Bug 29464: Make GET /acquisitions/orders honour sorting
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 10 Dec 2021 13:17:45 +0000 (10:17 -0300)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 4 Feb 2022 19:21:35 +0000 (14:21 -0500)
commit7341637d93074cb9fe9659c6c1a5d208a980d126
tree3073c243a8a09d3026988df6656e3b9d460b043c
parentf33a39b69775ec1989f47b58a3cd610604a5527e
Bug 29464: Make GET /acquisitions/orders honour sorting

When bug 20212 was pushed, we lost (didn't dig enough to find out how)
the sorting feature for this route.

This is mainly because biblio+biblioitems filtering prevents the route
to use plain $c->objects->search, so it has baked a custom version of
it. In this case, it missed the call to the dbic_merge_sorting helper,
that takes care of reading the query parameters and inject the sorting
attributes to the resultset.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_orders.t
=> FAIL: Tests fail, sorting doesn't actually work
3. Apply this patch
4. Repeat 2
=> SUCCESS: Sorting works!
5. Test sorting the pending orders on parcel.tt
6. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/REST/V1/Acquisitions/Orders.pm