]> git.koha-community.org Git - koha.git/commit
Bug 22168: Improve styling of new chart settings for reports
authorOwen Leonard <oleonard@myacpl.org>
Fri, 18 Jan 2019 17:10:40 +0000 (17:10 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 28 Jan 2019 16:05:37 +0000 (16:05 +0000)
commit8e1efe8f10fd5b575b2ceea3b33d1ed9dd91bd96
tree8a270bb959495a3fe670ea8c46202d225dc1217c
parent83876957b451445b8d07376467db06952ab33f3b
Bug 22168: Improve styling of new chart settings for reports

This patch updates a number of aspects of the reports chart creation
interface: Chart creation form is now shown in a modal window, and a
separate link has been added to show or hide the chart itself.

Also changed: Minor markup and JavaScript cleanup.

To test, apply the patch and go to Reports -> Saved reports.

- Run a report which returns more than one column.
- On the report results page, click the "Create chart" button. The chart
  settings form should appear in a modal window.
- Confirm that the form controls work correctly: Each label should give
  focus to the correct input. Changing the chart type should show or
  hide the appropriate form fields.
- Click the "Draw" button. The modal should disappear and the chart
  should be shown.
- Above the chart should be a "Hide chart" link which works to hide (and
  then show) the chart.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/css/reports.css
koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt