Bug 24242: Display funds that the logged in user can access - suggestions
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 15 Dec 2019 11:32:34 +0000 (12:32 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 13 Jan 2020 22:16:35 +0000 (22:16 +0000)
commit8f256790fea12ed50ca9dff275edbcb8b78a19e8
tree438814ac03d527e46adeed921a376fb884b5b513
parent4a059f220cdddec4f992101d38a8264714b701dd
Bug 24242: Display funds that the logged in user can access - suggestions

The design of this script is pretty bad and any modifications is a
challenge.
Here we are trying to display to display the funds available for the
logged in user. I did not understand previous code, as we are doing a
limit using CanUserUseBudget, I do not think it makes sense to retrieve
funds for a given library.
Also, I am wondering if the dropdown list in the filters has ever been
populated: budgetid_loop in the template *never* appeared in the history
of suggestion.pl (??)

Test plan:
Search for suggestions
Add/edit suggestions
=> The funds in the dropdown list should be the ones the logged in user
can use.

Signed-off-by: hc <hc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit de309a26746523de2e39e285727d691b0b10392c)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
suggestion/suggestion.pl