]> git.koha-community.org Git - koha.git/commit
Bug 29808: Do not receive transfer for checked out items
authorNick Clemens <nick@bywatersolutions.com>
Thu, 6 Jan 2022 12:38:05 +0000 (12:38 +0000)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 4 Feb 2022 19:01:39 +0000 (14:01 -0500)
commit92a15ba56d21bf01cc0b65620465f86fe522e3d5
treef238c4e2fcf74823e7f469ee48a4610faf4ad125
parenta704096cd5a8e7d2f030d3d90673328cdba3261b
Bug 29808: Do not receive transfer for checked out items

This patch adds a check to StockRotationItem->advance to check if an
item is checked out from the destination branch. If so, we do not receive the transfer

To test:
 1 - Enable StockRotation system preference
 2 - Browse to Tools->Stock rotation->New Rota and create a new rota, set as cyclical
 3 - Manage->stages and add two stages, each with 0 day duration
 4 - Manage->items - add an item
 5 - Checkout the item from the first branch of rotation
 6 - Tools->Stock rotation->Manage->items->move to next stage
 7 - Error:
    [Transfer item is currently checked out] at /usr/share/perl5/Exception/Class/Base.pm line 88
 8 - Check in the item at first branch
 9 - Checkout the item from the second stage branch
10 - Apply patch
11 - Tools->Stock rotation->Manage->items->move to next stage
12 - No error!
13 - Check in item at second branch
14 - Checkout from first branch
15 - Tools->Stock rotation->Manage->items->move to next stage
16 - Still no error!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/StockRotationItem.pm