Bug 32205: Remove unnecessary syspref template params for failed OPAC auth
authorDavid Cook <dcook@prosentient.com.au>
Tue, 15 Nov 2022 01:25:42 +0000 (01:25 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Wed, 29 Mar 2023 12:53:56 +0000 (14:53 +0200)
commit9d22868518d2dc958cbc3a2792ee2231e7183de9
tree3e1eefe3aaaa502048e1a0ee58248f174067f6c4
parent1cf478c7c5735d7c24c02dfe8d2581cfb4ed1938
Bug 32205: Remove unnecessary syspref template params for failed OPAC auth

This patch removes some unnecessary syspref template params for
failed OPAC auth. The templates handle these syspref using the
Koha.Preference() TT plugin function, so they're completely redundant
and just make checkauth() longer than it needs to be.

Test plan:
1) Apply patch
2) Enable OpacCloud, OpacBrowser, and OpacTopissue sysprefs
3) koha-plack --restart kohadev
4) Log out of Koha if you're logged in
5) Go to http://localhost:8080/cgi-bin/koha/opac-user.pl
6) Note that you can see the Cart as well as links for the following:
Browse by hierarchy, Authority search, Tag cloud, Subject cloud,
Most popular

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 60e7c991650c42b0533ec9d2983e6920e32324ac)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
(cherry picked from commit ee4ed64ff00bb1eade9dfbde68e94902c38c98ff)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 160ee38bfbc4b23867fc297caa15c2e23c935796)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
C4/Auth.pm