]> git.koha-community.org Git - koha.git/commit
Bug 11060: (Bootstrap theme) fix incorrect rendering for right to left languages
authorOwen Leonard <oleonard@myacpl.org>
Mon, 21 Oct 2013 00:52:06 +0000 (17:52 -0700)
committerGalen Charlton <gmc@esilibrary.com>
Mon, 21 Oct 2013 18:08:08 +0000 (18:08 +0000)
commit9d7d3085ecfa9d989dc039a895e83a69b00f42a9
tree25d6bcd8fe57b8418142d2e8cdba3784319688d2
parent58d469ed4d6891cddf6a5ef35d21caa553dfb8ae
Bug 11060: (Bootstrap theme) fix incorrect rendering for right to left languages

The right-to-left CSS copied over from the prog theme does is not
relevant to the redesigned templates. This patch updates the OPAC's
right-to-left CSS and adds a couple of other right-to-left CSS files to
override the default Bootstrap and jQueryUI CSS.

To my eye this looks correct, but I don't speak Arabic.

To test you must have a set of right-to-left templates, like
ar-Arab, installed for the Bootstrap theme. At this time it is necessary
to download the po file to your misc/translator/po directory. Again
using ar-Arab as an example:

http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po

Install the translation.

Open the OPAC, switch to that right-to-left language, and reload to
refresh the changed CSS. Confirm that it looks like right-to-left is
working.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
As far as I can tell it looks very well.
No koha-qa errors

1) Downloaded arabic bootstrap PO
2) Installed ar-Arab language, enabled on OPAC
3) Tested as anonymous user and logged in one, all pages look
well: cart, advanced search, user tabs.

I sent an email to Karam Qubsi asking his opinion.
But for me it's ok

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I was testing this at the same time as Bernardo, so I will Pass QA on
it, instead of signing it off

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
koha-tmpl/opac-tmpl/bootstrap/css/right-to-left.css
koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
koha-tmpl/opac-tmpl/bootstrap/less/right-to-left.less [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/css/bootstrap-rtl.css [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/lib/bootstrap/css/bootstrap-rtl.min.css [new file with mode: 0644]
koha-tmpl/opac-tmpl/bootstrap/lib/jquery/jquery-ui-rtl.css [new file with mode: 0644]