Bug 27333: Throw the right exceptions
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 4 Jan 2021 14:10:12 +0000 (11:10 -0300)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Mon, 8 Feb 2021 23:19:41 +0000 (00:19 +0100)
commita04e696df9dffe946cfbe2cc2b9967ef2174c8de
tree6b1a8be2093289b392ad18e5cc064805f94d8d6a
parent5d67f204e6992cebf296329d7beb532315487c27
Bug 27333: Throw the right exceptions

If parameters are missing, we need to throw
Koha::Exceptions::MissingParameter exceptions.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Club/Hold.t
=> FAIL: Tests fail because the method doesn't throw the right
exceptions
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit c5f3fdcc15bc5d1a013321944c90ce49f5c58e6c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 8bbc4514b7dc5757758c8a8e235b563d3fadd2b0)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit 7a611d3ba3eeb7ae972ce9d16eac0e0190fb15b3)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Koha/Club/Hold.pm