Bug 34130: Make requested_date nullable in api definition
authorPedro Amorim <pedro.amorim@ptfs-europe.com>
Tue, 27 Jun 2023 13:23:08 +0000 (13:23 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Thu, 29 Jun 2023 14:11:11 +0000 (11:11 -0300)
commita8633a58129bc2bb6b26986973501aa6649f2c78
treeb532013e805446e80ab521b79419cacece3ef474
parent23b328d6af61bd9ab402c230097748337c8f5257
Bug 34130: Make requested_date nullable in api definition

This patch allows the requested_date for an ILL request to be NULL to accomodate
older data

To test:
1 - Install the Koha 2 Koha ILL plugin:
    https://gitlab.com/koha-community/plugins/koha-plugin-ill-koha
2 - Enable the ILL  system preference
3 - Force an ILL request with minimal data from backend:
    INSERT INTO illrequests (borrowernumber,biblio_id,branchcode,backend,status) VALUES (5,3,'CPL','Koha','placed');
4 - View the ILL table
5 - Error:
    {"message":"Expected string - got null.","path":"\/body\/0\/requested_date"}
6 - Apply patch
7 - Table loads successfully

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
api/v1/swagger/definitions/ill_request.yaml