]> git.koha-community.org Git - koha.git/commit
Bug 29484: Make ListSets return noSetHierarchy when no sets defined
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 15 Nov 2021 12:52:15 +0000 (09:52 -0300)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 17 Dec 2021 13:35:19 +0000 (08:35 -0500)
commitabe9abf47083d26300a4e09100ba362e6facf6dc
tree85e810c90cbdcb00544d9f2fde910a8b47aa4f51
parente32e9d49c5dfe2ffe51057878370b9e1899e26e1
Bug 29484: Make ListSets return noSetHierarchy when no sets defined

This simple patch makes our OAI-PMH server return the appropriate error
code when no sets are defined.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ t/db_dependent/OAI/Server.t
=> FAIL: Tests fail. Boo!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! YAY!
5. Sign off :-D

Bonus: you can check with the tool mentioned on the bug report, that
the error is gone. No sets need to be defined.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
JD amended patch
-    ) unless scalar @{$sets} > 0;
+    ) unless @$sets;

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/OAI/Server/ListSets.pm