Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types
authorNick Clemens <nick@bywatersolutions.com>
Tue, 25 Aug 2020 10:35:02 +0000 (10:35 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 18 Sep 2020 09:49:29 +0000 (11:49 +0200)
commitb255ca7c6eec7be3027e6ade00d8477102062281
treecec67e2335d44fcc44daabf691f440f6b3d3211e
parent01b65975988e9ec1830499460b078ed1f108656f
Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types

MapItemsToHoldRequests has three sections: Local holds, item level holds, bib level holds

Only one of them was setting the reserve_id. This patch makes al three set it and adds tests

To test:
1 - Repeat test plan on bug
2 - sudo koha-mysql kohadev
    SELECT * FROM hold_fill_targets
3 - Ensure reserve_id is set at appropriate times
4 - prove -v  t/db_dependent/HoldsQueue.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Bug 18958: (QA follow-up) Fix number of tests

In HoldsQueue.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/HoldsQueue.pm
t/db_dependent/HoldsQueue.t