]> git.koha-community.org Git - koha.git/commit
Bug 17537: Fix valid-templates.t for some include files
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 2 Nov 2016 10:50:54 +0000 (10:50 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 4 Nov 2016 11:03:48 +0000 (11:03 +0000)
commitb286868ec99341102dd78eaffea832a8d6b635ab
tree85f4e51ca1a2446f1c48133ef94613be2129e0bc
parent674d3875c81af122eb7f925845fe73cc4d817db4
Bug 17537: Fix valid-templates.t for some include files

3 include files do not pass the template validation tests:
 - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc
 - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
 - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc

This is because they process a block which has not been declared before.
As they are include files, they cannot stand on their own.
We could have added them to the exclude file list of xt/author/valid-templates.t
but I think it's better to keep them into the validation loop.

Test plan:
  prove xt/author/valid-templates.t
should return green
And the library dropdown list should be correctly populated on the pages these files are included
(opac-topissues for instance)

Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc
koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc