Bug 32520: Use DefaultPatronSearchFields in patron_autocomplete
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 23 Dec 2022 11:32:12 +0000 (11:32 +0000)
committerMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Tue, 31 Jan 2023 14:27:37 +0000 (14:27 +0000)
commitd0ba3669903f29d2cfa0adaa2981ed5a5970f9b1
tree5dc472b1a41c3b9e638415386afa60f8200d43d4
parent1f679bb7748a5c9e72a5988ca4b4cc90fb2f4d8d
Bug 32520: Use DefaultPatronSearchFields in patron_autocomplete

This patch updates js_includes.inc to set a new global js variable
`defaultPatronSearchFields` with the content of the corresponding system
preference.

We then update the patron_autocomplete function to use this new global
variable and iterate in the same way as
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc.

NOTE: This changes the behaviour of the autocomplete from always
searching using contains on surname or firstname or starts with on
cardnumber to searching using 'contains' on any of the fields listed in
the DefaultPatronSearchFields system preference of defaulting to
'firstname,middle_name,surname,othernames,cardnumber,userid'.

Test plan
1. Ensure autocomplete still works everywhere
2. Confirm the system preference fields are being used.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 6898f1f132b5a01eb4c406fa711b3d13324ef538)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js