]> git.koha-community.org Git - koha.git/commit
Bug 29807: Make Branches plugin handle empty pickup locations list
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 6 Jan 2022 11:53:30 +0000 (08:53 -0300)
committerKyle Hall <kyle@bywatersolutions.com>
Mon, 7 Feb 2022 11:38:08 +0000 (06:38 -0500)
commitd1ea769c7988e40425a7bf5c05cafb1c0e35344c
treef28e594bf7492e847f0721d85f8806e4e5cf46e0
parentd315010594701d2b54de8926ad1d12360f29405f
Bug 29807: Make Branches plugin handle empty pickup locations list

This patch makes the plugin handle empty Koha::Biblio->pickup_locations
and Koha::Item->pickup_locations correctly.

It does so by explicitly calling ->as_list. It also restores the logic
that was changed by 6cd1ffab4e491349c99769018a7df33dc8a8aabf so, now
that ->empty is handled correctly, it doesn't return ALL the pickup
locations when the item/biblio doesn't have valid pickup locations.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Template/Plugin/Branches.t
=> FAIL: Awful error
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/Template/Plugin/Branches.pm