]> git.koha-community.org Git - koha.git/commit
Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 6 Jan 2022 10:13:57 +0000 (07:13 -0300)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 4 Feb 2022 18:59:43 +0000 (13:59 -0500)
commitdb9bfb9450939e4335cb53a8068e11693e4b13d6
tree9e4fd399bae1128d6e375ecd250e3db11acf5899
parentea601ed692648b9a8f7db31c79b587b64ec1010c
Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding

This trivial patch acknowledges the fact bug 28871 is probably not going
to be pushed, and changes the method so  it, internally, uses
Koha::Item->pickup_locations and Koha::Biblio->pickup_locations in
scalar context.

This is probably the correct solution as the discussion on bug 28883
points towards the future removal of the use of wantarray altogether,
eventually.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> FAIL: It explodes as we see in production, with:
The method Koha::Libraries->branchcode is not covered by tests!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/Hold.pm