Bug 36420: Allow Basic authentication using `cardnumber`
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 27 Mar 2024 12:01:32 +0000 (12:01 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 23 May 2024 13:29:14 +0000 (15:29 +0200)
commitdd58ce2a036e9b762f3e5418b7b670532de5dd05
treebf4e98397909dc034c660752d39d9b6f8d90e873
parentfa768d5ed4a1b273d049679017c2ef0c4c7bdc20
Bug 36420: Allow Basic authentication using `cardnumber`

This patch makes the API Basic authentication work with cardnumbers.
The used `checkpw_internal` method already does the fallback check.

To test:
1. Apply the unit tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/auth_basic.t
=> FAIL: Tests explode! [1]
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

[1] This highlights an underlying bug! Instead of getting 403, etc we get a 500. This is because of the internal fallback mechanism allowing the cardnumber+password combination, but then the Koha::Patron->find... not finding :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 154a2ea9ad5b6e911a504b8798f5ffe6df1c2297)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/REST/V1/Auth.pm