Bug 29554: Do not hide display of itemtypes on neworderempty
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 22 Nov 2021 13:00:57 +0000 (13:00 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 5 Dec 2022 20:09:09 +0000 (20:09 +0000)
commiteb1083beb262ca390ad3789c90cbb3fba37e9431
tree475ee4ac8bf2c8b6e03b258a323a395aa85d05fb
parent73d3abd65db07ab74d0e61641f84682e425c33e1
Bug 29554: Do not hide display of itemtypes on neworderempty

Hiding the list may lead to biblioitems.itemtype being NULL.
We do not want that, since 942$c is mandatory.

Test plan:
Create basket and set 'create items when' to receiving or
cataloging.
Create order from new empty record.
Check biblioitems.itemtype of created biblio.
Without this patch, it would have been NULL like this:
    select biblionumber,title from biblio;
    |            7 | Test 3                |
    select biblionumber,itemtype from biblioitems;
    |            7 | NULL     |

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2e650fdd0cb48c8120b66a4c5c6318f674d2801b)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
acqui/neworderempty.pl