]> git.koha-community.org Git - koha.git/commit
Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 12 Feb 2020 14:49:17 +0000 (15:49 +0100)
committerJoy Nelson <joy@bywatersolutions.com>
Thu, 12 Mar 2020 23:50:40 +0000 (23:50 +0000)
commited641c85571df0461b4f0cbf5a6ba2b3363a0b5d
tree7858c1aad2ad97b71aaeaf6f8e39532886e569a1
parentb09ca43dec81209d08abf45d75e9e5dea9f4b907
Bug 24549: Do not set "last patron" cookie if showLastPatron is disabled

If the showLastPatron syspref is disabled, we should not store the 3
cookies we use for this feature.

Test plan:
0/ Do not apply this patch
1/ Turn off showLastPatron
2/ Search for a patron, click on a result
3/ Open the cookie list of your browser
=> You see 3 cookies named lastborrowercard, lastborrowername,
lastborrowernumber
4/ Remove them
5/ Apply the patch
6/ Reload the patron detail page
=> The 3 cookies are not created
7/ Turn the pref on
8/ Reload the patron detail page
=> The 3 cookies are created
9/ Eat one of them.

QA note: it's a bit dirty, we should do that JS side, but
staff-global.js is too widely used to make the change easy. Any other
suggestions welcomed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc