]> git.koha-community.org Git - koha.git/commit
Bug 26141: Remove duplicated code from search.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 5 Aug 2020 07:57:56 +0000 (09:57 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 13 Aug 2020 18:03:19 +0000 (18:03 +0000)
commitf132aa4b3071f3a551475ecbdfd3f4d2bec5cf14
treefb6fad75112d0c996c6df309cd0075c0105f7b71
parentc98a283d118bb936dc44db1b73cfeb8e45f89a22
Bug 26141: Remove duplicated code from search.pl

commit 417553a9e47bf31f4cb785162e3dced856a2ac2a
  Bug 12478: starting to add search to staff client

This commit added code related to the itemtypes to the advanced search, but this code already existed.

The weird bit is:
$template->param(advancedsearchesloop => \@advancedsearchesloop);
my $types = C4::Context->preference("AdvancedSearchTypes") || "itemtypes";
my $advancedsearchesloop = prepare_adv_search_types($types);
$template->param(advancedsearchesloop => $advancedsearchesloop);

We are passing twice advancedsearchesloop to the template.

Test plan (for QA):
Review the changes and confirm that we can safely remove this code

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit a51a4f117d13739687f7be47d56cae0352914901)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
catalogue/search.pl