]> git.koha-community.org Git - koha.git/log
koha.git
13 years agoBug 3203: ACCTDETAIL notices don't parse branches or borrowers tokens
Ian Walls [Sun, 27 Mar 2011 17:05:48 +0000 (13:05 -0400)]
Bug 3203: ACCTDETAIL notices don't parse branches or borrowers tokens

This patch enables the ACCTDETAIL notices (and any branch-specific derivatives) to use
<<branches.*>> and <<borrowers.*>> tokens

This patch also attempts to send the email from the branch email first, falling back to
KohaAdminEmailAddress if no branch email exists.

To test:

1. Enable AutoEmailOpacUser system preference
2. Add <<branches.*>> tokens to the ACCTDETAIL notice
3. Create a new patron, including:
   a. test email address in the field matching your AutoEmailPrimaryAddress syspref value
   b. username and password (required to send a notice)
   c. any other required fields to save the record
4. Check you inbox.  Notice should send instantly (no need to run process_message_queue.pl)

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5960 : Itemtype icons not showing correctly in staff search results
Chris Cormack [Mon, 28 Mar 2011 01:13:13 +0000 (21:13 -0400)]
Bug 5960 : Itemtype icons not showing correctly in staff search results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database version
Chris Cormack [Sun, 27 Mar 2011 20:55:51 +0000 (09:55 +1300)]
Bumping database version

13 years agoBug 4276: XSLT subject tracings only use subfield a
Jared Camins-Esakov [Wed, 16 Mar 2011 18:57:26 +0000 (14:57 -0400)]
Bug 4276: XSLT subject tracings only use subfield a

When XSLT is enabled, the subject tracings on the details view (both OPAC and
Intranet) previously only searched on the subfield 'a'. In addition, searches
failed when the tracing included parentheses, and the XSLT display did not
include subfields other than abcdvxyz, even for those 6xx tags that have other
subfields.

This patch adds a syspref: TraceSubjectSubdivisons. When
TraceSubjectSubdivisions is set to "Don't include" (default), the subject
tracings in the XSLT details view will only search on subfield 'a'. When
TraceSubjectSubdivisions is set to "Include", the subject tracings will search
on all subfields, not just subfield 'a'.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_3670' into kcmaster
Chris Cormack [Sun, 27 Mar 2011 08:19:24 +0000 (21:19 +1300)]
Merge remote branch 'kc/new/bug_3670' into kcmaster

Conflicts:
koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc

13 years agoBug 3670 Followup: fixes message preference form
Ian Walls [Thu, 24 Mar 2011 21:32:04 +0000 (17:32 -0400)]
Bug 3670 Followup: fixes message preference form

Changing the database value from "Item DUE" to "Item Due" broke the matching performed in the
messaging-preferences-form.inc file, resulting it the notice being labeled as "Unknown".

This patch changes both the matching, and the display, to "Item Due"

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_1962' into kcmaster
Chris Cormack [Sun, 27 Mar 2011 08:12:40 +0000 (21:12 +1300)]
Merge remote branch 'kc/new/enh/bug_1962' into kcmaster

Conflicts:
circ/returns.pl
installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql
installer/data/mysql/it-IT/necessari/sysprefs.sql
installer/data/mysql/pl-PL/mandatory/sysprefs.sql
installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql
installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql
installer/data/mysql/updatedatabase.pl
kohaversion.pl

13 years agoBug 1962: Add new syspref FineNotifyAtCheckin
Katrin Fischer [Fri, 25 Mar 2011 23:27:15 +0000 (19:27 -0400)]
Bug 1962: Add new syspref FineNotifyAtCheckin

This patch adds a new syspref FineNotifyAtCheckin.

With syspref ON there will be a message when checking in books from
a patron with outstanding fines.

With syspref OFF (default) no message will be shown.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5954: 490$a not used to create search link in XSLT
ruth@bywatersolutions.com [Fri, 25 Mar 2011 17:44:36 +0000 (13:44 -0400)]
Bug 5954: 490$a not used to create search link in XSLT

This bug corrects a minor XSLT bug that is causing 490$t (which is not defined) to create
search links when XSLT is enabled

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5940: Catalog and Cataloging Help Files for 3.4
Nicole C. Engard [Sat, 26 Mar 2011 00:10:08 +0000 (20:10 -0400)]
Bug 5940: Catalog and Cataloging Help Files for 3.4

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5940: Update Patron Help Files
Nicole C. Engard [Thu, 24 Mar 2011 20:27:03 +0000 (16:27 -0400)]
Bug 5940: Update Patron Help Files

This patch updates the help files in the patron area of Koha.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5930 : improving/modifying authority display on OPAC
Paul Poulain [Tue, 22 Mar 2011 14:58:01 +0000 (15:58 +0100)]
Bug 5930 : improving/modifying authority display on OPAC

- changing some terms that are unclear for a patron
- removing tag & subfields values & indicators
- removing UNIMARC coded fields
- changing the search page (removing options useless for a patron)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5926 : Fixing Hierarchies : taking any heading subfield
Henri-Damien LAURENT [Tue, 22 Mar 2011 14:34:53 +0000 (15:34 +0100)]
Bug 5926 : Fixing Hierarchies : taking any heading subfield

Conflicts solved:

C4/AuthoritiesMarc.pm

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5932 Remove itemdata sub from C4::Serials
Colin Campbell [Thu, 24 Mar 2011 09:44:29 +0000 (10:44 +0100)]
Bug 5932 Remove itemdata sub from C4::Serials

C4/Serials does not need to retrieve full item data
just to check if barcode is unique. Replace with
a lighter weight subroutine make code logic clearer and
cleaner

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5944 : (MT #3000) new cronjob script to delete old suggestions
Henri-Damien LAURENT [Thu, 24 Mar 2011 08:58:12 +0000 (09:58 +0100)]
Bug 5944 : (MT #3000) new cronjob script to delete old suggestions

This patch is a new script that delete suggestion that have be processed by librarians.
It take on argument, it's a number of days to keep suggestions. Suggestions olders than TODAY - $days will be deleted.
This script should be used to purge suggestions and clean the table in intranet.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_5880' into kcmaster
Chris Cormack [Thu, 24 Mar 2011 09:09:50 +0000 (22:09 +1300)]
Merge remote branch 'kc/new/enh/bug_5880' into kcmaster

13 years agoBug 5880: Correct misleading pod in new subroutine
Colin Campbell [Tue, 22 Mar 2011 15:24:06 +0000 (15:24 +0000)]
Bug 5880: Correct misleading pod in new subroutine

Also remove some whitespace noise from prev commit

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5919: Display MARC21 fields 583, 586, 530
Jared Camins-Esakov [Sun, 22 May 2011 21:32:07 +0000 (17:32 -0400)]
Bug 5919: Display MARC21 fields 583, 586, 530

This patch adds the MARC21 fields 583 (Action note), 586 (Awards note), and
530 (Additional physical form available note) to the OPAC details display in the
XSLT-controlled portion of the page. In order to allow libraries to hide these
notes if they do not want them added, the notes have been given CSS classes.

Depends on patch for Bug 3098.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 3098 follow-up: Clean up formatting
Jared Camins-Esakov [Sun, 22 May 2011 21:31:47 +0000 (17:31 -0400)]
Bug 3098 follow-up: Clean up formatting

This patch cleans up the formatting of the 856 display code in
MARC21slim2OPACDetail.xsl. Tabstops are correct, and the OPACURLOpenInNewWindow
syspref check is moved to control the use of a 'target="_blank"' attribute,
rather than having two blocks of almost-identical code.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5939: "Save and edit items" button broken
Jared Camins-Esakov [Mon, 23 May 2011 07:34:07 +0000 (03:34 -0400)]
Bug 5939: "Save and edit items" button broken

When modifying an existing biblio, the "Save and edit items" option in the
"Save" menu did not redirect to the edit items screen. Instead, it redirected to
the regular details screen.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5921: Add enumchron to the items detail page
Jared Camins-Esakov [Sun, 22 May 2011 21:36:43 +0000 (17:36 -0400)]
Bug 5921: Add enumchron to the items detail page

This patch adds the Serial enumeration/chronology field to the items display in
moredetail.pl.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5883 : Prevent re-encoding the items if they are already in UTF-8 in ModBiblio.
Frédérick Capovilla [Wed, 23 Mar 2011 14:19:57 +0000 (15:19 +0100)]
Bug 5883 : Prevent re-encoding the items if they are already in UTF-8 in ModBiblio.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database number
Chris Cormack [Wed, 23 Mar 2011 09:11:54 +0000 (22:11 +1300)]
Bumping database number

13 years agoBug 5641: Replace Favicon through staff client
Jared Camins-Esakov [Thu, 17 Mar 2011 23:58:54 +0000 (19:58 -0400)]
Bug 5641: Replace Favicon through staff client

This patch adds two sysprefs:
OpacFavicon
IntranetFavicon

The two sysprefs take full URLs to an alternate favicon.ico file for the OPAC
and Staff Client, respectively. Leaving them blank will use the favicon.ico file
that is included with Koha.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5902: additem.pl should default to set library
Jared Camins-Esakov [Fri, 18 Mar 2011 00:48:33 +0000 (20:48 -0400)]
Bug 5902: additem.pl should default to set library

This patch makes the additem screen default to selecting the currently set
library. If the library is unset, it will default to the first branch
alphabetically.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 3382: Add CSS classes to OPAC XSLT <img> tags
Jared Camins-Esakov [Fri, 18 Mar 2011 00:54:15 +0000 (20:54 -0400)]
Bug 3382: Add CSS classes to OPAC XSLT <img> tags

This patch adds materialtype, format, and natureofcontents CSS classes to the
<img> tags produced by the OPAC XSLT stylesheets for use with CSS and jQuery.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5913 : Remove broken link from authorities search results
Matthias Meusburger [Tue, 22 Mar 2011 10:49:50 +0000 (11:49 +0100)]
Bug 5913 : Remove broken link from authorities search results

BibLibre bug #2949

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5909 : SetUTF8Flag on any incoming data
Henri-Damien LAURENT [Tue, 22 Mar 2011 09:59:52 +0000 (10:59 +0100)]
Bug 5909 : SetUTF8Flag on any incoming data

This prompts NFC normalization on adding record
Therefore, any saved record will be NFC normalized

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5907 : MT 2538 : Using default authtypecode for authority display
Matthias Meusburger [Tue, 22 Mar 2011 09:13:12 +0000 (10:13 +0100)]
Bug 5907 : MT 2538 : Using default authtypecode for authority display

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5931 Paging and sorting saved reports table
Frédéric Demians [Tue, 22 Mar 2011 14:00:13 +0000 (09:00 -0500)]
Bug 5931 Paging and sorting saved reports table

On Reports > Saved reports page, a table shows all saved reports.
Table's rows are sorted by report IDs. When there are a lot reports,
this table is difficult to read.

This enhancement add to Saved report page a paging bar and sort options on
column names, like in the framework table.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFixed another template error thanks Jared
Chris Cormack [Tue, 22 Mar 2011 22:02:53 +0000 (11:02 +1300)]
Fixed another template error thanks Jared

13 years agoFixing template bug, once again unit tests rule!
Chris Cormack [Tue, 22 Mar 2011 21:51:54 +0000 (10:51 +1300)]
Fixing template bug, once again unit tests rule!

13 years agoBumping database version
Chris Cormack [Tue, 22 Mar 2011 21:42:38 +0000 (10:42 +1300)]
Bumping database version

13 years agoBug 5928 follow up patch catching missing sysprefs
Chris Cormack [Tue, 22 Mar 2011 21:41:25 +0000 (10:41 +1300)]
Bug 5928 follow up patch catching missing sysprefs

13 years agoBug 5928 follow up remove branchcode label
Nicole C. Engard [Fri, 18 Mar 2011 02:18:39 +0000 (22:18 -0400)]
Bug 5928 follow up remove branchcode label

Under Acq info it said 'Branchcode,' I've changed this to 'Library'
to match the style used in other places.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref
Srdjan Jankovic [Fri, 18 Mar 2011 02:18:17 +0000 (22:18 -0400)]
Bug 5928 :wr77152 : AllowPurchaseSuggestionBranchChoice sys pref

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFixing missing syspref
Chris Cormack [Tue, 22 Mar 2011 08:57:23 +0000 (21:57 +1300)]
Fixing missing syspref

13 years agoBumping database version
Chris Cormack [Tue, 22 Mar 2011 08:13:21 +0000 (21:13 +1300)]
Bumping database version

13 years agoBug 5755: DB Update, add new syspref
Frédéric Demians [Wed, 16 Mar 2011 19:17:55 +0000 (15:17 -0400)]
Bug 5755: DB Update, add new syspref

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5755: Syspref to control facets truncation
Frédéric Demians [Wed, 16 Mar 2011 19:21:17 +0000 (15:21 -0400)]
Bug 5755: Syspref to control facets truncation

On OPAC/staff result page facets are truncated to 20 characters. On some OPAC
layout, it's not enough. A new syspref FacetLabelTruncationLength defines the
length to cut facets if necessary.

This patch add the syspref to searching.pref and add it to syspref various
language default values loaded into DB during installation process. It's not
necessary to update DB since length is fixed to 20 (as before) when this
syspref isn't defined in systemprefercences table.

Rebased to last HEAD: 2011.03.18

[Documentation] FacetLabelTruncationLength syspref in Searching tab

[3.2] It doesn't apply.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database version
Chris Cormack [Tue, 22 Mar 2011 07:58:18 +0000 (20:58 +1300)]
Bumping database version

13 years ago3154 Preferences for building facets (install)
Marcel de Rooy [Wed, 16 Mar 2011 19:06:55 +0000 (15:06 -0400)]
3154 Preferences for building facets (install)

Adds prefs for facets in sql install files and updatedatabase script.

Rebased on March 17.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years ago3154 Preferences for building facets (functionality)
Marcel de Rooy [Wed, 16 Mar 2011 19:06:36 +0000 (15:06 -0400)]
3154 Preferences for building facets (functionality)

Based on patch from Fridolyn Somers with input of Frederic Demians.
Added new Searching preference maxRecordsForFacets.
This pref contains number of result records used in facet building.
Also added pref displayFacetCount (with thanks to Frederic).
Follow up patch takes care of install issues; functionality can already be tested with this patch only.

Updated on March 17 for changes in include files.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5390: OPAC loses library selection
Jared Camins-Esakov [Mon, 21 Mar 2011 21:36:20 +0000 (16:36 -0500)]
Bug 5390: OPAC loses library selection

This patch ensures that the OPAC library selection masthead will always default
to the branch that is currently being searched. This only applies to systems
with multiple branches and OpacAddMastheadLibraryPulldown turned on.

To test: do a search in the OPAC, limiting by branch. The search results will
still have that branch selected in the masthead dropdown.

This patch also fixes bug 5852 and bug 3778.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoRemove errant Makefile and pm_to_blib from repo
Jared Camins-Esakov [Mon, 21 Mar 2011 16:36:47 +0000 (12:36 -0400)]
Remove errant Makefile and pm_to_blib from repo

Makefile and pm_to_blib were added to the git repository by commit
ddbedbfc2f17bff016736afb5beae39a768a298a. Having those files in the repository
causes problems with updating to Master in dev-mode installs. This patch removes
those two files, since they shouldn't be tracked anyway.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5610: Add --since for setting messaging to default
Jared Camins-Esakov [Thu, 17 Mar 2011 01:02:30 +0000 (21:02 -0400)]
Bug 5610: Add --since for setting messaging to default

It is now possible to specify a command line argument --since so that the
borrowers-force-messaging-defaults script only changes patrons created starting
on a certain day. If the optional argument is not specified, the script applies
to all borrowers.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5610 Script to force borr transport defaults messaging
Frédéric Demians [Thu, 17 Mar 2011 01:02:09 +0000 (21:02 -0400)]
Bug 5610 Script to force borr transport defaults messaging

If the EnhancedMessagingPreferences syspref is enabled after borrowers
have been created in the DB, those borrowers won't have messaging
transport preferences default values as defined for their borrower
category, even no transport preferences at all. So you would have to
modify each borrower one by one if you would like to send them 'Hold
Filled' notice for example.

I propose this script to create transport preferences for all existing
borrowers and set them to default values defined for the category they
belong to.

[DOC] Should be documented somewhere.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5834: Holds link missing when 942$c is not for loan
Katrin Fischer [Sat, 19 Mar 2011 21:14:33 +0000 (17:14 -0400)]
Bug 5834: Holds link missing when 942$c is not for loan

Adds a check for item-level_itypes system preference. Note that this only
applies to the search results screens.

To test:
1) Set item-level_itypes to 'specific item'
2) Create record and set 942$c to an itype that is marked not for loan
3) Create item with itype not marked 'not for loan'
Current behaviour: Holds link is not shown, sys pref setting doesn't matter

After patch: Holds link is shown
- when item-level_itype is 'specific item'
- when item-level_itype is 'biblio record' and 942$c itype is for loan

Holds link is not shown
- when item-level_itype is 'biblio record' and 942$c is not for loan

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5065 Add ability to choose framework on import
Frédéric Demians [Wed, 16 Mar 2011 19:25:54 +0000 (15:25 -0400)]
Bug 5065 Add ability to choose framework on import

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5466 On new orders get currency from vendor
Colin Campbell [Fri, 18 Mar 2011 16:11:02 +0000 (17:11 +0100)]
Bug 5466 On new orders get currency from vendor

Previous patch for this bug was ignoring vendor currency on
new orders. In most cases should be the default

Changed variable name from cur to active_currency
Clarity is a virtue!

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5466 - Acquisitions - ability to set currency in order screens
Savitra Sirohi [Fri, 18 Mar 2011 16:11:01 +0000 (17:11 +0100)]
Bug 5466 - Acquisitions - ability to set currency in order screens

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4878 - Command-line tool for getting and setting sysprefs
Jesse Weaver [Fri, 18 Mar 2011 15:10:19 +0000 (16:10 +0100)]
Bug 4878 - Command-line tool for getting and setting sysprefs

New script misc/admin/koha-preferences - Allows getting and setting of
sysprefs one-at-a-time or in bulk. More info:

misc/admin/koha-preferences help

or:

misc/admin/koha-preferences manual

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdding 2 more developers to the history 137 now!
Chris Cormack [Mon, 21 Mar 2011 03:42:49 +0000 (16:42 +1300)]
Adding 2 more developers to the history 137 now!

13 years agoBug 5862 - Incompatibility in ajax.js with "localName" for Internet Explorer
Salvador Zaragoza Rubio [Fri, 18 Mar 2011 15:07:04 +0000 (11:07 -0400)]
Bug 5862 - Incompatibility in ajax.js with "localName" for Internet Explorer

It has been detected an incompatibility with Internet Explorer in the ajax.js
file that cause a javascript error for this browser that prevents proper
operation.
The error occurs because the "localName" is not supported by Internet Explorer
and returns "undefined".

Bug 5862 - Incompatibility in ajax.js with "localName" for Internet Explorer

Fix error on comma for IE

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5892 : opac-user: minor spelling/html changes
Paul Poulain [Fri, 18 Mar 2011 14:30:05 +0000 (15:30 +0100)]
Bug 5892 : opac-user: minor spelling/html changes

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5893: Removed duplicate entry in sysprefs.sql
Julian Maurice [Fri, 18 Mar 2011 13:02:12 +0000 (13:02 +0000)]
Bug 5893: Removed duplicate entry in sysprefs.sql

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5864: link biblio => serials subscription is wrong
Julian Maurice [Fri, 18 Mar 2011 10:15:08 +0000 (10:15 +0000)]
Bug 5864: link biblio => serials subscription is wrong

The GetSubscription function can be called with 3 parameters : title,
issn, biblionumber.
In biblio view (both opac & staff interface), the link to jump from the
biblio to the subscription(s) was done using title.

The result was that for a title like "Science", all subscriptions
containing "science" in the title were linked.
That's too much and that's false.

This commit fixes this problem by calling GetSubscription with
biblionumber only where applicable.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4330 : Adding some copyright BibLibre statements
Paul Poulain [Tue, 4 Jan 2011 20:51:24 +0000 (21:51 +0100)]
Bug 4330 : Adding some copyright BibLibre statements

13 years agoBug 4330 : Fixing copyright and removing unconditional warn chris c mail 2010-12...
Paul Poulain [Tue, 4 Jan 2011 20:28:10 +0000 (21:28 +0100)]
Bug 4330 : Fixing copyright and removing unconditional warn chris c mail 2010-12-16 on patches ML

13 years agoBug 4330 : fixing copyright mail from chris c 2010-12-16 on patches ML
Paul Poulain [Tue, 4 Jan 2011 20:26:38 +0000 (21:26 +0100)]
Bug 4330 : fixing copyright mail from chris c 2010-12-16 on patches ML

13 years agoBug 3735: Wrong search results for a few fields in ccl.properties
Marcel de Rooy [Thu, 17 Mar 2011 14:37:59 +0000 (10:37 -0400)]
Bug 3735: Wrong search results for a few fields in ccl.properties

This patch corrects a syntax error in the definition of bath attributes in
ccl.properties. In particular, it adds the search prefixes 'isbn', 'issn',
'name', and 'notes'. In order to make use of this patch, ccl.properties must be
updated.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years ago5622: Improve display of MARC21 773 field in XSLT detail view
Marcel de Rooy [Thu, 17 Mar 2011 14:22:43 +0000 (10:22 -0400)]
5622: Improve display of MARC21 773 field in XSLT detail view

Applies change to OPAC and staff detail view.
Chops punctuation. Adds 773g. Strips MARC org code from URL.
Utils code is used as basis for patches #5662 and #5663 too.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5890 Correct Mismatched operator in comparison
Colin Campbell [Thu, 17 Mar 2011 10:34:52 +0000 (10:34 +0000)]
Bug 5890 Correct Mismatched operator in comparison

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_5848' into kcmaster
Chris Cormack [Thu, 17 Mar 2011 21:46:01 +0000 (10:46 +1300)]
Merge remote branch 'kc/new/enh/bug_5848' into kcmaster

13 years agoBug 5848: Remove duplicated tabs in opac details for Unimarc
Julian Maurice [Thu, 17 Mar 2011 07:41:28 +0000 (07:41 +0000)]
Bug 5848: Remove duplicated tabs in opac details for Unimarc

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5879' into kcmaster
Chris Cormack [Thu, 17 Mar 2011 21:38:56 +0000 (10:38 +1300)]
Merge remote branch 'kc/new/bug_5879' into kcmaster

13 years agoMerge remote branch 'kc/new/bug_4218' into kcmaster
Chris Cormack [Thu, 17 Mar 2011 21:38:40 +0000 (10:38 +1300)]
Merge remote branch 'kc/new/bug_4218' into kcmaster

13 years agoFollow-up fix for Bug 4218 - Staff client detail page doesn't show hold status
Owen Leonard [Wed, 16 Mar 2011 15:40:41 +0000 (10:40 -0500)]
Follow-up fix for Bug 4218 - Staff client detail page doesn't show hold status

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5879 : Biblio.pm : fix isbd syspref and default location
Paul Poulain [Wed, 16 Mar 2011 11:06:37 +0000 (12:06 +0100)]
Bug 5879 : Biblio.pm : fix isbd syspref and default location

- the systempreference is isbd, not ISBD
- when preparing the ItemRecord (for acq or serials recieving), there was no default value calculated for location. Fixing that

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5889: Messages name in english for notifications on public interface.
Sophie Meynieux [Thu, 17 Mar 2011 10:46:26 +0000 (11:46 +0100)]
Bug 5889: Messages name in english for notifications on public interface.

Modification of template to allow multilanguage support. Alsa fixing columns
overflow.

BibLibre bug #5939

Tests: It works. Messages strings can now be extracted and placed in .po file
for translation.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5646: Translated sql files break messaging
Katrin Fischer [Tue, 15 Mar 2011 14:03:30 +0000 (15:03 +0100)]
Bug 5646: Translated sql files break messaging

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5882 : catalogue/moredetails (minor) changes
Paul Poulain [Wed, 16 Mar 2011 14:41:11 +0000 (10:41 -0400)]
Bug 5882 : catalogue/moredetails (minor) changes

MT3288 moredetail.tmpl Lost and Damaged first choice is empty

    First choice was the first value of the authorised value list
    This is not handy for users.
    Rather than showing the first value, inserting a new empty value for users to see what to do

Term "Total Renewals" misleading, change to "Current Renewals"

    In koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tmpl under History,
    there's a Total Renewals entry: seems to indicate a cumulative count of renewals on
    the item, which it is not, contrary to "Total Issues" just below.
    Moved the line up outside "history", and renamed it "Current Renewals".

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFollow up for bug 5880: Improved unit test
Julian Maurice [Thu, 17 Mar 2011 13:33:02 +0000 (14:33 +0100)]
Follow up for bug 5880: Improved unit test

The unit test Koha.t now skip tests of the two subroutines if the insert
query failed.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFollow up for bug 5880: Added unit tests for the two new subroutines
Julian Maurice [Thu, 17 Mar 2011 11:30:53 +0000 (12:30 +0100)]
Follow up for bug 5880: Added unit tests for the two new subroutines

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5880 : C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImage...
Paul Poulain [Wed, 16 Mar 2011 10:36:49 +0000 (11:36 +0100)]
Bug 5880 : C4/Koha.pm : adding two functions GetAutorisedValueByCode and GetKohaImageurlFromAuthorisedValues

just for convenience

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_5869' into kcmaster
Chris Cormack [Thu, 17 Mar 2011 01:37:00 +0000 (14:37 +1300)]
Merge remote branch 'kc/new/enh/bug_5869' into kcmaster

13 years agoBug 5861: items.stocknumber not saved correctly
Katrin Fischer [Wed, 16 Mar 2011 07:49:37 +0000 (08:49 +0100)]
Bug 5861: items.stocknumber not saved correctly

The field was missing in Items.pm.
It will still act strangely if you enter a stocknumber that
already exists in the database. (see Bug 5860)
Adding/editing items with stocknumbers you have not used before
should work as expected.

[F. Demians] Was able to reproduce the bug on an UNIMARC DB. The patch works.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFollow Up Bug 5869 Update Report Page Title
Nicole C. Engard [Tue, 15 Mar 2011 17:05:09 +0000 (13:05 -0400)]
Follow Up Bug 5869 Update Report Page Title

The title said Checkout Stats - updated to say Holds Stats

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFollow Up Bug 5869 Fix String Errors
Nicole C. Engard [Tue, 15 Mar 2011 17:01:24 +0000 (13:01 -0400)]
Follow Up Bug 5869 Fix String Errors

This patch fixes all occurences of 'reserves' to 'holds.' It also
added Holds to the menu include and updates capitalization and spacing.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5869 - Follow up patch, fixing copyring and s/reserves/holds/
Chris Cormack [Tue, 15 Mar 2011 17:01:06 +0000 (13:01 -0400)]
Bug 5869 - Follow up patch, fixing copyring and s/reserves/holds/

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5869 : Adding a reserve report
Paul Poulain [Tue, 15 Mar 2011 17:00:17 +0000 (13:00 -0400)]
Bug 5869 : Adding a reserve report

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5485: Add script to run Test::Perl::Critic
Colin Campbell [Tue, 15 Mar 2011 13:40:23 +0000 (14:40 +0100)]
Bug 5485: Add script to run Test::Perl::Critic

Tests are run if TEST_QA environment variable is set
and Test::Perl::Critic is installed
e.g.
TEST_QA=1 prove =l t/00-testcritic.t

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5816: XSLT doesn't display enhanced contents
Jared Camins-Esakov [Tue, 15 Mar 2011 07:26:24 +0000 (03:26 -0400)]
Bug 5816: XSLT doesn't display enhanced contents

This patch corrects and standardizes the display of enhanced contents (MARC 505
with ind2='0').

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5863: Add to Your Cart disappeared if login disabled on opac detail
Marcel de Rooy [Tue, 15 Mar 2011 05:45:14 +0000 (01:45 -0400)]
Bug 5863: Add to Your Cart disappeared if login disabled on opac detail

Resolving an error in ready function by additional conditionals.
Moving a line from ready to html just as in other view templates, correcting the order of menu options at the same time.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_3326' into kcmaster
Chris Cormack [Wed, 16 Mar 2011 20:22:46 +0000 (09:22 +1300)]
Merge remote branch 'kc/new/bug_3326' into kcmaster

13 years agoFollow up for Bug 3326: previous fix broke searches when
Jared Camins-Esakov [Wed, 16 Mar 2011 15:09:46 +0000 (15:09 +0000)]
Follow up for Bug 3326: previous fix broke searches when

This fix ensures that searches will still work when -x is not used when
reindexing Zebra.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Magnus Enger <magnus@bibkat.no>
Signed-off-by: Jane Wagner <jwagner@ptfs.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 3810: Ensure all calls to Mail::Sendmail handled consistently
Colin Campbell [Tue, 15 Mar 2011 11:03:21 +0000 (12:03 +0100)]
Bug 3810: Ensure all calls to Mail::Sendmail handled consistently

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 3595 (partial): Items seen at checkin are not filling holds well
ruth@bywatersolutions.com [Fri, 4 Mar 2011 19:04:43 +0000 (13:04 -0600)]
Bug 3595 (partial): Items seen at checkin are not filling holds well

In Liz's second comment on this bug, she points out that local-only
holds (and also no-holds) items are being used to fill the first hold
in the queue, no matter where located, transitting if necessary.  If
all the items on a biblio are set to no-holds types, this problem
would never arise, as no holds could be *placed*.  But if you have
one or more unlimitedor local-hold items, then holds are getting
filled by the first item to cross a scanner, no matter what.

This patch will check during C4::Reserves::CheckReserves to make sure
that the hold being handed back to AddReturn is actually fillable by
the item just scanned.  One caveat:  If CircControl is set to "the library
you are logged in at", this will cause items checked in at
other-than-their-home-library to fill local holds at the library where
scanned.  This is, however, an edge case!

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 3326: Work around Zebra's handling of &amp; entities
Jared Camins-Esakov [Tue, 15 Mar 2011 02:14:19 +0000 (22:14 -0400)]
Bug 3326: Work around Zebra's handling of &amp; entities

When using XSLT mode, the OPAC results display will show "&amp;" instead of "&"
when Zebra is indexing in XML mode. This patch works around this by replacing
"&amp;" with "&" and then extends the previous fix to apply to all occurrences
of "& " instead of just the first.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoRevert "Merge remote branch 'kc/new/bug_5734' into kcmaster"
Chris Cormack [Wed, 16 Mar 2011 03:28:00 +0000 (16:28 +1300)]
Revert "Merge remote branch 'kc/new/bug_5734' into kcmaster"

This reverts commit b18ae6dee66f5bbba3d5d78ce6885a6d34cbcecd, reversing
changes made to a52d4e8a70783fdf9cf4429931c2d133331d7ef5.

13 years agoBug 5750: (MT #4095) add exact matching filter for categorycode and branchcode fields...
Stéphane Delaune [Mon, 14 Mar 2011 06:13:03 +0000 (07:13 +0100)]
Bug 5750: (MT #4095) add exact matching filter for categorycode and branchcode fields in search members's result

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
No searching borrowers by categorycode or branchcode will only bring up
exact matches. Before searches for Staff (S) would also bring up
Students and Schools (SC, ST). Same for branchcodes.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_3495' into kcmaster
Chris Cormack [Tue, 15 Mar 2011 09:01:45 +0000 (22:01 +1300)]
Merge remote branch 'kc/new/enh/bug_3495' into kcmaster

13 years agoBug 3495: Fast bib record add at circulation
Katrin Fischer [Sun, 13 Mar 2011 20:12:57 +0000 (16:12 -0400)]
Bug 3495: Fast bib record add at circulation

The link to the Fast add framework was never shown.
Now the link is shown if you have the right permissions (fast cataloging or superlibrarian).

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5865 - Labels wrap incorrectly when paper width is greater than height
Chris Nighswonger [Mon, 14 Mar 2011 20:27:17 +0000 (16:27 -0400)]
Bug 5865 - Labels wrap incorrectly when paper width is greater than height

This is due to the incorrect use of string comparators to compare numeric values.
This patch corrects that.

Note: This should be backported to 3.2.x

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_3659' into kcmaster
Chris Cormack [Tue, 15 Mar 2011 02:58:26 +0000 (15:58 +1300)]
Merge remote branch 'kc/new/enh/bug_3659' into kcmaster

13 years agoFix for Bug 3659, Add place hold option from patron checkout tab
Owen Leonard [Tue, 15 Mar 2011 02:08:57 +0000 (21:08 -0500)]
Fix for Bug 3659, Add place hold option from patron checkout tab

Adds a button on patron-related pages, "Search to hold"
Clicking search to hold sets a cookie with the patron's
borrowernumber and sends the user to the search page.

On subsequent search results pages the user will have
the option to place holds specifically for the remembered
patron. This works on the search results page (single
and multiple hold) and on the detail page.

The saved cookie will time out after 10 minutes or
be erased when a new patron is loaded by circulation.pl

New jQuery plugin added: jquery.cookie.min.js

Revision fixes some markup and corrects an error that would lead
to the hold being initiated for the remembered patron when this
was not intended.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5693' into kcmaster
Chris Cormack [Mon, 14 Mar 2011 21:04:38 +0000 (10:04 +1300)]
Merge remote branch 'kc/new/bug_5693' into kcmaster

13 years agoBug 5693 : Follow up patch, escaping HTML in limit_cgi so "" dont break hrefs
Chris Cormack [Mon, 14 Mar 2011 20:55:06 +0000 (16:55 -0400)]
Bug 5693 : Follow up patch, escaping HTML in limit_cgi so "" dont break hrefs

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBumping database version
Chris Cormack [Mon, 14 Mar 2011 08:11:30 +0000 (21:11 +1300)]
Bumping database version

13 years agoBug 3670: change 'Item DUE' to 'Item Due' in English dbs
Nicole Engard [Fri, 11 Mar 2011 10:14:49 +0000 (11:14 +0100)]
Bug 3670: change 'Item DUE' to 'Item Due' in English dbs

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>