]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoRemove utility script replaced by a test case
Frédéric Demians [Mon, 17 Aug 2009 18:35:27 +0000 (20:35 +0200)]
Remove utility script replaced by a test case

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3532 show lost, damaged statuses on patron record
Jane Wagner [Mon, 17 Aug 2009 14:14:44 +0000 (10:14 -0400)]
Bug 3532 show lost, damaged statuses on patron record

The patron record Details tab list of checkouts does not show lost, long overdue, claims returned, or damaged status, only that an item is overdue.  Added a check for lost and damaged statuses and a display of any matching statuses to the patron Details tab.

(revised version to drop unneeded lines from moremember.tmpl file)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoTest case identifying incoherences between 'en' sysprefs and translated ones
Frédéric Demians [Mon, 17 Aug 2009 18:35:26 +0000 (20:35 +0200)]
Test case identifying incoherences between 'en' sysprefs and translated ones

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoFollow up patch for the about patch, changing management team to release team
Chris Cormack [Mon, 17 Aug 2009 10:52:04 +0000 (22:52 +1200)]
Follow up patch for the about patch, changing management team to release team

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoUpdating about page, some are bound to be missed, please send additional patches
Chris Cormack [Sat, 15 Aug 2009 22:18:16 +0000 (10:18 +1200)]
Updating about page, some are bound to be missed, please send additional patches

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3420: Fixes 'Patrons with no checkouts' report.
Garry Collum [Sat, 15 Aug 2009 13:50:24 +0000 (09:50 -0400)]
Bug 3420: Fixes 'Patrons with no checkouts' report.

Fixed typo in SQL statement.  Commented out some unused SQL statements.

Removed limit for itemtype (column not available in results) and added limit for branchcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofixed glitch in display of current time filter in OPAC top issues
Galen Charlton [Sat, 15 Aug 2009 13:45:38 +0000 (09:45 -0400)]
fixed glitch in display of current time filter in OPAC top issues

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoTranslating unimarc_leader plugin in english
Henri-Damien LAURENT [Thu, 13 Aug 2009 13:07:03 +0000 (15:07 +0200)]
Translating unimarc_leader plugin in english

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobugfix invalid comparison to ceilingDueDate in CalcDateDue()
Michael Hafen [Thu, 13 Aug 2009 22:12:33 +0000 (16:12 -0600)]
bugfix invalid comparison to ceilingDueDate in CalcDateDue()

The comparison to check the ceilingDueDate is done in the syspref format,
which isn't a good comparison.  This changes to code so the comparison is done
using iso format.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac-topissues.pl
Garry Collum [Fri, 14 Aug 2009 00:31:39 +0000 (20:31 -0400)]
Bug 2505: Enabled warnings in opac-topissues.pl

Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box.  It would not retain its value on subsequent pages if 'no Limit' was selected as an option.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.
Garry Collum [Fri, 14 Aug 2009 20:14:48 +0000 (16:14 -0400)]
Bug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.

Form - Fixes alphabetization of dropdowns.

Results - Fixes format of "Date last seen" to be the system date preference.  Adds highlighting to the table.

Enables warnings. Pages generated no warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoUpdated Help Files - Part 4
Nicole Engard [Sat, 15 Aug 2009 01:00:33 +0000 (20:00 -0500)]
Updated Help Files - Part 4

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoUpdated help files - Part 3
Nicole Engard [Sat, 15 Aug 2009 00:47:13 +0000 (19:47 -0500)]
Updated help files - Part 3

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoMore Updated Help Files
Nicole Engard [Fri, 14 Aug 2009 00:30:42 +0000 (19:30 -0500)]
More Updated Help Files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoUpdates and adds new help files
Nicole Engard [Thu, 13 Aug 2009 21:38:35 +0000 (16:38 -0500)]
Updates and adds new help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoMerge branch 'translation' of git://git.workbuffer.org/git/koha into test
Galen Charlton [Sat, 15 Aug 2009 13:24:28 +0000 (09:24 -0400)]
Merge branch 'translation' of git://git.workbuffer.org/git/koha into test

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoStarting work on translations for 3.2
Chris Cormack [Sat, 15 Aug 2009 06:36:22 +0000 (18:36 +1200)]
Starting work on translations for 3.2

15 years agoadded new module dep Digest::SHA to about.pl
Galen Charlton [Thu, 13 Aug 2009 13:29:28 +0000 (09:29 -0400)]
added new module dep Digest::SHA to about.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: tweaks to AWS request signing
Galen Charlton [Thu, 13 Aug 2009 13:25:34 +0000 (09:25 -0400)]
bug 3204: tweaks to AWS request signing

* Add AWSPrivateKey system preference to the
  Enhanced Content tab in the syspref editor
* Now warns to log if attempting to use
  the Amazon API without setting AWSPrivateKey

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: add AWSPrivateKey syspref (DBrev 040->041)
Galen Charlton [Thu, 13 Aug 2009 13:16:32 +0000 (09:16 -0400)]
bug 3204: add AWSPrivateKey syspref (DBrev 040->041)

The AWSPrivateKey syspref is describe more fully
in a previous commit, but to summarize, it should
contain the Amazon Web Services Secret Access Key
required by Amazon to sign requests to their
Product Advertising API.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: followup to fix AWS request signing
Galen Charlton [Thu, 13 Aug 2009 12:55:25 +0000 (08:55 -0400)]
bug 3204: followup to fix AWS request signing

[1] There were some ersataz spaces in the string
    being signed.
[2] AWS expects a trailing '=' in the Base64 signature

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: implement request signing for Amazon Web Services
Henri-Damien LAURENT [Tue, 7 Jul 2009 13:44:26 +0000 (15:44 +0200)]
bug 3204: implement request signing for Amazon Web Services

After 2009-08-15, Amazon Web Services will expect that
all requests to the Product Advertising API, which is what
Koha uses for retrieving reviews and other enhanced content
from Amazon, include signatures.  This patch and
subsequenct patches implement this functionality.

What this means in practice (assuming the user has elected
to use any enhanced content from Amazon) is that

[1] The user must get a Amazon Secret Access Key.  This can
    be done by logging in to the user's AWS account
    at (e.g.) http://aws.amazon.com/, going to the 'Access Identifiers'
    page, and from there retrieving and/or creating a new Secret
    Access Key.

[2] The contents of the Secret Access Key should then be
    entered into the new AWSPrivateKey system preference.

Once that is done, grabbing reviews and table of contents from Amazon
should work as normal.  If the user doesn't do this before 2009-08-15,
reviews and TOCs will no longer be supplied from Amazon, although there
should be no crashes - the content will simply not show up.

Note that the requirement to sign requests does *NOT* appear to apply
to simply displaying book covers from Amazon.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoENH: 3525 - Link to OPAC View from Staff Bib
Nicole Engard [Wed, 12 Aug 2009 22:38:08 +0000 (17:38 -0500)]
ENH: 3525 - Link to OPAC View from Staff Bib

This patch adds a link to the OPAC view for a bib
record from the staff client so catalogers can
preview changes as the patrons see them.

This patch only shows the link is the OPACBaseURL
system preference has a value.

[RM note re bug 2152: this is probably enough to keep
 OPACBaseURL after all - the staff interface has
 no other way of reliably knowing where the OPAC
 is.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago(Bug 3527) Removed unnecessary WHERE from UPDATE statement
James Winter [Wed, 12 Aug 2009 15:07:54 +0000 (11:07 -0400)]
(Bug 3527) Removed unnecessary WHERE from UPDATE statement

The WHERE in this statement selected a bunch of different accounttypes, mostly legacy items.
But for sub writeoff to be called in the first place, it must have been an account with a
positive amountoustanding already, and we have the borrowernumber and accountnumber, so this
WHERE was un-needed, and prevented writeoff of locally-defined manual invoice types.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoModified write in fines.pl to silence message unless verbose is set.
James Winter [Wed, 12 Aug 2009 15:24:30 +0000 (11:24 -0400)]
Modified write in fines.pl to silence message unless verbose is set.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac-export.pl and opac-sendbasket.pl
Garry Collum [Wed, 12 Aug 2009 17:12:37 +0000 (13:12 -0400)]
Bug 2505: Enabled warnings in opac-export.pl and opac-sendbasket.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enable warnings in opac-passwd.pl an opac-renew.pl.
Garry Collum [Wed, 12 Aug 2009 18:09:02 +0000 (14:09 -0400)]
Bug 2505: Enable warnings in opac-passwd.pl an opac-renew.pl.

Fixed resulting warnings in opac-renew.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoTerminology correction: we now use the term "hold" instead of "reserve"
Owen Leonard [Wed, 12 Aug 2009 13:44:46 +0000 (08:44 -0500)]
Terminology correction: we now use the term "hold" instead of "reserve"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoTerminology correction: we now use the term "hold" instead of "reserve"
Owen Leonard [Wed, 12 Aug 2009 13:54:52 +0000 (08:54 -0500)]
Terminology correction: we now use the term "hold" instead of "reserve"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoHide z39.50 search button for users without cataloging privileges.
Owen Leonard [Wed, 12 Aug 2009 14:57:51 +0000 (09:57 -0500)]
Hide z39.50 search button for users without cataloging privileges.

This also simplifies the display of the z39.50 search button on the search results page. It's overkill to use a YUI button when there are already simpler standard buttons in use in the same area.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAdding some style to the OPAC search results page's "highlight" link
Owen Leonard [Wed, 12 Aug 2009 16:19:20 +0000 (11:19 -0500)]
Adding some style to the OPAC search results page's "highlight" link

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoFix for Bug 3256, "Long email address cut off in patron windows"
Owen Leonard [Wed, 12 Aug 2009 17:07:08 +0000 (12:07 -0500)]
Fix for Bug 3256, "Long email address cut off in patron windows"

This fix tweaks the overflow settings for the email address and adds an image of an elipsis as the background, giving the appearance that the text is being truncated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac-userupdate.pl
Garry Collum [Wed, 12 Aug 2009 00:46:21 +0000 (20:46 -0400)]
Bug 2505: Enabled warnings in opac-userupdate.pl

Enabled warnings.  Corrected all resulting warnings by initializing variables.

Some fixes and enhancements possibly related to Bug: 1153 - Existing B_address now shows in the resulting email. Birthdate now appears in the email using the System's default format. If the patron changes data in the form data took place the FIELD name now appears as uppercase in the resulting email.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago3519 : mergeauthority and authority edition were not synched
Henri-Damien LAURENT [Tue, 11 Aug 2009 12:55:49 +0000 (14:55 +0200)]
3519 : mergeauthority and authority edition were not synched

mergeauthority and ModAuthority were working on two separate directories.
So that no authority would ever be merged via cronjob or commandline script
when MergeAuthoritiesOnUpdate is disable

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofuture hold request followup 4 - date controls
Galen Charlton [Tue, 11 Aug 2009 23:21:36 +0000 (19:21 -0400)]
future hold request followup 4 - date controls

Fixed the calendar control for selecting the request
date in staff and OPAC so that user can explicitly
select current date and all days in the future.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofuture hold request followup 3 - build_holdsqueue
Galen Charlton [Tue, 11 Aug 2009 23:20:48 +0000 (19:20 -0400)]
future hold request followup 3 - build_holdsqueue

Fixed the holds queue job so that it correctly
ignores hold requests that are not yet scheduled
to be filled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofuture hold request followup 2 - fix queries
Galen Charlton [Tue, 11 Aug 2009 23:19:50 +0000 (19:19 -0400)]
future hold request followup 2 - fix queries

Clarify when it is necessary to add a
'reservedate <= CURRENT_DATE()' clause.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agofuture hold request followup 1 - updatedatabase
Galen Charlton [Tue, 11 Aug 2009 23:18:56 +0000 (19:18 -0400)]
future hold request followup 1 - updatedatabase

Fix so that syspref description is populated after
a database updated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAllow the reserve date to be set on holds - sysprefs
Michael Hafen [Mon, 10 Aug 2009 23:17:29 +0000 (17:17 -0600)]
Allow the reserve date to be set on holds - sysprefs

This is the two system preferences controlling this feature, and the
updatedatabase addition using db verion 3.01.00.040

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAllow the reserve date to be set on holds
Michael Hafen [Tue, 11 Aug 2009 15:03:22 +0000 (09:03 -0600)]
Allow the reserve date to be set on holds

This adds to the interface and code the ability to set the reserve date when
requesting a hold.

Resubmit.  Sorry, I formatted it from the wrong branch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3522 Refactor Create Update Delete letter for consistency and readability
Colin Campbell [Tue, 11 Aug 2009 16:43:02 +0000 (17:43 +0100)]
Bug 3522 Refactor Create Update Delete letter for consistency and readability

Fixed inconsistent usuage of primary key in delete
Refactored:
Moved operations to separate subroutines to clarify data flow
Removed unnecessary redirects to self
Renamed confusingly named else variable passed to template
Other changes for code clarity
NB Outstanding:
database reading/writing should live in appropriate module
not duplicate it here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3520: fix crash when adding or editing items
Galen Charlton [Tue, 11 Aug 2009 14:46:20 +0000 (10:46 -0400)]
bug 3520: fix crash when adding or editing items

Fix the following crash when adding or editing an
item record in the staff interface:

Can't call method "append_fields" on an undefined value at
/usr/local/share/perl/5.10.0/MARC/File/SAX.pm line 92.
 at /usr/local/share/perl/5.10.0/MARC/File/SAX.pm line 92

This crash appears only if a version of MARC::File::XML
greater than 0.88 is installed, and was triggered by
C4::Biblio::TransformHtmlToXml() failing to create a valid
MARCXML blob, which must include a <record> element.

This patch also fixes the indicator values generated by
TransformHtmlToXml(), setting them to " " instead of
"" when no indicator value is supplied.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 2157: add ability to 'clean' staged record batches
Galen Charlton [Mon, 10 Aug 2009 04:18:08 +0000 (00:18 -0400)]
bug 2157: add ability to 'clean' staged record batches

batches, it is now possible to 'clean' a batch by
removing all bib and item records staged in the batch.  This
has the effect of helping to reduce database space used
by old import batches as well as removing staged records
from the cataloging reservoir search.  Note that 'cleaning'
a batch affects only the copies of the records that were staged;
if the batch was committed, cleaning the batch does not
affect any bibs and items that were committed into the catalog.

Also note that once you clean a committed batch of records, it is
impossible to undo the previous commit operation.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 2505: enable warnings in tools/manage-marc-import.pl
Galen Charlton [Mon, 10 Aug 2009 04:18:07 +0000 (00:18 -0400)]
bug 2505: enable warnings in tools/manage-marc-import.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobugfix opac-user stomps mylibraryfirst value in quick search label
Michael Hafen [Mon, 10 Aug 2009 17:24:05 +0000 (11:24 -0600)]
bugfix opac-user stomps mylibraryfirst value in quick search label

the system preference mylibraryfirst is exported by Auth containing the logged
in users branchcode.  It is also exported as the value of the syspref by
opac-user.pl.  The effect is that when mylibraryfirst is on and the user
logged in the text label for the OPAC quick search instead of displaying
'Search (in [branchcode] only)' shows 'Search (in 1 only)'.  Other user pages
are uneffected.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoShowing "more searches" menu options when JavaScript is disabled (Bug 3517)
Owen Leonard [Mon, 10 Aug 2009 18:54:48 +0000 (13:54 -0500)]
Showing "more searches" menu options when JavaScript is disabled (Bug 3517)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAdding the koha-commits list to the history
Chris Cormack [Mon, 10 Aug 2009 10:25:15 +0000 (22:25 +1200)]
Adding the koha-commits list to the history

15 years agoReverse Payment - Allows any payment to be 'undone' while retaining a record of said...
Kyle M Hall [Wed, 29 Jul 2009 17:27:11 +0000 (17:27 +0000)]
Reverse Payment - Allows any payment to be 'undone' while retaining a record of said payment. Useful for accidental double-payments.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3292: Fix to display Branch names instead of branch codes in opac serial's displays.
Garry Collum [Sun, 9 Aug 2009 20:28:08 +0000 (16:28 -0400)]
Bug 3292: Fix to display Branch names instead of branch codes in opac serial's displays.

Fixes display of branch name in opac-full-serial-issues.tmpl and opac-serial-issues.tmpl.  Also enables zebra striping in opac-serial-issues.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac-addbybiblionumber.pl and opac-alert-subscribe.pl
Garry Collum [Sun, 9 Aug 2009 21:37:36 +0000 (17:37 -0400)]
Bug 2505: Enabled warnings in opac-addbybiblionumber.pl and opac-alert-subscribe.pl

Enabled warnings and fixed unintialized variables in opac-alert-subscribe.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago_remove_stopwords in C4::Search had some issues
Henri-Damien LAURENT [Thu, 23 Jul 2009 16:47:41 +0000 (18:47 +0200)]
_remove_stopwords in C4::Search had some issues

For some reason, it would not really do an exact match on stopwords but would also prune some other part of words

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago(bug #3513) fix xhtml in marc detail
Nahuel ANGELINETTI [Thu, 6 Aug 2009 15:11:24 +0000 (17:11 +0200)]
(bug #3513) fix xhtml in marc detail

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac-serial-issues.pl and opac-showmarc.pl
Garry Collum [Sun, 9 Aug 2009 17:47:14 +0000 (13:47 -0400)]
Bug 2505: Enabled warnings in opac-serial-issues.pl and opac-showmarc.pl

Enabled warnings and also fixed resulting 'unintialized value' warning in opac-showmarc.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoCleanup docs, typos, style etc.
Joe Atzberger [Fri, 7 Aug 2009 18:54:10 +0000 (13:54 -0500)]
Cleanup docs, typos, style etc.

Unused variable removed.  Weirdness with empty position in
assignment list also removed.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoFix Maintenance page.
Joe Atzberger [Fri, 7 Aug 2009 18:40:54 +0000 (13:40 -0500)]
Fix Maintenance page.

Without this, the mainenance page would not display because of:
Cannot use undefined value as a HASH reference in C4/Auth.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3450: RSS feed link for a tag search incorrect.
Garry Collum [Sat, 8 Aug 2009 16:01:10 +0000 (12:01 -0400)]
Bug 3450: RSS feed link for a tag search incorrect.

Adds the tag parameter to the RSS feed link if the results of a query are retrieved from a tag in opac.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2505: Enabled warnings in opac_ISBDdetail.pl, opac-modrequest.pl, and opac-tags_s...
Garry Collum [Sat, 8 Aug 2009 18:37:26 +0000 (14:37 -0400)]
Bug 2505: Enabled warnings in opac_ISBDdetail.pl, opac-modrequest.pl, and opac-tags_subject.pl.

Enabling warnings in these files did not generate any warnings in the logs when tested.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago(bug #3497) show publication year, or copyrightdate
Nahuel ANGELINETTI [Wed, 5 Aug 2009 08:07:36 +0000 (10:07 +0200)]
(bug #3497) show publication year, or copyrightdate

This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago(bug #3505) fix 210c and 225a unimarc's plugins
Nahuel ANGELINETTI [Wed, 5 Aug 2009 13:14:13 +0000 (15:14 +0200)]
(bug #3505) fix 210c and 225a unimarc's plugins

This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago(bugs #3502) search on available items in unimarc
Nahuel ANGELINETTI [Tue, 4 Aug 2009 14:30:43 +0000 (16:30 +0200)]
(bugs #3502) search on available items in unimarc

this add a "w" index, that allow to search on available items only

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3465: enhance DB update reporting by web installer
Galen Charlton [Sat, 1 Aug 2009 16:17:18 +0000 (12:17 -0400)]
bug 3465: enhance DB update reporting by web installer

This enhances the web installer so that messages from updatedatabase.pl will
be displayed to the user running a database update.  Messages printed to STDOUT
will be displayed as the update report, while messages printed to STDERR will
be displayed as update errors.

This patch introduces  a new module dependency, IPC::Cmd.
IPC::Cmd lets one run an external program such as updatedatabase.pl and easily
capture STDERR and STDOUT for further munging.  IPC::Cmd is core in Perl 5.10
and stable in Perl 5.8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3467 followup: fix test for item found
Galen Charlton [Tue, 4 Aug 2009 01:24:26 +0000 (21:24 -0400)]
bug 3467 followup: fix test for item found

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoQuick Spine Label Printer - Minors fixes
Kyle M Hall [Mon, 3 Aug 2009 16:26:26 +0000 (16:26 +0000)]
Quick Spine Label Printer - Minors fixes

This new version of the patch does away with the need for 2 spinelabel css files.

This patch address two points brought up:
[1] (minor) if an item is not found, it should say so and return to
spinelabel-home.pl, not show an empty label
[2] (minor) can the print button be excluded from the printout?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoCreated database-tidying cron script
J. David Bavousett [Sat, 1 Aug 2009 23:38:44 +0000 (19:38 -0400)]
Created database-tidying cron script

This little script establishes a framework for database cleanup on some regular
schedule.  Initial implementation provides for brute truncation of the sessions
table, and selective-by-age cleanup of the zebraqueue.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoAdding new committer to history
Chris Cormack [Sat, 1 Aug 2009 19:24:34 +0000 (07:24 +1200)]
Adding new committer to history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3466: Fixes xhtml errors in opac-shelves.tmpl.
Garry Collum [Sun, 2 Aug 2009 02:03:24 +0000 (22:03 -0400)]
Bug 3466: Fixes xhtml errors in opac-shelves.tmpl.

Addendum to bug 3466.  opac-shelves.tmpl contained the same xhtml error as shelves.tmpl, if the user is viewing the public list a orphaned table row (<tr>) is present.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2553: Alphabetizes branches and item-type drop-down lists in opac-topissues.pl.
Garry Collum [Sun, 2 Aug 2009 02:49:53 +0000 (22:49 -0400)]
Bug 2553: Alphabetizes branches and item-type drop-down lists in opac-topissues.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoDB rev 038>039 (for real, this time)
Galen Charlton [Sun, 2 Aug 2009 15:06:05 +0000 (11:06 -0400)]
DB rev 038>039 (for real, this time)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agotextual cleanup of new quick spine label code
Galen Charlton [Sun, 2 Aug 2009 15:05:30 +0000 (11:05 -0400)]
textual cleanup of new quick spine label code

* perltidy
* added license header to source files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoquell warning on NULL item fields
Galen Charlton [Sun, 2 Aug 2009 15:01:55 +0000 (11:01 -0400)]
quell warning on NULL item fields

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoremoved unneeded module imports
Galen Charlton [Sun, 2 Aug 2009 14:57:41 +0000 (10:57 -0400)]
removed unneeded module imports

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoquick spoine label followup: sysprefs
Galen Charlton [Sun, 2 Aug 2009 14:51:29 +0000 (10:51 -0400)]
quick spoine label followup: sysprefs

* Added missed SpineLabelAutoPrint to updatedatabase;
  this preference controls whether labels generated
  by the new quick spine label tool are printed automatically
* put SpineLabelAutoPrint and SpineLabelFormat in the
  Cataloging section of the syspref editor
* set height and width for the SpineLabelFormat textarea
  in the syspref editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobumping quick spine label printing to DBrev 039
Galen Charlton [Sat, 1 Aug 2009 15:14:52 +0000 (11:14 -0400)]
bumping quick spine label printing to DBrev 039

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoQuick Spine Label Printer
Kyle M Hall [Fri, 10 Jul 2009 15:50:25 +0000 (15:50 +0000)]
Quick Spine Label Printer

This is a small tool for quickly printing spine labels using dedicated label printers.
It is located in the Tools page as Quick Spine Label Creator.
The system preference SpineLabelFormat defines which fields will be displayed.
The pref SpineLabelAutoPrint will make the print dialog pop up automatically.
The CSS file spinelabel.css controls all presentation for the labels.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoDB rev 038->039
Galen Charlton [Sat, 1 Aug 2009 13:58:20 +0000 (09:58 -0400)]
DB rev 038->039

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3440 followup: tweak updatedatabase.pl
Galen Charlton [Sat, 1 Aug 2009 13:56:51 +0000 (09:56 -0400)]
bug 3440 followup: tweak updatedatabase.pl

[1] Removed POD: not a bad idea, but if we do it,
    there should be more substance to the messages
[2] Improved description of change
[3] Removed extra 'my' qualifier.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3440: C4/Branch.pm: the branch{zip,city,country,url,notes} rows should be taken...
Sébastien Hinderer [Mon, 27 Jul 2009 08:33:27 +0000 (10:33 +0200)]
bug 3440: C4/Branch.pm: the branch{zip,city,country,url,notes} rows should be taken into account during Add and Mod operations.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3440: Modifies branches script and template so that the newly added rows are...
Sébastien Hinderer [Mon, 27 Jul 2009 09:43:24 +0000 (11:43 +0200)]
bug 3440: Modifies branches script and template so that the newly added rows are taken into account.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3440: Database structure modification.
Sébastien Hinderer [Fri, 24 Jul 2009 09:00:07 +0000 (11:00 +0200)]
bug 3440: Database structure modification.

Adds 5 columns to the `branches` table: `branchzip`, `branchcity`,
`branchcountry`, `branchurl` and `branchnote`.
I/O operations for these fields are not included.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 2505: cleanup warnings in reserve/request.pl
Galen Charlton [Sat, 1 Aug 2009 13:09:42 +0000 (09:09 -0400)]
bug 2505: cleanup warnings in reserve/request.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2889: Removed toggle variable from Serials vendor search.
Garry Collum [Thu, 23 Jul 2009 03:53:00 +0000 (23:53 -0400)]
Bug 2889: Removed toggle variable from Serials vendor search.

Removed toggle variable from acqui-search-result.pl.  Added highlighting using __odd__ to acqui-search-result.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 2553: Additional patch for the branch drop-down in Existing Holds.
Garry Collum [Thu, 23 Jul 2009 01:07:16 +0000 (21:07 -0400)]
Bug 2553: Additional patch for the branch drop-down in Existing Holds.

Improves previous patch through the use of GetBranchesLoop. Also adds highlighting to the Existing holds table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoStop generation of unnecessary warning messages to log over undef values
Colin Campbell [Wed, 22 Jul 2009 17:07:30 +0000 (18:07 +0100)]
Stop generation of unnecessary warning messages to log over undef values

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoInstaller break utf8 for DBD::mysql
Henri-Damien LAURENT [Thu, 23 Jul 2009 11:20:07 +0000 (13:20 +0200)]
Installer break utf8 for DBD::mysql

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoMinor change to fix Bug 3086, Can't close circulation date-picker popup in Internet...
Owen Leonard [Thu, 23 Jul 2009 14:44:02 +0000 (09:44 -0500)]
Minor change to fix Bug 3086, Can't close circulation date-picker popup in Internet Explorer

I don't know why this edit fixes the problem, but it does. Tested in IE6, IE7, and IE8 on Windows XP.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoremoved redundant license statement
Galen Charlton [Sat, 1 Aug 2009 12:15:17 +0000 (08:15 -0400)]
removed redundant license statement

The standard license statement in the header is fine; please
don't confuse things by doing anything different.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoscript to remove authorities without biblio attached
Paul Poulain [Thu, 23 Jul 2009 15:23:35 +0000 (17:23 +0200)]
script to remove authorities without biblio attached

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoRemoving unused recentacquiloop markup (Bug 3439)
Owen Leonard [Thu, 23 Jul 2009 16:40:38 +0000 (11:40 -0500)]
Removing unused recentacquiloop markup (Bug 3439)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years ago(bug #3458) fix die and unimarc 700-4 plugin
Nahuel ANGELINETTI [Fri, 31 Jul 2009 14:04:01 +0000 (16:04 +0200)]
(bug #3458) fix die and unimarc 700-4 plugin

This patch, fix the unimarc 700-4 plugin, adding the plugin_parameters() function.
And add an eval, that permit to have error in plugin, but don't die the editor.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoMore XHTML corrections (Bug 3211)
Owen Leonard [Wed, 22 Jul 2009 17:48:05 +0000 (12:48 -0500)]
More XHTML corrections (Bug 3211)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoXHTML corrections (Bug 3211)
Owen Leonard [Wed, 22 Jul 2009 16:53:29 +0000 (11:53 -0500)]
XHTML corrections (Bug 3211)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3452: Additional patch that expands the branch name and category code in Suggesti...
Garry Collum [Thu, 30 Jul 2009 23:16:41 +0000 (19:16 -0400)]
Bug 3452: Additional patch that expands the branch name and category code in Suggestions Management.

Displays the Branch name and Category description along with their codes in Suggestion Management.

Also since I joined to the branches table the 'map' function in opac-suggestions.pl to retrieve the branchname was no longer necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3434 Fix SQL Syntax Error when setting claimdate
Colin Campbell [Wed, 22 Jul 2009 14:42:57 +0000 (15:42 +0100)]
bug 3434 Fix SQL Syntax Error when setting claimdate

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug 3434) Fix generation of Serials Claims
Colin Campbell [Wed, 22 Jul 2009 16:41:00 +0000 (17:41 +0100)]
(bug 3434) Fix generation of Serials Claims

op was not being returned to claims.pl. It seems better logic
to use whether the there are ids the user has flagged for claims
to decide whether to generate the claims

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUser will find it useful to see the date claimed
Colin Campbell [Thu, 23 Jul 2009 16:09:31 +0000 (17:09 +0100)]
User will find it useful to see the date claimed

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3435: added missing _ in _FixAccountForLostAndReturned
Galen Charlton [Thu, 30 Jul 2009 18:35:29 +0000 (14:35 -0400)]
bug 3435: added missing _ in _FixAccountForLostAndReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBugfix 2339 - Place hold button display with AllowOnShelfHolds OFF (Part 2)
Kyle M Hall [Thu, 30 Jul 2009 11:56:25 +0000 (11:56 +0000)]
Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF (Part 2)

Added code to opac-ISBDdetail.pl to match the changes made to the template file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding missing image: Bug 3457, broken image in opac.css - new.gif
Owen Leonard [Thu, 30 Jul 2009 13:14:42 +0000 (08:14 -0500)]
Adding missing image: Bug 3457, broken image in opac.css - new.gif

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3435 followup: tweak AddReturn cleanup
Galen Charlton [Thu, 30 Jul 2009 15:27:22 +0000 (11:27 -0400)]
bug 3435 followup: tweak AddReturn cleanup

We're returning issue information when available,
not just item information.  Fixes problem where
circ/returns.pl wasn't displaying the due date
and patron when returning a loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3435: SIP2 - 3M extension for SmartChute checkin.
Joe Atzberger [Thu, 30 Jul 2009 00:56:08 +0000 (19:56 -0500)]
bug 3435: SIP2 - 3M extension for SmartChute checkin.

Implement the optional fields: CR CS CT CV CY and DA.
Also silenced some outstanding debugging print statements.
Consolidated similar accesseor subs in Patron.pm to use x_items.
Adjust SIP tests to specify correct AP (location).  Add a 3rd item
to SIPtext.pm for later use.

Note CT (destination) is currently populated with destination branch code.
We can adjust that to be destination branch name, or some combination in
a subsequent patch if necessary.

This work was sponsored by the Northeast Kansas Library system.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>