]> git.koha-community.org Git - koha.git/log
koha.git
11 years agoBug 10052: Db revision for intranetstylesheet
Marcel de Rooy [Mon, 15 Apr 2013 10:06:31 +0000 (12:06 +0200)]
Bug 10052: Db revision for intranetstylesheet

Report 10052 makes the intranetstylesheet prefs behave like the opac ones.
This patch contains an optional db revision: If the pref intranetstylesheet is
not blank, and does not start with http, https or /, then prefix it with a
slash to make it an absolute path.

Test plan:
Before applying this patch:
1) Put intranet-tmpl/prog/en/css/staff-global.css into intranetstylesheet.
This works in the current staff client, but will be interpreted as relative as
soon as both patches for this report have been applied.
Apply the patch. And run: /cgi-bin/koha/installer/install.pl?step=3&op=updatestructure
Check the webinstaller warning and the pref value. There should be a slash
in front now. The css should still work.

Continue after applying this patch with:
2) Clear the intranetstylesheet pref. Run updatestructure again. No message: OK
3) Put /intranet-tmpl/prog/en/css/staff-global.css in intranetstylesheet.
Run updatestructure again. No message: OK
4) Prefix intranetstylesheet with http://[your-server-here]. Test again.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on last patch.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agobug 9722: DBrev 3.13.00.004 to add OpacShowHoldNotes syspref
Galen Charlton [Thu, 23 May 2013 15:29:24 +0000 (08:29 -0700)]
bug 9722: DBrev 3.13.00.004 to add OpacShowHoldNotes syspref

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agobug 9722: (followup) allow patrons to see hold notes in their summary
Galen Charlton [Thu, 23 May 2013 15:28:32 +0000 (08:28 -0700)]
bug 9722: (followup) allow patrons to see hold notes in their summary

If we allow patrons to set them, we should let them see
them as well.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 9722: Toggle display of hold notes with Edit notes button
Marcel de Rooy [Mon, 4 Mar 2013 07:12:15 +0000 (08:12 +0100)]
Bug 9722: Toggle display of hold notes with Edit notes button

Small adjustments, requested by Kyle:
1) Rename Show notes button. It is called now: Edit notes.
2) Do not hide all other notes fields. The Edit button now only toggles
the corresponding hold notes field.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoBug 9722: Allow users to add notes when placing a hold in opac (dbrev)
Marcel de Rooy [Thu, 28 Feb 2013 07:53:36 +0000 (08:53 +0100)]
Bug 9722: Allow users to add notes when placing a hold in opac (dbrev)

Database revision for report 9722, adding new pref OpacShowHoldNotes.
This development is part of a larger one (see umbrella report 9721).

Test plan:
Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure
Optionally, run a new install to test sysprefs.sql.
Or:
Edit sysprefs.sql, leave at least the last few lines including the new one.
And run from command line:  mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoBug 9722: Allow users to add notes when placing a hold in opac
Marcel de Rooy [Mon, 25 Feb 2013 14:21:57 +0000 (15:21 +0100)]
Bug 9722: Allow users to add notes when placing a hold in opac

The option of adding a note is controlled by new pref OpacShowHoldNotes.
This development is part of a larger one (see umbrella report 9721).

Test plan:
1 Verify if new pref is disabled by default. Place a hold. You can't add a note.
2 Enable the pref. Place a hold and add a note. Check in staff if you can see
the note in Catalogue Detail/Holds tab.
3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture,
OPACShowHoldQueueDetails, or OPACItemHolds.
Check the display of columns when placing a hold from opac.
4 Place a few holds with notes from opac search results in one run (enable
DisplayMultiPlaceHold). Check results in staff again.

Remark: A few lines already refer to mandatory note reasons. This is handled
in a subsequent report. No reason to worry.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoBug 9806: Remove single pixel on the basketgroup table
Jonathan Druart [Thu, 23 May 2013 08:53:07 +0000 (10:53 +0200)]
Bug 9806: Remove single pixel on the basketgroup table

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 9806 : QA Followup - use template plugin for branch names
Mathieu Saby [Sat, 18 May 2013 13:28:42 +0000 (15:28 +0200)]
Bug 9806 : QA Followup - use template plugin for branch names

With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed.
The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin.

To test :
do the same test as for main patch :
1) make some basketgroups with 0, 1, 2 baskets
2) make some basketgroups with different billing and deliveryplace
3) check the list of open and closed basketgroups
4) check action buttons are working like before

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 9806 : Add new columns to basket groups lists
Mathieu Saby [Mon, 18 Mar 2013 19:30:46 +0000 (20:30 +0100)]
Bug 9806 : Add new columns to basket groups lists

Revised to fix whitespace problems. Cosmetic changes put in an other patch.

In the list of all the open/closed basketgroups for a vendor, you just
have the name of each basketgroup, and 3 action buttons.
It is not sufficient for libraries using basketgroup.

This patch adds the following columns :
- number (id of basketgroup)
- billingplace (name of the library)
- deliveryplace (name of the library, or "free delivery place")
- number of baskets in each basketgroup

To test :
1) make some basketgroups with 0, 1, 2 baskets
2) make some basketgroups with different billing and deliveryplace
3) check the list of open and closed basketgroups
4) check action buttons are working like before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
This is a nice improvement!

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10313 Fix link to invoice from orders
Colin Campbell [Wed, 22 May 2013 18:32:45 +0000 (19:32 +0100)]
Bug 10313 Fix link to invoice from orders

Need to have invoiceid and pass it to retrieve selected
invoicenumber. Wrong data passed causing incorrect
records to be displayed

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10310: Followup Prevent submitting form with enter does not work with IE
Jonathan Druart [Thu, 23 May 2013 07:33:48 +0000 (09:33 +0200)]
Bug 10310: Followup Prevent submitting form with enter does not work with IE

Check e.target.type instead of using jQuery.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10310: Prevent submitting form with enter does not work with IE
Jonathan Druart [Wed, 22 May 2013 13:49:26 +0000 (15:49 +0200)]
Bug 10310: Prevent submitting form with enter does not work with IE

I am not able to test this patch with IE...
I tested it with Chromium and FF and it works great.

This patch can be tested on the neworderempty.pl page
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10036 - adding header search to additem page
Owen Leonard [Tue, 30 Apr 2013 19:33:48 +0000 (15:33 -0400)]
Bug 10036 - adding header search to additem page

The add item screen lacks a header search form. This patch adds the
cataloging header search include to additem.tt.

To test, apply the patch and add items to or edit items of an existing
record. The header search form should appear with options for cataloging
search and circulation.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoprefer CheckVersion in updatedatabase.pl
Galen Charlton [Wed, 22 May 2013 18:57:33 +0000 (11:57 -0700)]
prefer CheckVersion in updatedatabase.pl

Fixes an inconsistency with a couple recent
DBrev patches.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agobug 7718: DBRev 3.13.00.003
Galen Charlton [Wed, 22 May 2013 15:51:33 +0000 (08:51 -0700)]
bug 7718: DBRev 3.13.00.003

- remove serial.itemnumber column

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 7718 - Remove itemnumber column from serials table
Kyle M Hall [Mon, 4 Feb 2013 13:16:58 +0000 (08:16 -0500)]
Bug 7718 - Remove itemnumber column from serials table

Remove the column 'itemnumber' from the table 'serial'. This is
a 1 to many relationship, and this reference does not make sense.
The 'serialitems' table handles the relationship between the 'items'
table and the 'serial' table.

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Verify serial.itemnumber has been removed from the database

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Column removed. No errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10080: DBRev 3.13.00.002
Galen Charlton [Wed, 22 May 2013 15:14:23 +0000 (08:14 -0700)]
Bug 10080: DBRev 3.13.00.002

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10080: (followup) change two last instances of the old syspref name
Galen Charlton [Wed, 22 May 2013 15:06:11 +0000 (08:06 -0700)]
Bug 10080: (followup) change two last instances of the old syspref name

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10080 - Change system pref IndependantBranches to IndependentBranches - Followup
Kyle M Hall [Tue, 21 May 2013 17:12:55 +0000 (13:12 -0400)]
Bug 10080 - Change system pref IndependantBranches to IndependentBranches - Followup

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10080 - Change system pref IndependantBranches to IndependentBranches
Kyle M Hall [Wed, 15 May 2013 14:10:10 +0000 (10:10 -0400)]
Bug 10080 - Change system pref IndependantBranches to IndependentBranches

Test Plan:
1) Enable IndependantBranches
2) Apply this patch
3) Run updatedatabase.pl
4) Verify that the system preference still functions correctly

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 9507: prevent submit: refactor some code in a js file
Jonathan Druart [Wed, 30 Jan 2013 14:19:58 +0000 (15:19 +0100)]
Bug 9507: prevent submit: refactor some code in a js file

This patch refactors some code in a js file.

Test plan:
On acqui/neworderempty.pl, acqui/orderreceive.pl and
serials/serials-edit.tt try to scan a barcode (or press enter) on the
form and check that it is not sent.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Have to note that the code for IE9 does not work. Before and after this patch.
If we refactor code, it would have been nice to resolve this too.
But I do not oppose pushing this patch.
The test uses 'an ancient Netscape property' window.Event (uppercase!) to make
the distinction between browers and event models. Some more documentation here
would be welcome too.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10261: Link to patron files missing from circ-menu.tt
Owen Leonard [Fri, 17 May 2013 16:06:25 +0000 (12:06 -0400)]
Bug 10261: Link to patron files missing from circ-menu.tt

The link to patron files doesn't appear on some pages. That's because
the link was added to circ-menu.inc but not circ-menu.tt. Each is used
by different patron-related pages. This patch adds the missing link.

To test, enable the EnableBorrowerFiles system preference and view
members/pay.pl or members.paycollect.pl. The "Files" tab should appear
in the left-hand sidebar menu. Other patron pages should show the same.

Edit: Corrected scope of template variables which shouldn't have been
copied directly from circ-menu.inc without changing scope.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
all tests pass
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 6413 - QA Followup - Remove extra table column header
Kyle M Hall [Wed, 8 May 2013 16:41:26 +0000 (12:41 -0400)]
Bug 6413 - QA Followup - Remove extra table column header

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 6413 - QA Followup - Add notes for 'Pay selected'
Paul Poulain [Wed, 20 Mar 2013 10:37:05 +0000 (11:37 +0100)]
Bug 6413 - QA Followup - Add notes for 'Pay selected'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 6413 follow-up: fixing capital case & tabs
Paul Poulain [Mon, 30 Apr 2012 15:51:47 +0000 (17:51 +0200)]
Bug 6413 follow-up: fixing capital case & tabs

* switching from "Payment Note" to "Payment note"
* replaced tabs by 4 spaces in lines just before and after this fix, for consistent indenting

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 6413 Added ability to add a note when paying or writing off a fine
Chris Hall [Thu, 26 Jan 2012 03:04:53 +0000 (16:04 +1300)]
Bug 6413 Added ability to add a note when paying or writing off a fine

Code will also respect notes when using the "Writeoff All" button but WILL NOT when using either the "Pay Amount" or "Pay Selected" buttons Fixed uri encoding of arguments

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agobug 8215: (followup) avoid spurious warning in Apache log
Galen Charlton [Tue, 21 May 2013 16:06:18 +0000 (09:06 -0700)]
bug 8215: (followup) avoid spurious warning in Apache log

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agobug 8215: DBRev 3.13.00.001 for course reserves
Galen Charlton [Mon, 20 May 2013 18:22:44 +0000 (11:22 -0700)]
bug 8215: DBRev 3.13.00.001 for course reserves

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agobug 8215: (followup) remove extraneous underscore in template
Galen Charlton [Tue, 21 May 2013 17:24:28 +0000 (10:24 -0700)]
bug 8215: (followup) remove extraneous underscore in template

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
11 years agobug 8215: (followup) rename GetItemReservesInfo
Galen Charlton [Tue, 21 May 2013 17:16:34 +0000 (10:16 -0700)]
bug 8215: (followup) rename GetItemReservesInfo

Renamed that routine to GetItemCourseReservesInfo in
order to avoid any potential confusion with reserves
qua hold requests.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
11 years agobug 8215: (followup) avoid SQL syntax error in logs
Galen Charlton [Tue, 21 May 2013 17:12:15 +0000 (10:12 -0700)]
bug 8215: (followup) avoid SQL syntax error in logs

ModItem currently will attempt to update an item
even if no field updates are specified.  This patch
avoids (harmless) error messages in the Apache
logs if an item is not actually being changed when it
is placed or taken off reserve.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
11 years agobug 8215: (followup) don't allow deleting course reserves from OPAC
Galen Charlton [Tue, 21 May 2013 16:56:17 +0000 (09:56 -0700)]
bug 8215: (followup) don't allow deleting course reserves from OPAC

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
11 years agobug 8215: (followup) make sure C4::CourseReserves doesn't export anything
Galen Charlton [Tue, 21 May 2013 16:53:03 +0000 (09:53 -0700)]
bug 8215: (followup) make sure C4::CourseReserves doesn't export anything

New modules should not export any symbols by default
without a very good reason.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
11 years agobug 8215: (followup) run new files through perltidy
Galen Charlton [Tue, 21 May 2013 15:43:41 +0000 (08:43 -0700)]
bug 8215: (followup) run new files through perltidy

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
11 years agoBug 8215: FIX ergonomic issue : 'Unchanged()'
Jonathan Druart [Thu, 2 May 2013 14:46:51 +0000 (16:46 +0200)]
Bug 8215: FIX ergonomic issue : 'Unchanged()'

11 years agoBug 8215: Followup Fix confirmation links for delete course and item
Jonathan Druart [Thu, 21 Mar 2013 13:52:52 +0000 (14:52 +0100)]
Bug 8215: Followup Fix confirmation links for delete course and item

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoBug 8215 - Add Course Reserves - QA Followup
Kyle M Hall [Thu, 21 Mar 2013 13:15:28 +0000 (06:15 -0700)]
Bug 8215 - Add Course Reserves - QA Followup

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoBug 8215: Followup FIX QA issues
Jonathan Druart [Thu, 21 Mar 2013 09:08:41 +0000 (10:08 +0100)]
Bug 8215: Followup FIX QA issues

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoBug 8215 follow-up encoding for branches & itemtypes
Paul Poulain [Fri, 28 Sep 2012 14:45:37 +0000 (16:45 +0200)]
Bug 8215 follow-up encoding for branches & itemtypes

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Corinne Bulac <corinne.hayet@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
11 years agoBug 8215 - Course Reserves
Kyle M Hall [Tue, 17 Apr 2012 12:07:32 +0000 (08:07 -0400)]
Bug 8215 - Course Reserves

Adds a course reserves system for academic libraries.

The course reserves system allows libraries to create courses
and put items on reserves for those courses.

Each item with at least one reserve can have some of its attributes
modified while it is on reserve for at least one active course.
These attributes include item type, collection code, shelving location,
and holding library. If there are no active courses with this item
on reserve, it's attributes will revert to the original attributes
it had before going on reserve.

Test Plan:
  1) Create new authorised value categories DEPARTMENT and TERM
  2) Create a new course, add instructors to that course.
  3) Reserve items for that course, verify item attributes have changed.
  4) Disable course, verify item attributes have reverted.
  5) Enable course again, verify item attributes again.
  6) Delete course, verify item attributes again.
  7) Create two new courses, add the same item(s) to both courses.
  8) Disable one course, verify item attributes have not reverted.
  9) Disable both courses, verify item attributes have reverted.
 10) Enable one course, verify item attributes are again set to the
     new values.
 11) Edit reserve item attributes, verify.
 12) Disable all courses, edit reserve item attributes, verify
     the item itself still has its original attributes, verify
     the reserve item attributes have been updated.
 13) Verify the ability to remove instructors from a course.
 14) Verify new permissions, top level coursereserves, with
     subpermissions add_reserves and delete_reserves.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Corinne Bulac <corinne.hayet@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
http://bugs.koha-community.org/show_bug.cgi?id=8125

11 years agoBug 7883 - Save and continue editing for cataloging
Liz Rea [Wed, 13 Mar 2013 22:35:23 +0000 (11:35 +1300)]
Bug 7883 - Save and continue editing for cataloging

Patch reworked from Elliot Davis' original patch - but using bootstrap instead of YUI.

This patch adds the ability for catalogers to save and continue editing when adding new biblios.

To Test:

Select an existing item or create a new item in cataloging using your favorite framework.
Edit the bib
From the save menu in the dropdown, select the new option of "Save and continue editing"
If you are missing required fields you should still be prompted to fill them in before saving
Once all required fields are in place you should be allowed to save, and you will be redirected to tab 0.

The original patch claims to redirect to the original tab, but I never observed that behaviour from it - this patch merely takes what was in the original and makes it boostrap.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10288 - Fix a tiny typo on "Pending offline circulation actions"
Magnus Enger [Sun, 19 May 2013 16:56:00 +0000 (18:56 +0200)]
Bug 10288 - Fix a tiny typo on "Pending offline circulation actions"

To test:
- Apply the patch
- Go to <intranet>/cgi-bin/koha/circ/circulation-home.pl
- Verify that is says "There are no pending offline operations."
- Sign off

Or just have a look at the patch...

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10251: Fix typos in Patron Permissions Help
Nicole C. Engard [Sun, 19 May 2013 18:02:01 +0000 (14:02 -0400)]
Bug 10251: Fix typos in Patron Permissions Help

This is a string patch that fixes the typos in the patron
permission help file.

To test:

* go to a patron record
* click 'set permissions' under more
* click 'help'
* confirm that text is right

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 2774 - Path to theme is hard-coded in many places
Owen Leonard [Mon, 25 Mar 2013 16:21:24 +0000 (12:21 -0400)]
Bug 2774 - Path to theme is hard-coded in many places

Many templates have instances where the path to the prog template is
hard-coded. Now that interface and theme template variables are
available everywhere these paths should be corrected to use them.

Image paths corrected:

- 'Patron image missing' image on circulation pages
- 'Locked' icon on fund planning page
- Tag and subfield edit icons on the authority, biblio editor, and batch
  item modification pages (Clone tag, delete tag, clone subfield,
  delete subfield, move subfield)
- 'Loading' icon when importing frameworks

Audio file paths corrected:

- Sounds for circulation.pl and returns.pl

Paths to DataTables assets corrected on:

- Transfers to receive report
- Holds queue report
- Holds awaiting pickup report
- Patron detail page (moremember.pl)
- Patron circulation history
- Update child to adult patron page
- Process offline circulations
- Catalog by item type report
- Serials statistics wizard
- Serial claims page
- Koha news
- Notices
- Batch patron modifications

Path to progress bar assets corrected on:

- Process offline circulations page
- Progressbar include file
- Stage MARC imports
- Manage MARC imports
- Local cover image upload

Other image paths:

- "Approved" checkmark image on tags review page
- Table sort icons on lists page
- Feed icon on OPAC search result page
- "Loading" image for OPAC plain MARC view

Path to ratings JavaScript on OPAC detail and results pages

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Checked all the pages modified by this patch, no problems noted

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoDBrev 3.13.00.000 -- onwards to Koha Pi!
Galen Charlton [Mon, 20 May 2013 17:18:03 +0000 (10:18 -0700)]
DBrev 3.13.00.000 -- onwards to Koha Pi!

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 9508 follow-up : replacing tabs by spaces
Paul Poulain [Fri, 22 Mar 2013 16:43:23 +0000 (17:43 +0100)]
Bug 9508 follow-up : replacing tabs by spaces

This patch fixes tabs and replace them by spaces

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 9508: Standardize the dateformat value from C4::Auth
Jonathan Druart [Tue, 18 Dec 2012 14:09:22 +0000 (15:09 +0100)]
Bug 9508: Standardize the dateformat value from C4::Auth

- the dateformat value is send to all templates (from
  C4::Auth::get_template_and_user)
- remove all assignment of dateformat in all .pl files

- Remove "all" occurrences (those I found!) of dateformat_*
From now the only way to get the date format is a string comparaison
(dateformat == "metric")

Checked with the command:
  git grep "\(dateformat_us\|dateformat_metric\|dateformat_iso\)" | grep
  -v translator

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Tested all the datepickers I could find, looks good.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 6399 - tooltip for tags that says 'separate by comma'
Owen Leonard [Wed, 15 May 2013 12:45:32 +0000 (08:45 -0400)]
Bug 6399 - tooltip for tags that says 'separate by comma'

Some sites split tags on spaces, some on commas. Since Koha splits on a
comma, we should make that clear to the patron. This patch adds
additional text to the "New tag(s)" label.

To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList.
Click "Add tag" on both OPAC search results and an OPAC detail page.
Confirm that the revised label appears correctly.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
all tests pass

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass. There are some more places where we can
add tags to multiple records at once, I noted them on the bug.

http://bugs.koha-community.org/show_bug.cgi?id=10259

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10178 - Typos in plugins for 006 and 008 in MARC21
Bernardo Gonzalez Kriegel [Fri, 3 May 2013 01:18:27 +0000 (22:18 -0300)]
Bug 10178 - Typos in plugins for 006 and 008 in MARC21

Well, not only typos. There is also a NEW update for
006/8 Music on April 2013. And 3 missing values in 006.

Revised descriptions and labels, source LOC page.
Strings spell checked.

To test:
1) Apply the patch
2) Test that MARC21 006 and 008 value builders works
properly.

Small string changes.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
XML changes only, passes all tests.
Contains string changes, so should go into 3.14.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt
Mathieu Saby [Sat, 4 May 2013 09:31:24 +0000 (11:31 +0200)]
Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt

This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt.

To test :
- in a UNIMARC Koha instance, edit a record
- open the plugin for 115a subfield
- check the "Form of release - visual projection, motion picture" option
  list is correct, especially the value "other film type"
- open the plugin for 116 field
- check the "Technique (prints) 2" option list is correct, especially
  the value "lithography"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I did not test this in Koha, but it's a simple change of one character
which I'm comfortable with signing off on.

I don't know if this counts as a string change or not, since the string
was previously mixed with a malformed tag.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and fixes an obvious problem in the HTML.
I checked the po files - currently the strings appear as:
"other film type/option> %s "

So in theory it's possible to translate them correctly even
if the standard templates now are not correct.
Probably has to wait for 3.14.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoBug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year
Mathieu Saby [Sat, 4 May 2013 09:07:55 +0000 (11:07 +0200)]
Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year

In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year)
At present, if the option value is selected, it is "2/years".
This patch supresses the "s" after "year".

To test :
- in a subscription, change periodicity to "2/year"
- save the subscription
- reopen it and check the value is labelled "2/year"

Signed-off-by: David Cook <dcook@prosentient.com.au>
Trivial change. Works as described.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoIncrement version for 3.12.0 release
Jared Camins-Esakov [Sun, 19 May 2013 21:42:07 +0000 (17:42 -0400)]
Increment version for 3.12.0 release
(cherry picked from commit 85a1b8a50b5ac85032359c93dd9514c714f4640e)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoUpdate release notes for final 3.12.00 release
Jared Camins-Esakov [Sun, 19 May 2013 21:40:14 +0000 (17:40 -0400)]
Update release notes for final 3.12.00 release
(cherry picked from commit 3b825dcf38426884a7ff9f48314f039502206c27)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10287' into 3.14-master
Jared Camins-Esakov [Sun, 19 May 2013 15:44:20 +0000 (11:44 -0400)]
Merge branch 'bug_10287' into 3.14-master

11 years agoBug 10287: Remove 1px artifacts from budget admin page
Jared Camins-Esakov [Sun, 19 May 2013 15:41:09 +0000 (11:41 -0400)]
Bug 10287: Remove 1px artifacts from budget admin page

Changes follow the method used in bug 10183 and bug 9791.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9824' into 3.14-master
Jared Camins-Esakov [Sun, 19 May 2013 12:43:46 +0000 (08:43 -0400)]
Merge branch 'bug_9824' into 3.14-master

11 years agoBug 9824: Make it possible to apply/cancel switch
Katrin Fischer [Fri, 17 May 2013 19:12:05 +0000 (21:12 +0200)]
Bug 9824: Make it possible to apply/cancel switch

Using another existing string 'Apply filter' we are now
able to cancel the filter... and apply it... and cancel it
again... and so on.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 9824: Followup for removing filter
Marcel de Rooy [Fri, 17 May 2013 17:01:06 +0000 (19:01 +0200)]
Bug 9824: Followup for removing filter

Adds allbaskets parameter to GetBasketsInfosByBookseller. (Only used in booksellers.pl now)
Normally, all 'active' baskets are shown. With allbaskets=1 all baskets :)
In the template I had to rename a loop var supplier to supplier1 to resolve
name conflict between template vars.
In the template I added the string: Cancel filter.
Note that this string is already translated:
msgid "Cancel filter"
msgstr ""
Hope this helps.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Undoing the filter works and I checked that the string gets
translated with the po files in current master.
So this is almost perfect, only we can't apply the filters
again and the link remains 'cancel' when we already did.
Sending a follow-up trying to fix this.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10230' into 3.14-master
Jared Camins-Esakov [Sun, 19 May 2013 12:41:05 +0000 (08:41 -0400)]
Merge branch 'bug_10230' into 3.14-master

11 years agoBug 10230: show correct matching record
Jared Camins-Esakov [Sat, 11 May 2013 20:07:43 +0000 (16:07 -0400)]
Bug 10230: show correct matching record

The correct matching record was not always shown on the manage staged
MARC page. This patch corrects the issue and provides the template with
the appropriate ID for the matched record regardless what type of record
it is.

To test:
1) Create a matching record for authorities. For MARC21, the following
   is a good choice:
   Matching rule code:  AUTHPER
   Description:         Personal name main entry
   Match threshold:     999
   Record type:         Authority record
   [Match point 1:]
    Search index:   mainmainentry
    Score:          1000
    Tag:            100
    Subfields:      a
2) Create a record that has the appropriate fields for being matched
   with that rule (if you don't already have one).
3) Save the authority record as MARC (Unicode/UTF-8).
4) Stage the file choosing your new matching rule.
5) Note that with these patches, you get a link to the existing
   authority and without them you could get any number of strange
   things.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script. Additional tests done:
- staged bibliographic records and matched with different
  rules and actions. Undid the import.
- staged autohrity recods and matched with the example rule.
  Undid the import.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 10230: Don't limit valid matches to bibs
Jared Camins-Esakov [Sat, 11 May 2013 19:19:58 +0000 (15:19 -0400)]
Bug 10230: Don't limit valid matches to bibs

The patch for bug 9523 added a JOIN to the biblio table when identifying
the best match so that if a matched record had been deleted it would
not hold up the import process. Unfortunately, this broke all authority
matching, since of course authorities don't appear in the biblio table.
This patch adds a join to auth_header as well, and decides which to
check based on the record type.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment on third patch of this series.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 10230: no need to use SimpleSearch for matching auths
Jared Camins-Esakov [Sat, 11 May 2013 14:40:09 +0000 (10:40 -0400)]
Bug 10230: no need to use SimpleSearch for matching auths

When introducing QueryParser, I introduced a check for QueryParser at
too high a level, causing authority matching to try and use SimpleSearch
for authorities prematurely, when SearchAuthorities should be handling
it. This patch corrects the level of the check. This patch only moves
three lines, but thanks to the change in if level, it adjusts the
indentation quite a bit.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on third patch of this series.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10281' into 3.14-master
Jared Camins-Esakov [Sun, 19 May 2013 12:39:43 +0000 (08:39 -0400)]
Merge branch 'bug_10281' into 3.14-master

11 years agoBug 10281: searching for a search domain fails
Jared Camins-Esakov [Sat, 18 May 2013 13:09:23 +0000 (09:09 -0400)]
Bug 10281: searching for a search domain fails

For reasons I cannot fathom, the split() in handling multi-branch
limits was not coming up with a valid search group code. Replacing
the split() with a substr() and creating the CGI parameter as a string
rather than as an arrayref fixes the problem. This problem may not
affect all installations, since I tested this exact feature just under
two months ago and it worked fine, and none of the relevant code has
been changed since then that I can see.

To test:
1) Create search group, and add at least one library to it, in
   /cgi-bin/koha/admin/branches.pl
2) Apply patch
3) Try doing a search limited to your search group, making sure that
   the search will match items that belong to a library in the search
   group
4) Sign off

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I have failed to recreate the problem on three different dev installs,
both on Ubuntu and Debian, but the current patch does not break
anything as far as I can tell, so I'm signing off.

I tested with two libraries in the same search domain, with each
library owning a different book by the same author. Searching for
the author in
- all libraries,
- individual libraries and
- the search domain that contains both libraries
all return the expected results.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
I couldn't reproduce the problem, but didn't find any regressions.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9452' into 3.14-master
Jared Camins-Esakov [Sun, 19 May 2013 12:38:40 +0000 (08:38 -0400)]
Merge branch 'bug_9452' into 3.14-master

11 years agoBug 9452: C4::Letters not Plack-compatible
Jared Camins-Esakov [Sun, 12 May 2013 18:22:54 +0000 (14:22 -0400)]
Bug 9452: C4::Letters not Plack-compatible

Prior to this patch, at more-or-less random intervals pages working
with notices will cease to function. To test:

1) Apply patch.
2) Try to edit some notices.
3) Trigger some notices.
4) If you were able to edit the notices and trigger the notices, sign
   off.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
I did a regression script without Plack:
- edit, add, delete and copy notice
- trigger checkout/checkin notice
- print issueslip
No problems found.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoFix incorrect entities in PO files
Jared Camins-Esakov [Sun, 19 May 2013 12:12:40 +0000 (08:12 -0400)]
Fix incorrect entities in PO files

There were numerous malformed HTML entities in the PO files for various
languages. No longer.

11 years agoUpdate release notes for Koha 3.12.0 RC3
Jared Camins-Esakov [Sat, 18 May 2013 16:10:11 +0000 (12:10 -0400)]
Update release notes for Koha 3.12.0 RC3
(cherry picked from commit e8030f7f31db1ff9084ea827d3e155358e2054b1)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoTranslation update for 3.12.0
D Ruth Bavousett [Sat, 18 May 2013 15:55:29 +0000 (12:55 -0300)]
Translation update for 3.12.0
(cherry picked from commit a7dd6850903301e5282c13e44a836408943d19d3)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10270' into 3.14-master
Jared Camins-Esakov [Sat, 18 May 2013 10:14:00 +0000 (06:14 -0400)]
Merge branch 'bug_10270' into 3.14-master

11 years agoBug 10270: Fix shebang
Jonathan Druart [Fri, 17 May 2013 14:54:43 +0000 (16:54 +0200)]
Bug 10270: Fix shebang

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 10270: GetOrdersByBiblionumber needs better unit tests
Jonathan Druart [Fri, 17 May 2013 09:38:34 +0000 (11:38 +0200)]
Bug 10270: GetOrdersByBiblionumber needs better unit tests

prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t

Signed-off-by:Mathieu Saby <mathieu.saby@univ-rennes2.fr>
I made 2 tests :
$prove -v t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
and
$prove -v t/db_dependent/Acquisition.t
The 2 tests are successful.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10259' into 3.14-master
Jared Camins-Esakov [Sat, 18 May 2013 10:08:00 +0000 (06:08 -0400)]
Merge branch 'bug_10259' into 3.14-master

11 years agoBug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance...
Tomas Cohen Arazi [Thu, 16 May 2013 14:11:52 +0000 (11:11 -0300)]
Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed

Commented out the code that checks for intance name parameters on the zebra service handling scripts.
It restores the original behaviour, while leaving error checking code.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9824' into 3.14-master
Jared Camins-Esakov [Fri, 17 May 2013 11:59:14 +0000 (07:59 -0400)]
Merge branch 'bug_9824' into 3.14-master

11 years agoBug 9824 - Hide basket with no expected items in basqket list by bookseller
Lyon3 Team [Thu, 21 Mar 2013 13:47:43 +0000 (14:47 +0100)]
Bug 9824 - Hide basket with no expected items in basqket list by bookseller

Before patch you will see in acqui/booksellers.pl all the baskets ever
created.
After the patch you will see in acqui/booksellers.pl only the basket
with expected items.

Test plan :
* Create a basket with some orders lines
You should see this basket in acqui/booksellers.pl
* receive or cancel all the line in this basket
This basket shouldn't appear any more in acqui/booksellers.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10266' into 3.14-master
Jared Camins-Esakov [Fri, 17 May 2013 11:54:19 +0000 (07:54 -0400)]
Merge branch 'bug_10266' into 3.14-master

11 years agoAdd Rafal Kopaczka to the history
Jared Camins-Esakov [Fri, 17 May 2013 11:53:53 +0000 (07:53 -0400)]
Add Rafal Kopaczka to the history

Welcome, Rafal! You are the 211th developer with a patch in Koha.

11 years agoBug 10266 - Statuses not appearing in the OPAC
Rafal Kopaczka [Wed, 15 May 2013 14:19:05 +0000 (16:19 +0200)]
Bug 10266 - Statuses not appearing in the OPAC

Simply revert order of 2 lines in Items.pm. Previous line write to
variable used in next line as function argument.

To Test:

Give an item a special restricted value, define one if you have to
in the authorised values.

Observe that, without this patch, statuses are not shown in the
OPAC in parentheses. My example was an item that had a restricted
value of "Library Staff Only"

It should have been shown under status on the detail page of the
OPAC, but was not.

Apply the patch, observe that restricted values are now shown
for your item, for example:
Available (Library Staff Only) in the status column.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and test plan.
Simple change fixing a display problem, no string changes.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoUpdate 3.12 release notes for Koha 3.12.0-rc2
Jared Camins-Esakov [Thu, 16 May 2013 02:13:08 +0000 (22:13 -0400)]
Update 3.12 release notes for Koha 3.12.0-rc2
(cherry picked from commit bbc4267296a2d00522648eafd232ecc69a31712e)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoLanguage update for 3.12-RC
D Ruth Bavousett [Thu, 16 May 2013 01:45:14 +0000 (22:45 -0300)]
Language update for 3.12-RC
(cherry picked from commit 8e1e34f2fa0c6e85388a1888cda77a0879cb07f5)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10030' into 3.14-master
Jared Camins-Esakov [Thu, 16 May 2013 01:51:55 +0000 (21:51 -0400)]
Merge branch 'bug_10030' into 3.14-master

11 years agoBug 10030: QA Followup for trivial false warning detected while testing
Marcel de Rooy [Wed, 15 May 2013 14:06:49 +0000 (16:06 +0200)]
Bug 10030: QA Followup for trivial false warning detected while testing

Moving the warn line below the line that returns if amount<=0.
If amount<=0, a false warn is now raised because of the return after it.
We should only warn here if we do not return.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested with fines.pl on overdue.
Before this patch:
Reducing fine for item 199709 borrower 23 from 44 to -1 - MaxFine reached.
This did not happen however because of the return.
After this change: no false warning.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 10030 - MaxFines checks against amount, not amount outstanding
Kyle M Hall [Thu, 11 Apr 2013 19:46:50 +0000 (15:46 -0400)]
Bug 10030 - MaxFines checks against amount, not amount outstanding

If a patron has over time accumulated fines greater than the amount
defined in MaxFine, the patron will never get more fines even if they
have previously paid off those fines.

This bug was introduced by the patch for Bug 7420.

Test Plan:
1) Create a patron
2) Create a fine of 10.00 for that patron
3) Pay off the fine
4) Set MaxFines to 5.00
5) Check out an item to the patron, backdate the due date
   so the item should generate fines.
6) Run fines.pl, observe that no fine was created
7) Apply the patch
8) Rerun fines.pl
9) Observe that the fine was created correctly

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'deb_scripts_312_rc1' into 3.14-master
Jared Camins-Esakov [Wed, 15 May 2013 13:32:55 +0000 (09:32 -0400)]
Merge branch 'deb_scripts_312_rc1' into 3.14-master

11 years agoBug 10094 - koha-list should have a --disabled option switch
Tomas Cohen Arazi [Tue, 23 Apr 2013 13:14:37 +0000 (10:14 -0300)]
Bug 10094 - koha-list should have a --disabled option switch

This patch adds that (--disabled) option switch, Also revisits some of the code and docs.

To test:
- Apply the patch and create new packages (you might just drop the koha-list command somewhere)
- Create several instances (koha-create)
- Randomly set some as disabled, others enabled and enable email on some.
- Test all possible option switches combinations

Expected results:
- koha-list should abort with a proper message if mutually exclusive options selected (--email vs. --noemail, --enabled vs. --disabled)
- koha-list should show the exact instances you asked for

Regards
To+

P.S.: I wanted to add the --disabled option switch for the tab-completion work I'm doing, but as of bug 4876 I thought it would be ok to revisit the script to make it robust and clear.

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Does what it says, and cleans up the script at the same time.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 10146 - koha-stop-zebra error handling
Tomas Cohen Arazi [Mon, 29 Apr 2013 14:08:35 +0000 (11:08 -0300)]
Bug 10146 - koha-stop-zebra error handling

koha-stop-zebra now
- Checks the instance exists.
- Checks the instance is enabled.
- Checks if the zebra daemon is already running.

Regards
To+

Edit: Corrected the die message

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 10157 - koha-email-enable error handling
Tomas Cohen Arazi [Tue, 30 Apr 2013 13:05:44 +0000 (10:05 -0300)]
Bug 10157 - koha-email-enable error handling

koha-email-enable now
- Checks the instance exists.
- Checks if email is already enabled.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoBug 10159 - koha-rebuild-zebra error handling
Tomas Cohen Arazi [Tue, 30 Apr 2013 14:58:25 +0000 (11:58 -0300)]
Bug 10159 - koha-rebuild-zebra error handling

This patch makes koha-rebuild-zebra:
- Check for the existence of the instance
- Handle arbitrary amount of instance parameters
- Capture -a and -b (which made the script rebuild twice the chosen DB). It adds the extended version (--authorities and --biblios respectively) of the option switch. This makes the -a and -b switches work as "only do authorities" (or viceversa). They can be used concurrently, which is the default behaviour when no switch is provided.
- Handle -v (and --verbose) as koha-rebuild-zebra options, to ease the use for non-techie users.
- The rebuild_zebra.pl is wrapped inside an IF to return error values if we ever make rebuild_zebra.pl return error codes (this is pointed in the code).
- Added -h/--help switches and an 'usage' output :-D Please provide patches for any wording issues, or contact me to fix it.

To test:
- Apply the patch and create your packages (or just use the script from your branch)
- Run it in this scenarios / options
  - -h/--help to see the available option switches
  - Mix them with one or more instances, of which some could be fake
  - try -a/--authorities and -b/--biblios in all possible combinations
  - try -v/--verbose works

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_6329' into 3.14-master
Jared Camins-Esakov [Wed, 15 May 2013 11:25:38 +0000 (07:25 -0400)]
Merge branch 'bug_6329' into 3.14-master

11 years agoBug 6329 - patron categories should show which fields are required
Owen Leonard [Tue, 14 May 2013 19:09:14 +0000 (15:09 -0400)]
Bug 6329 - patron categories should show which fields are required

When entering a new patron category, required fields are not indicated
on the entry form. This patch adds the "required" class to the relevant
labels.

To test, add or edit a patron category. Confirm that the required fields
(category code, category type, description, and enrollment period) are
indicated as being required with a red label.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely.
Template changes only, but no string changes.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10214' into 3.14-master
Jared Camins-Esakov [Wed, 15 May 2013 11:22:35 +0000 (07:22 -0400)]
Merge branch 'bug_10214' into 3.14-master

11 years agoBug 10214 Add header to syspref po files
Frédéric Demians [Tue, 14 May 2013 11:01:56 +0000 (13:01 +0200)]
Bug 10214 Add header to syspref po files

With this patch, header is created when creating a new syspref .po file
for a new language (translate create), and is added if it doesn't
already exist when updating an existing language (translate update).

To test:

(1) Create a new language syspref file:

    ./translate create -p xx-XX

    Check that there is an header

(2) Update an existing syspref file without header:

    ./translate update fr-FR

    Check that fr-FR-pref.po has a header

(3) Update an existing syspref file with header:

    Modify fr-FR-pref.po. Add an email, or whatever.

    ./translate update fr-FR

    Check that fr-FR-pref.po has a header with the manual modification

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Work as described. No errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Also tested that updated pref files can still be installed correctly.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10108' into 3.14-master
Jared Camins-Esakov [Wed, 15 May 2013 11:16:29 +0000 (07:16 -0400)]
Merge branch 'bug_10108' into 3.14-master

11 years agoBug 10108 - can't print more than one page of overdues
Owen Leonard [Fri, 10 May 2013 18:44:10 +0000 (14:44 -0400)]
Bug 10108 - can't print more than one page of overdues

Printing a report like overdues in Firefox results in a printout which
cuts off in the middle. I traced the cause to something in the YUI grid
system, although I'm not sure what specific definition is the cause.

This patch adds a "screen" parameter to the @import which loads the YUI
grid CSS file. This will disable YUI grid layouts in print views. The
main disadvantage to this, as far as I can tell, is that it will
"linearize" some layouts. For instance: the patron detail page
(moremember.pl) which on screen is divided into two columns. I think
this disadvantage is outweighed by the ability to make complete prints.

To test, apply the patch and clear your cache. Try printing various
reports from Firefox. Printouts should look correct and be complete.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
all tests pass

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
CSS only change, no strings involved.
Tested with a saved SQL report 'select * from borrowers'.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_7593' into 3.14-master
Jared Camins-Esakov [Tue, 14 May 2013 17:46:12 +0000 (13:46 -0400)]
Merge branch 'bug_7593' into 3.14-master

11 years agoBug 7593: Fix unit tests
Jonathan Druart [Mon, 13 May 2013 12:00:44 +0000 (14:00 +0200)]
Bug 7593: Fix unit tests

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_9575' into 3.14-master
Jared Camins-Esakov [Tue, 14 May 2013 12:29:35 +0000 (08:29 -0400)]
Merge branch 'bug_9575' into 3.14-master

11 years agoBug 9575 - Serious Holds Problem with IndependantBranches
Kyle M Hall [Tue, 12 Mar 2013 18:30:48 +0000 (14:30 -0400)]
Bug 9575 - Serious Holds Problem with IndependantBranches

If IndependantBranches is enabled, all holds for an item display the
currently logged in library no matter what, and modifying the holds will
set all pickup locations for all the holds to that logged in library!

Test plan:
 1) Disable IndependantBranches
 2) Place 3 holds on a record with 3 different pickup locations
 3) Enable IndependantBranches
 4) Refresh the holds page for that record, all the holds show now
    show a pickup location of the logged in branch
 5) Modify the order of the holds
 6) Disable IndependantBranches
 7) Refresh the holds, verify the holds all now have a pickup
    location of the logged in branch
 8) Apply the patch
 9) Repeat steps 1-3
10) Refresh the holds page for that record, all the holds should
    now show the correct pickup branch, but it cannot be changed
    as IndependantBranches is enabled.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
In my tests the above test plan only worked out if my user
had no superlibrarian permission. But then behaviour for
independentbranches off/on was all correct.
All tests and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
11 years agoMerge branch 'bug_10233' into 3.14-master
Jared Camins-Esakov [Tue, 14 May 2013 12:17:42 +0000 (08:17 -0400)]
Merge branch 'bug_10233' into 3.14-master