Joe Atzberger [Tue, 28 Apr 2009 23:23:36 +0000 (18:23 -0500)]
Bug 3130 and general cleanup
Javascript error in FF and IE when loading page and no data matches criteria.
This was because it was passing more holds than necessary to the template and
letting a template conditional inside the loop control whether to display or not.
That doesn't make sense, and it forces the table to be displayed even when all
rows FAIL the conditional. jquery.tablesorter was confused trying to be added
on top of an empty table with nothing to sort.
There were several other errors addressed by this patch:
~ 13 unused variables deleted.
~ regexps run on user-supplied $var before checking $var defined
~ decimal ratio prohibited and silently replaced with "3"
I also added the hold ratio to a column display, with a jquery tweak to put it in
the ratio input box on click. Hidden .sql div now contains the actual query run,
like the other wizard reports.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Tue, 28 Apr 2009 23:32:27 +0000 (11:32 +1200)]
Bug 2505 adding warnings to opac-authorities-home and fixing warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jane Wagner [Tue, 28 Apr 2009 12:01:25 +0000 (08:01 -0400)]
Bugs 2822, 2551, 3163 fixes to XSLT
Resent with additional comments.
Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist
uses an icon and label of Sound while the record display page uses
Music. Modified record display to use Sound.
Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect.
The bug report suggested Integrating Resource" but the latest install's
hitlist page uses Continuing Resource. Changed the record display page
to also use Continuing Resource.
Bug 3163 -- if you have a 110 or 710 with a subfield a and a subfield b,
there's no space between them (on either hitlist or record display).
The two headings run together in the display. Modified the utils file
to force a space.
The XSLT files referenced two icons which did not exist (globe.png and
drive_remote.png. Replaced those with icons from the same subject area
(world.png and drive_web.png). Also, corrected spelling of icon name
from pencile.png to pencil.png.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 28 Apr 2009 13:58:05 +0000 (08:58 -0500)]
fix DOS newlines in MARC21slimUtils.xsl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Catalfo [Tue, 28 Apr 2009 12:36:29 +0000 (12:36 +0000)]
bug 3156 followup Fix display of LTFL content when not displaying it in tabs.
LTFL content needs to appear in div rather than span elements. This patch simply replaces the LTFL span elements with divs to fix Bug 3156: LTFL content not displaying if LibraryThingForLibrariesTabbedView sys pref is Off.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Mason James [Fri, 16 Jan 2009 08:16:27 +0000 (21:16 +1300)]
fix to remove blank newlines from labels
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Marc Chantreux [Thu, 8 Jan 2009 00:52:44 +0000 (00:52 +0000)]
don't try to resolve if WEBSERVER_IP is set and now use WEBSERVER_HOST.
as it crashed the installer when DNS doesn't respond as expected.
it will now use the WEBSERVER_HOST described in the doc but unused in the script.
TODO:
- lot of koha-httpd.conf generation is useless if you plan to use vhosts strategy
- on some recent linux distributions, $(getent hosts `hostname`) will give us
127.0.0.1. this is to not mess up the MTA when there is no network. Don't
you think there would be an error message in this case?
- default domain is localdomain .. this is not a good idea but i haven't a better one.
can a network guru fix that ?
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:14:27 +0000 (15:14 +0100)]
(bug #2750) Cannot return to another branch if the independantbranch option is set as ON
The code was modified to change the holding branch ONLY if the return to the right branch is done. If you set IndependantBranch to on, you must return the document to the HomeBranch.
And verify the return is done before show the message that allow to transfert the document to another branch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Mon, 27 Apr 2009 15:13:08 +0000 (17:13 +0200)]
(bug #2961) change the workflow of the new issue
This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as "late"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 27 Apr 2009 15:31:03 +0000 (10:31 -0500)]
bug 2915 followup - small efficiency improvement
Following up on a suggestion by Joe Atzberger, save
a database query by not counting the subscriptions
to delete; instead, simply fetch a list of them.
No user-visible change.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 27 Apr 2009 19:39:36 +0000 (14:39 -0500)]
bug 2893: tweaks to AllowNotForLoanOverride (DB rev 030)
* moved to DB rev 030
* assigned AllowNotForLoanOverride to circulation syspref category
* added a hint to the circulation operator: when the
AllowNotForLoanOverride is ON, if the operator attempts
to check out an item that is normally not for loan due to
its item type or because the item is explicitly marked as
not-for-loan, the operator is given the chance to check
out the item anyway.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Thu, 8 Jan 2009 13:15:31 +0000 (14:15 +0100)]
(bug #2893) Allow loan forcing if a syspref is set
If the syspref 'AllowNotForLoanOverride'(YESNO) is set to YES, the librarian is able to force a loan on an item set as "not for
loan".
If the item is not for loan and the syspref is set to YES, koha will ask to the librarian if he really want to check-out it, else
do nothing.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Marc Chantreux [Fri, 16 Jan 2009 09:23:27 +0000 (09:23 +0000)]
_set_defaults_for_add easier to read
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Mon, 27 Apr 2009 14:17:36 +0000 (16:17 +0200)]
Bug 2920 Display AmazonReviews syspref in the enhanced content category
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 27 Apr 2009 12:29:05 +0000 (07:29 -0500)]
bug 2559: fix search limit on Spanish language (DB rev 029)
Fixes bug where searching with the language limit set
to Spanish would instead retrieve Russian records.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 23 Oct 2008 20:56:22 +0000 (15:56 -0500)]
Followup (1 of 2) to: Correct iso639_2_code for Spanish is "spa" not "rus".
updatedatabase change deferred for now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Mon, 13 Oct 2008 16:46:14 +0000 (11:46 -0500)]
Correct iso639_2_code for Spanish is "spa" not "rus".
The result of this apparent copy/paste error is that adv. search
limits by Language=Spanish would return results for Russian!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 24 Apr 2009 22:31:53 +0000 (17:31 -0500)]
Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 26 Apr 2009 16:45:24 +0000 (11:45 -0500)]
bug 3161: don't display blank language chooser
If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.
Changed so that <div> for the language chooser is output
only if there is more than one enabled language.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Mon, 27 Apr 2009 00:17:21 +0000 (12:17 +1200)]
Whoops missed Brendan's commit, fixed the history now
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Mon, 27 Apr 2009 04:08:21 +0000 (16:08 +1200)]
bug 2505 fixing warnings, I think we have them all for opac-search.pl now
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Mon, 27 Apr 2009 05:49:58 +0000 (07:49 +0200)]
Bug 2920 DB Rev 028 AmazonReviews syspref
Add AmazonReviews syspref.
DOCUMENTATION:
AmazonReviews is OPACAmazonReviews counterpart,
except that in staff interface Editorial Review
is displayed alone, without reader reviews.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Mon, 27 Apr 2009 05:49:57 +0000 (07:49 +0200)]
Bug 2920 Fixes Amazon content use in pro interface
This patch fixes Amazon content use in pro interface :
* Control Amazon Editorial Review by a new syspref:
AmazonReviews.
* /catalogue/detail.tmpl doesn't display Amazon reader reviews.
It displays only Editorial review in Description tab.
This patch disable request for AWS reader reviews.
* Use Amazon TLD for linking book cover to local
Amazon Search Inside.
* Minor clean up on C4::External::Amazon.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Sat, 25 Apr 2009 07:24:54 +0000 (09:24 +0200)]
Bugfix #2920 Avoid doing unecessary calls to Amazon Web Services
This patch modifies how AWS is called. AWS is now called
depending on syspref. It works completly for OPAC; it
has to be refined for intranet.
For OPAC:
* If OPACAmazonReviews is set, AWS EditorialReview and
Reviews (users) are grabed.
* If OPACAmazonSimilarItems is set, AWS Similarities info
are grabed.
* If nothing is asked, AWS is not called anymore,
sparing server bandwidth.
For intranet:
It works as it used to work. AWS is called if AmazonEnabled
is set whatever how other syspref are set.
TODO:
* Add a AmazonReviews syspref
* Request Amazon content depending on AmazonSimilarities
and AmazonReviews syspref
DOCUMENTATION:
It should be explained that Amazon services related syspref
have two levels:
* AmazonEnable / OPACAmazonEnable
* Other: OPACAmazonReviews (new), OPACAmazonSimilarProduct,
OPACAmazonCover
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 26 Apr 2009 15:23:55 +0000 (10:23 -0500)]
bug 2505: fix more warnings in opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Sat, 25 Apr 2009 04:49:48 +0000 (16:49 +1200)]
Bug 2505 Adding use warnings, and fixing the warnings generated
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Sat, 25 Apr 2009 17:29:01 +0000 (13:29 -0400)]
Bug 3148 : Database revision to make zebraqueue.biblio_auth_number as big as auth_header.authid.
If you've never truncated your zebraqueue table, you might want to
update your index and truncate it before applying this patch and running updatedatabase.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 26 Apr 2009 14:48:42 +0000 (09:48 -0500)]
fix warning in C4::AuthoritiesMarc::merge()
"my" variable @X masks earlier declaration in same scope at C4/AuthoritiesMarc.pm line 1200
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sun, 26 Apr 2009 14:48:41 +0000 (09:48 -0500)]
improved POD for C4::Serials::HasSubscriptionExpired()
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Fri, 6 Mar 2009 11:03:21 +0000 (12:03 +0100)]
Fix :Fatal Errors occurs when date is not a regular date
When the start date or the "current date" is not a regular date
the transformation and checkdate fails because there is no
Year/Month/Date
This patch makes it fail more 'silenty' for the users and raises an
error that could be coped with.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel ANGELINETTI [Fri, 30 Jan 2009 15:48:02 +0000 (16:48 +0100)]
(bug #2937) use check_date in C4::Serials::hassubscriptionexpired
This patch change the date check in hassubscriptionexpired to use Date_Calc::check_date
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Sat, 22 Nov 2008 21:23:28 +0000 (22:23 +0100)]
Removing map calls in void context
Thanks Joe.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 14:38:37 +0000 (15:38 +0100)]
problem saving authority with ? and other special characters [resend]
Filtering those signs in order not to have them interpreted.
Removing some warns
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:24 +0000 (14:58 +0100)]
Bug Fix : 2494
Adds some rewriting
bug fix for merging
AddAuthority had some problem with updating existing data.
ModAuthority adds a new Syspref called MergeAuthoritiesOnUpdate which is used to launch or disable biblios update when updating an authority
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:23 +0000 (14:58 +0100)]
Merging authorities caused an encoding problem in biblios
MARC::File::USMARC::decode is not aware of encoding as MARC::File::XML is
So it caused a problem when decoding information and updating biblios.
Now uses MARC::File::XML
Encoding is OK
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:18 +0000 (14:58 +0100)]
Bug Fix : Adding Some error proofs to HaveSubscriptionExpired
Date::Calc::CalcDays was throwing error 500 when one serial had an undefined date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Thu, 20 Nov 2008 18:08:40 +0000 (11:08 -0700)]
Add items.itemnotes to the Notes/Comments search in Marc21
This uncomments the 952$z and assigns it to the Notes index in
marc21
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Mason James [Thu, 2 Apr 2009 05:01:07 +0000 (18:01 +1300)]
BUG:3072 small work-around patch to restore authorities searching
this is a work-around fix, until a future patch arrives to define the missing 'Heading-Main' zebra-index.
for 3.0.x
[RM note: also included in HEAD so that I can include the UNIMARC(A)
updates by HDL]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:34 +0000 (14:58 +0100)]
Improving UNIMARC(A) compliance
Adding some fields to index.
Adding also some indexes in order to be able to query specific fields.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:13 +0000 (14:58 +0100)]
Bug Fixing : searching on mainmainentry was disabled
Adding Heading-Main as new index code in order to search only on Heading-main when $a selected.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:14 +0000 (14:58 +0100)]
Minor Feature : username when cataloguing
biblios can now be added librarian name automatically when cataloguing.
add "user" in the Default value of the biblio
[RM doc note: in other words, if in the MARC framework you set
the default value of a subfield to 'user', the username of the
cataloger will be entered into that subfield whenever you create
or modify that bib in the Koha bib editor.]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Wed, 12 Nov 2008 03:31:34 +0000 (22:31 -0500)]
Bug 2776 : emailPurchaseSuggestions syspref deprecated
This patch removes the system preference from new installations.
No db revision is supplied to remove the system pref from existing installations.
It is recommended for administrators to use the scripts provided in the misc/ directory
to ensure that their system preferences are in sync with those used in code.
Admins should remove this preference from existing installations manually.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:20 +0000 (14:58 +0100)]
Adding some Error proof on GetAuthority
return undef if there is a problem
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:12 +0000 (14:58 +0100)]
Restoring startsby search on authorities.
[RM note: fixes bug 2792]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Mason James [Sat, 25 Apr 2009 01:18:58 +0000 (13:18 +1200)]
BUG-3160: fixes 'itemlost' check on item return.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sat, 25 Apr 2009 01:35:52 +0000 (20:35 -0500)]
fix XHTML error - duplicate tabindex
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sat, 25 Apr 2009 01:35:53 +0000 (20:35 -0500)]
fix default authority search in bib editor
When clicking on the '...' of an headings field
in the bib editor, the authority search that
popped up did not take the default search
string from the bib field. Fixed by making
sure that openAuth is always used to do the
popup link.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 24 Apr 2009 20:09:55 +0000 (15:09 -0500)]
Bug 3127 - Stub function prevents undefined reference
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Fri, 24 Apr 2009 20:11:02 +0000 (08:11 +1200)]
New developer for history.txt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Sat, 25 Apr 2009 00:46:36 +0000 (19:46 -0500)]
bug 3159: allow editing child patron that has no valid guarantor
If a patron with a child patron category is not linked
to a guarantor (or a valid one), it was not possible to edit
the child patron's record. When attempt, no changes were saved
and the following error is recorded in the Apache error log:
memberentry.pl: DBD::mysql::st execute failed: Cannot add or
update a child row: a foreign key constraint
fails (`gmc_koha/borrowers`, CONSTRAINT `borrowers_ibfk_2`
FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) ...
This patch fixes this bug, allowing a child patron record to be
edited even if it has no guarantor.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 24 Apr 2009 16:25:05 +0000 (11:25 -0500)]
changed OAI-PMH implementation
Replaced older OAI-PMH server implementation
with new one by Frédéric Demians.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 24 Apr 2009 17:30:19 +0000 (12:30 -0500)]
Make js prompts translatable using _("...") and comment out unused vars.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Brian Harrington [Fri, 24 Apr 2009 18:39:54 +0000 (14:39 -0400)]
Revisions to auto-generated authorities patch
It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl. I
also realized I can't count. :-)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
David Goldfein [Fri, 24 Apr 2009 18:21:24 +0000 (13:21 -0500)]
Modified log reporting to allow multiple modules to be selected.
Reworked ViewLog.pl and the template. Eliminated html errors, cleaned up
the template, change mime type to text/csv and other minor changes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 24 Apr 2009 17:53:44 +0000 (11:53 -0600)]
New feature - database update - Number of Returned Items to Show
This is the database update to add the system preference for
numReturnedItemsToShow
[RM note: DB rev 026]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 24 Apr 2009 17:53:43 +0000 (11:53 -0600)]
New feature Number of Returned Items to Show
This adds a system preference controlled feature. This controls how
many returned items are shown on the check-in page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 24 Apr 2009 18:06:45 +0000 (13:06 -0500)]
DB rev 025: ceilingDueDate syspref
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 25 Feb 2009 22:08:26 +0000 (15:08 -0700)]
New feature ceiling Due Date - database update
This updates the database to add the syspref ceilingDueDate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Thu, 5 Mar 2009 21:21:56 +0000 (14:21 -0700)]
New feature ceiling Due Date.
This adds a feature and system preference: ceilingDueDate. If this is
set to a valid ( according to dateformat syspref ) date, then calculated
due dates will be less than this date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 19 Sep 2008 00:02:46 +0000 (19:02 -0500)]
Cleanup and tighten Letters module.
Subroutine arguments enforced w/ with more checks, explicit return undef where warranted.
Placeholders used in SQL where applicable.
One logical error corrected :
- next MESSAGE if ( lc( $message->{'message_transport_type'} eq 'rss' ) );
+ next MESSAGE if ( lc($message->{'message_transport_type'}) eq 'rss' );
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 9 Jan 2009 21:42:27 +0000 (15:42 -0600)]
Basic reformat of section in Search.pm
In for loops, replace all-inclusive conditional blocks like:
for (@foo) {
if (test) {
block;
}
}
with conditional use of "next":
for (@foo) {
test or next;
block;
}
This reduces the number of unnecessarily nested blocks, and the
overall number of lines.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Nighswonger [Thu, 29 Jan 2009 10:07:09 +0000 (05:07 -0500)]
kohabug 2934 - Wrong datatype causes artificial limit to label batch id's
labels.batch_id should be int as the value is always an integer. This corrects
the problem.
[RM note: ported patch to HEAD. DB rev 024]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 12 Sep 2008 19:16:58 +0000 (13:16 -0600)]
Use biblioitems.itemtype as a default for items.itype
This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem. The code in
Items is to catch items added through MARC record staging.
Thanks to Joe Atzberger for suggestion.
[RM note: this patch means that an item's item-level item type,
once that item is added or updated via additem.pl,
now cannot be blank or NULL unless the biblio-level item type
is blank.]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 24 Apr 2009 14:57:24 +0000 (09:57 -0500)]
bug 2505 followup: restored correct item type image display
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 17 Dec 2008 22:32:25 +0000 (16:32 -0600)]
Bug 2505: adding warnings to opac-detail.pl
Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frederic Demians [Wed, 21 Jan 2009 12:28:34 +0000 (13:28 +0100)]
Modify GoogleJacket display
On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.
This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 21 Jan 2009 01:18:20 +0000 (19:18 -0600)]
Block warning on detail.pl.
If Amazon doesn't have an avg. rating number defined, then we cannot multiply it
by 20 without the following warning:
detail.pl: Use of uninitialized value in multiplication (*)
at /home/user/kohaclone/catalogue/detail.pl line 228.
So the important part of this patch is || 0 on the $average_rating assignment.
[RM note: applying for whitespace cleanup]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 17 Dec 2008 22:30:46 +0000 (16:30 -0600)]
refactor: removing a few unnecessary loops and moving HTML out of script into template
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 24 Apr 2009 13:41:24 +0000 (08:41 -0500)]
bug 2765: updatedatabase to increase width of ISBN columns
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:26 +0000 (14:58 +0100)]
bug fix 2765
Changing isbn data from 14 to 30 in order to manage friendlier,
isbn with - inside, and multiple isbns.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 23 Jan 2009 17:57:58 +0000 (11:57 -0600)]
Cleanup, pod fix and FIXME's added.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 24 Apr 2009 13:16:30 +0000 (08:16 -0500)]
DB rev 022: set DBrev for bug 2945 fix
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 4 Feb 2009 19:55:03 +0000 (13:55 -0600)]
Bug 2945: increase size of labels_conf.formatstring (DB update)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jane Wagner [Fri, 24 Apr 2009 12:33:50 +0000 (08:33 -0400)]
Bug 3152 OPAC reading history column headers don't line up with text
Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 23 Apr 2009 22:23:24 +0000 (17:23 -0500)]
Bug 3128 - followup and correction
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 22 Apr 2009 21:16:56 +0000 (16:16 -0500)]
Bug 3128: IE7 tweak
Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 24 Apr 2009 12:38:04 +0000 (07:38 -0500)]
fixed typos in LTFL sysprefs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Stephen Edwards [Thu, 23 Apr 2009 16:45:54 +0000 (12:45 -0400)]
bug 3093: Enhance placing of holds in the staff interface.
This patch allows staff users to request reserves on multiple
items at one time.
Added checkboxes, select-all, clear-all, and place-hold button to
staff search results page. Place-hold button will only appear if
the user has permission to place holds for others. Item-level
Place-Hold button will not appear for multiple holds, nor will
the vertical detail menu.
Patron input page now shows multiple items, if applicable.
Hold confirmation page shows results for multiple items, if
applicable. Those which cannot be reserved are highlighted and
are excluded from the reservation. The reservation is placed at
the biblio number (i.e. next available) level.
Fixed display of item type.
Removed side menu for multiple items; removed item-oriented button for multiple items.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 24 Apr 2009 11:05:09 +0000 (06:05 -0500)]
bug 3155 followup: tweak OPACAmazonReviews syspref
* add to enhanced content tab of syspref editor
* during upgrade, if database has OPACAmazonEnabled
turned on, ensure that OPACAmazonReviews is on
as well.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Fri, 24 Apr 2009 05:15:43 +0000 (07:15 +0200)]
DB rev 020 -> 021: OPACAmazonReviews syspref
Add new OPACAmzonReviews syspref
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Fri, 24 Apr 2009 05:15:42 +0000 (07:15 +0200)]
Bugfix #3155 Disabling Amazon Reviews
Disable Amazon reviews without disabling Amazon book cover.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Thu, 23 Apr 2009 21:59:17 +0000 (09:59 +1200)]
New Developer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Apr 2009 21:11:08 +0000 (16:11 -0500)]
DB rev 019 -> 020: LTFL support
Extends Christopher Hyde's patches to add LTFL support
as follows:
* adds fr-FR system preferences
* adds updatedatabase.pl
The three new system preferences are:
LibraryThingForLibrariesEnabled - turn ON to enable LTFL support
LibraryThingForLibrariesID - client ID for LTFL service
LibraryThingForLibrariesTabbedView - put LTFL content in tabs on bib detalis page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Apr 2009 21:10:45 +0000 (16:10 -0500)]
fix XHTML validation errors in LTFL output
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Christopher Hyde [Fri, 3 Apr 2009 13:27:04 +0000 (09:27 -0400)]
Fixed minor error in comment code
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Christopher Hyde [Thu, 2 Apr 2009 14:50:35 +0000 (10:50 -0400)]
Changes Made to further optimize and condense code, include code documentation, and fix hardcoded instead of syspref'd library thing id
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Christopher Hyde [Wed, 1 Apr 2009 18:03:21 +0000 (14:03 -0400)]
Changes made: Fixed typo/bug which had wrong order for if statement checking to see whether
Committer: Christopher Hyde <chyde@ebpl.org>
modified: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Christopher Hyde [Wed, 1 Apr 2009 18:03:20 +0000 (14:03 -0400)]
Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page
modified: admin/systempreferences.pl
modified: installer/data/mysql/en/mandatory/sysprefs.sql
modified: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
modified: opac/opac-detail.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
John Beppu [Thu, 23 Apr 2009 19:35:53 +0000 (14:35 -0500)]
bug 1546 - replacing REPLACE statements
replaced REPLACE statements with a pair of INSERT and UPDATE statements.
Hopefully, these are the last ones.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Apr 2009 19:54:15 +0000 (14:54 -0500)]
DBrev 018 -> 019
Also corrected message upon addition of new
OPACShowCheckoutName syspref.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jane Wagner [Wed, 22 Apr 2009 16:08:43 +0000 (12:08 -0400)]
Creates a syspref & modifies template to show checked out username in OPAC
Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC. Most libraries will want
to leave this turned off!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 22 Apr 2009 20:22:38 +0000 (15:22 -0500)]
Bug 3118: Remove comment that perturbs IE
Formatting bugs not fixed. Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected. Go figure.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Wed, 22 Apr 2009 23:33:41 +0000 (11:33 +1200)]
Adding the dev weekend and another developer to the history docs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 22 Apr 2009 18:24:34 +0000 (13:24 -0500)]
IE bugs 3124 and 3115: z3950 search and guided_reports
Clip trailing comma in js list argument.
Column selection improved with jquery and submit time check.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Wed, 22 Apr 2009 23:33:40 +0000 (11:33 +1200)]
Typo in history docs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 20 Apr 2009 18:25:01 +0000 (13:25 -0500)]
Fix for Bug 3119: Add due date to the patron circulation history window
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 21 Apr 2009 20:19:42 +0000 (15:19 -0500)]
Fix for Bug 1877, Link to patron record from manage suggestions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Brian Harrington [Tue, 21 Apr 2009 16:13:22 +0000 (12:13 -0400)]
Patch to improve auto-generated MARC21 authorities
This patch makes sure that MARC21 authorities have a minimal
Leader, 008, and 040. If an authority record is created through
BiblioAddsAuthority it generates a 670 based on information in
the bib record.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 21 Apr 2009 19:12:55 +0000 (14:12 -0500)]
Adding link back to OPAC for emailed cart and lists.
Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Brendan A. Gallagher [Sat, 18 Apr 2009 21:15:01 +0000 (17:15 -0400)]
Bug #3101 - Changed the Print and Confirm button
Changed button to read "Print slip, Transfer and Confirm"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>