]> git.koha-community.org Git - koha.git/commit
Bug 29658: Fix crash on cancelling cancelled order
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 8 Dec 2021 13:44:38 +0000 (13:44 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 31 Oct 2022 20:54:25 +0000 (20:54 +0000)
commit22e6fd7cd86087bd6a938955ed4d2df678090432
tree72f670557a50e9e222d9ab9d903ba6108a7155d4
parent9651875981bb8ccbd7155c0b65b10dd340fa233c
Bug 29658: Fix crash on cancelling cancelled order

Found this crash in our 20.11 logs:
Cannot insert order: Mandatory parameter biblionumber is missing at /usr/share/koha/acqui/cancelorder.pl line 60.
 at /usr/share/perl/5.28/Carp.pm line 289
        Carp::croak('Cannot insert order: Mandatory parameter biblionumber is missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79
        Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)') called at /usr/share/koha/Koha/Acquisition/Order.pm line 189
        Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)', 'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60

Not sure how to reproduce this one as it happened. But might be related to repeated clicking, backspacing etc.

Test plan:
Create a new basket and order.
Open this same basket in two browser tabs.
Cancel the order line (delete catalog record) in tab 1.
Go to second tab, try again.
Without this patch, it will crash. With this patch, an error message.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2a3ba5f8253c6bafef17caf03645d70a90a96dea)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
acqui/cancelorder.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/cancelorder.tt