]> git.koha-community.org Git - koha.git/commit
Bug 24254: Read the OpacHiddenItems preference internally
authorTomas Cohen Arazi <tomascohen@theke.io>
Sat, 19 Dec 2020 13:21:18 +0000 (10:21 -0300)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Fri, 29 Jan 2021 18:42:31 +0000 (18:42 +0000)
commit2369428d7049f9847ed4ac578684a81fe03df4d0
tree6c23374dae976d425a7ae2fabdfab5c8f1169ae7
parent4ffe7ddac04b0240b8007df6521fe6e65e403241
Bug 24254: Read the OpacHiddenItems preference internally

After discussing the 'rules' parameter usefulness we decided it was not
the best idea, and the gains in terms of 'performance' would me
meaningless (in-memory caching of sysprefs). This patch makes a really
minor tweak to the tests so they mock the C4::Context->yaml_preference
method, but keeping the same original rules to highlight no behaviour
change takes place.

Then the rules parameter is removed from the calls, and the tests should
keep passing.

A minor change to make $rules = undef is made to highlight the // {}
behaviour when reading the syspref..

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Koha/Items.pm
t/db_dependent/Koha/Items.t