Bug 34051: Cache empty hashref for non-existent authorised values
authorDavid Cook <dcook@prosentient.com.au>
Mon, 19 Jun 2023 01:26:35 +0000 (01:26 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 17 Jul 2023 12:18:53 +0000 (13:18 +0100)
commit25230f4cf91a591dcfdf5bcac00e1d085b1c4b41
treecab56255785b07020b40b2eb0e83d61dc0a46fcb
parentd636c81cd60623504cb265b7dd9e63b54dbc23cb
Bug 34051: Cache empty hashref for non-existent authorised values

When fetching authorised value descriptions, we need to handle
scenarios where a value doesn't exist in the cache and doesn't
exist in the database. In this situation, we return an empty
hashref, and this patch makes us cache this empty hashref.

This is important because otherwise the function
Koha::AuthorisedValues->get_description_by_koha_field will
do a database call every time it encounters the same value that
doesn't exist in the authorised values table.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit a3a0aaec102b05fc5a5b0573e1888facd22a731f)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Koha/AuthorisedValues.pm