]> git.koha-community.org Git - koha.git/commit
Bug 34848: Fix SIP/Message.t if DB has been upgraded
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 20 Sep 2023 14:00:08 +0000 (16:00 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 22 Sep 2023 19:58:32 +0000 (09:58 -1000)
commit3041af984ab54ce3e70e13814d0f8fb56f3ee908
tree1569c25d74a38a60bb1834bebea1cb27eb8d6481
parent9452ff0095fcfbdc48de4de52dd8524f99c92afd
Bug 34848: Fix SIP/Message.t if DB has been upgraded

There were a lot of failures (in the context of bug 34841)

t/db_dependent/SIP/Message.t .. 2/16
    #   Failed test 'Found AH field as timestamp in response'
    #   at t/db_dependent/SIP/Message.t line 820.

    #   Failed test 'Found AH field as SQL date in response'
    #   at t/db_dependent/SIP/Message.t line 825.
    # Looks like you failed 2 tests of 8.
t/db_dependent/SIP/Message.t .. 3/16

    #   Failed test 'Desensitize flag was set for patron category not in inhouse_patron_categories'
    #   at t/db_dependent/SIP/Message.t line 1133.
    #          got: 'N'
    #     expected: 'Y'

    #   Failed test 'Desensitize flag was set for empty inhouse_patron_categories'
    #   at t/db_dependent/SIP/Message.t line 1139.
    #          got: 'N'
    #     expected: 'Y'

Because renewalsallowed is 0 for upgraded DB, when it's 5 for new
install.

We need to set the value.

This patch also adds some missing transaction

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 4fd7857e3fcc0314aba2fe851082e6e125a16650)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
t/db_dependent/SIP/Message.t