]> git.koha-community.org Git - koha.git/commit
Bug 34859: Remove unnecessary params from reports-home.pl
authorDavid Cook <dcook@prosentient.com.au>
Thu, 21 Sep 2023 01:27:45 +0000 (01:27 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 6 Oct 2023 00:52:14 +0000 (14:52 -1000)
commit3fed05a8dfa36ab0c7da07fde2e6956ce94077b6
tree4d028843ae9922ee5211b65da9d8340739e39f0f
parent96c97fb95f6258a04deafd75fc96ba6182c47d27
Bug 34859: Remove unnecessary params from reports-home.pl

This change removes unnecessary syspref template parameters
and tidies the code.

Test plan:
0. Apply the patch and koha-plack --reload kohadev
1. Go to
/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav
2. Add the following and save:
<li><a href="#">Awesome</a></li>
3. Go to
/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetstylesheet
4. Add the following and save:
http://bad
5. Go to
/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetcolorstylesheet
6. Add the following and save:
http://bad2
7. Go to /cgi-bin/koha/reports/reports-home.pl
8. Note the "Awesome" link in the top navbar
9. Note in the console that there are two errors where http://bad
and http://bad2 can't be resolved

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7382e305e1bc6c43c74397f135e2267fcb9f8e4e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
reports/reports-home.pl