]> git.koha-community.org Git - koha.git/commit
Bug 25872: Fix scoping of $limits
authorNick Clemens <nick@bywatersolutions.com>
Thu, 13 Aug 2020 12:56:33 +0000 (12:56 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 18 Aug 2020 13:45:21 +0000 (15:45 +0200)
commit43dc505a52a2679e40a22ff610c91552cd8f2fd1
treeab41188d84a752a7358ec534ea2b26bf0d3ec657
parent2f3a886f7b23f37f04a687cb0c1755c3195c2ce6
Bug 25872: Fix scoping of $limits

The code in build_query_compat contained a 'my' in the assigning of limits for the search in a conditional

This meant the limits were being set correctly during the conditional, but we blanked when passed to the rest
of the code. The effect was that the searches worked, however, the template params to repeat the search were
incomplete.

Removing the my ensures the same limits are applied during search and on re-sorting

To test:
1 - Enable Elasticsearch
2 - On OPAC perform advanced search, selecting only an itype, ccode, or LOC limit
3 - Attempt to sort results
4 - You are returned to Advanced search
5 - Apply patch
6 - Repeat
7 - It sorts!

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/SearchEngine/Elasticsearch/QueryBuilder.pm