]> git.koha-community.org Git - koha.git/commit
Bug 11742: A letter code should be unique.
authorJonathan Druart <jonathan.druart@biblibre.com>
Wed, 7 May 2014 14:12:39 +0000 (16:12 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 23 Jun 2014 18:19:55 +0000 (15:19 -0300)
commit5c4fdcf78aab2d284f3b88f9926756acb6a4d48f
treeef01ef6118c1bd279e75c27db6c409a1219da7ad
parent1976ec2020a0a17a7b73ac3acac491532ef3e66d
Bug 11742: A letter code should be unique.

This patch is a dirty way to fix a design issue on notices.
Currently the code assumes that a letter code is unique. Which is wrong,
the primary key is module, code, branchcode.

Maybe we should add a primary key (id) for the letter table in order to
pass the id to the template and correctly manage the letter code
duplication.

Test plan:
Try to duplicate a letter code using edit, add and copy actions.
If you manage to do it, please describe how you did.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
C4/Letters.pm
koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
svc/letters [new file with mode: 0755]
tools/letter.pl