]> git.koha-community.org Git - koha.git/commit
Bug 31120: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 7 Jul 2022 19:14:59 +0000 (15:14 -0400)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 2 Sep 2022 20:18:18 +0000 (20:18 +0000)
commite20879a8f5c9c13886c2f5073df379de28373c6d
tree37ca893331617443ddfeb9af751050612021c4b2
parentd23293acb5525ac799cf84173015edd80f3caded
Bug 31120: Items will renew for zero ( 0 ) days if renewalperiod is blank/empty value

If the rule renewalperiod is the blank empty string instead of being null/undefined or non-existant, Koha will interpret the renewal period as being zero days instead of falling back to the issuelength rule.

It makes sense to me that a literal 0 here should make it renew for zero days even though that is nonsensical.

Test Plan:
1) Delete all your rules
2) Create an all/all/all rules with an empty string for renewal base
   period
3) Note that renewing an item does nothing
4) Apply this patch
5) Restart all the things!
6) Renew again
7) Note the renewal uses the issuelength rule as intended

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9b010d99dfcb1a77a6ebd679aabafd819c6e67cf)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Circulation.pm