]> git.koha-community.org Git - koha.git/commit
Bug 12537: Don't retrieve XISBN results for the same biblionumber
authorNick Clemens <nick@bywatersolutions.com>
Mon, 10 Jun 2019 18:54:30 +0000 (18:54 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 15 Jul 2019 10:27:59 +0000 (11:27 +0100)
commitfd5686b156ceb10958cab728b7695aa2b39b9933
treecbe6b6cd91f835b3fbbbc1df04506ed9a7b7a4a3
parentf45516e73ab6ac8c2240f206bd11a88e4935359c
Bug 12537: Don't retrieve XISBN results for the same biblionumber

For a biblio with multiple ISBNS we sometimes get our own record back when
check XISBN, we should test for this

To test:
1 - Edit a record in the catalogue, add two isbns:
     0521240670
     0521284198
2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions
3 - View the record in staff and OPAC
4 - You should see editions tab pointing to the same record
5 - Apply patch
6 - Reload the record details, you should no longer see editions tab
7 - Add the second ISBN to another record
8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN
9 - prove -v t/db_dependent/XISBN.t

NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/XISBN.pm
catalogue/detail.pl
opac/opac-detail.pl
t/db_dependent/XISBN.t