From 2110299db00969beecbff445c1233b4349ac53cb Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Wed, 6 Jan 2021 03:04:42 +0000
Subject: [PATCH] Bug 27023: (QA follow-up) Fix span tags

One of the opening tags was missing the > and another was in the
wrong spot (started after the IF, but ending outside ouf it)

Move spaces around a bit so the strings don't start with spaces.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../prog/en/modules/suggestion/suggestion.tt         | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
index 092ec5d9e8..a227fc244f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
@@ -603,9 +603,15 @@
                     <a href="suggestion.pl?suggestionid=[% suggestions_loo.suggestionid | uri %]&amp;op=show" title="suggestion" >
                         [% suggestions_loo.title | html %][% IF ( suggestions_loo.author ) %], by [% suggestions_loo.author | html %][% END %]</a>
                     <br />
-                    [% IF ( suggestions_loo.copyrightdate ) %]&copy;<span class="suggestion_copyrightdate"> [% suggestions_loo.copyrightdate | html %]</span> [% END %]
-                        [% IF ( suggestions_loo.volumedesc ) %]; <span class="suggestion_volume"Volume:<em>[% suggestions_loo.volumedesc | html %]</em></span> [% END %]
-                        [% IF ( suggestions_loo.isbn ) %];<span class="suggestion_isbn"> ISBN:<em>[% suggestions_loo.isbn | html %]</em></span> [% END %][% IF ( suggestions_loo.publishercode ) %];<span class="suggestion_publishercode"> Published by [% suggestions_loo.publishercode | html %]</span> [% END %][% IF ( suggestions_loo.publicationyear ) %]in<span class="suggestion_publicationyear"> <em>[% suggestions_loo.publicationyear | html %]</em></span> [% END %][% IF ( suggestions_loo.place ) %]in <span class="suggestion_place"><em>[% suggestions_loo.place | html %]</em></span> [% END %][% IF ( suggestions_loo.collectiontitle ) %];<span class="suggestion_collectiontitle"> [% suggestions_loo.collectiontitle | html %]</span> [% END %][% IF ( suggestions_loo.itemtype ) %];<span class="suggestion_itype"> [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestions_loo.itemtype, 0 ) | html %] [% END %]</span><br />[% IF ( suggestions_loo.note ) %]<div class="suggestion_note"><i class="fa fa-comment"></i> [% suggestions_loo.note | html %]</div>[% END %]
+                    [% IF ( suggestions_loo.copyrightdate ) %]&copy; <span class="suggestion_copyrightdate">[% suggestions_loo.copyrightdate | html %]</span> [% END %]
+                        [% IF ( suggestions_loo.volumedesc ) %]; <span class="suggestion_volume">Volume:<em>[% suggestions_loo.volumedesc | html %]</em></span> [% END %]
+                        [% IF ( suggestions_loo.isbn ) %]; <span class="suggestion_isbn">ISBN: <em>[% suggestions_loo.isbn | html %]</em></span> [% END %]
+                        [% IF ( suggestions_loo.publishercode ) %]; <span class="suggestion_publishercode">Published by [% suggestions_loo.publishercode | html %]</span> [% END %]
+                        [% IF ( suggestions_loo.publicationyear ) %]in <span class="suggestion_publicationyear"><em>[% suggestions_loo.publicationyear | html %]</em></span> [% END %]
+                        [% IF ( suggestions_loo.place ) %]in <span class="suggestion_place"><em>[% suggestions_loo.place | html %]</em></span> [% END %]
+                        [% IF ( suggestions_loo.collectiontitle ) %]; <span class="suggestion_collectiontitle">[% suggestions_loo.collectiontitle | html %]</span> [% END %]
+                        [% IF ( suggestions_loo.itemtype ) %]; <span class="suggestion_itype">[% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestions_loo.itemtype, 0 ) | html %]</span> [% END %]<br />
+                        [% IF ( suggestions_loo.note ) %]<div class="suggestion_note"><i class="fa fa-comment"></i> [% suggestions_loo.note | html %]</div>[% END %]
                         [% IF suggestions_loo.archived %]<br /><i class="fa fa-archive"></i> Archived[% END %]
                 </td>
                 <td>
-- 
2.39.5